diff mbox

[v4] sparse: option to print compound global data symbol info

Message ID 56ad8e79-72d5-b1e2-a8fc-a84d3b9716bb@infradead.org (mailing list archive)
State Mainlined, archived
Headers show

Commit Message

Randy Dunlap April 12, 2018, 4:32 p.m. UTC 
From: Randy Dunlap <rdunlap@infradead.org>
with help from Linus (many moons ago) and Luc this year.

sparse addition to print all compound/composite global data symbols
with their sizes and alignment.

usage: -vcompound
Example:
  $ sparse -vcompound symbol-sizes.c
  compound-sizes.c:39:17: union un static [toplevel] un: compound size 192, alignment 8
  compound-sizes.c:42:25: struct inventory static [toplevel] inven[100]: compound size 19200, alignment 8
  compound-sizes.c:51:33: struct inventory static [toplevel] [usertype] invent[10]: compound size 1920, alignment 8
  compound-sizes.c:58:25: float static [toplevel] floats[42]: compound size 168, alignment 4
  compound-sizes.c:59:25: double static [toplevel] doubles[84]: compound size 672, alignment 8

and validation:
$ ./test-suite   single compound-sizes.c
     TEST    compound-sizes (compound-sizes.c)
compound-sizes.c passed !

Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
---
v3: incorporate Luc's valuable help
v4: incorporate more of Luc's valuable help

 lib.c                       |    2 
 lib.h                       |    1 
 sparse.c                    |   35 +++++++++++++
 validation/compound-sizes.c |   87 ++++++++++++++++++++++++++++++++++
 4 files changed, 125 insertions(+)


--
To unsubscribe from this list: send the line "unsubscribe linux-sparse" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Comments

Luc Van Oostenryck April 12, 2018, 8:20 p.m. UTC | #1 
On Thu, Apr 12, 2018 at 09:32:31AM -0700, Randy Dunlap wrote:
> From: Randy Dunlap <rdunlap@infradead.org>
> with help from Linus (many moons ago) and Luc this year.
> 
> sparse addition to print all compound/composite global data symbols
> with their sizes and alignment.


Thanks.
Acked-by: Luc Van Oostenryck <luc.vanoostenryck@gmail.com> 
--
To unsubscribe from this list: send the line "unsubscribe linux-sparse" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

--- spars-052rc1.orig/sparse.c
+++ spars-052rc1/sparse.c
@@ -271,6 +271,39 @@  static void check_context(struct entrypo
 	check_bb_context(ep, ep->entry->bb, in_context, out_context);
 }
 
+/* list_compound_symbol - symbol info for arrays, structures, unions */
+static void list_compound_symbol(struct symbol *sym)
+{
+	struct symbol *base;
+
+	/* Only show symbols that have a positive size */
+	if (sym->bit_size <= 0)
+		return;
+	if (!sym->ctype.base_type)
+		return;
+	if (is_func_type(sym))
+		return;
+	/* Don't show unnamed types */
+	if (!sym->ident)
+		return;
+
+	if (sym->type == SYM_NODE)
+		base = sym->ctype.base_type;
+	else
+		base = sym;
+	switch (base->type) {
+	case SYM_STRUCT: case SYM_UNION: case SYM_ARRAY:
+		break;
+	default:
+		return;
+	}
+
+	info(sym->pos, "%s: compound size %u, alignment %lu",
+		show_typename(sym),
+		bits_to_bytes(sym->bit_size),
+		sym->ctype.alignment);
+}
+
 static void check_symbols(struct symbol_list *list)
 {
 	struct symbol *sym;
@@ -286,6 +319,8 @@  static void check_symbols(struct symbol_
 
 			check_context(ep);
 		}
+		if (dbg_compound)
+			list_compound_symbol(sym);
 	} END_FOR_EACH_PTR(sym);
 
 	if (Wsparse_error && die_if_error)
--- spars-052rc1.orig/lib.c
+++ spars-052rc1/lib.c
@@ -257,6 +257,7 @@  int dump_macro_defs = 0;
 
 int dbg_entry = 0;
 int dbg_dead = 0;
+int dbg_compound = 0;
 
 int fmem_report = 0;
 int fdump_linearize;
@@ -598,6 +599,7 @@  static char **handle_switch_W(char *arg,
 static struct warning debugs[] = {
 	{ "entry", &dbg_entry},
 	{ "dead", &dbg_dead},
+	{ "compound", &dbg_compound},
 };
 
 
--- spars-052rc1.orig/lib.h
+++ spars-052rc1/lib.h
@@ -150,6 +150,7 @@  extern int dump_macro_defs;
 
 extern int dbg_entry;
 extern int dbg_dead;
+extern int dbg_compound;
 
 extern int fmem_report;
 extern int fdump_linearize;
--- /dev/null
+++ spars-052rc1/validation/compound-sizes.c
@@ -0,0 +1,87 @@ 
+// This tests sparse "-vcompound" output.
+
+#include <stdlib.h>
+#include <stdint.h>
+
+// Do not list functions.
+static int do_nothing(void)
+{}
+
+// no:
+static inline int zero(void)
+{
+	return 0 / 1;
+}
+
+// no:
+struct inventory {
+	unsigned char	description[64];
+	unsigned char	department[64];
+	uint32_t	dept_number;
+	uint32_t	item_cost;
+	uint64_t	stock_number;
+	uint32_t	tally[12];	// per month
+};
+
+// no
+static struct inventory *get_inv(uint64_t stocknum)
+{
+	return NULL;
+}
+
+// no
+union un {
+	struct inventory inv;
+	unsigned char	bytes[0];
+};
+
+// yes
+static union un un;
+
+// yes
+static struct inventory	inven[100];
+
+// no
+typedef struct inventory	inventory_t;
+
+// no
+static struct inventory	*invptr;
+
+// yes
+static inventory_t		invent[10];
+
+// no
+static float		floater;
+static double		double_float;
+
+// yes
+static float		floats[42];
+static double		doubles[84];
+
+// no
+int main(void)
+{
+	// no, these are not global.
+	struct inventory inv[10];
+	inventory_t	invt[10];
+	// what about statics?
+	static struct inventory invtop;
+	static inventory_t inv_top;
+	static uint64_t stocknums[100];
+
+	invptr = get_inv(42000);
+	return 0;
+}
+
+/*
+ * check-name: compound-sizes
+ * check-command: sparse -vcompound $file
+ *
+ * check-error-start
+compound-sizes.c:39:17: union un static [toplevel] un: compound size 192, alignment 8
+compound-sizes.c:42:25: struct inventory static [toplevel] inven[100]: compound size 19200, alignment 8
+compound-sizes.c:51:33: struct inventory static [toplevel] [usertype] invent[10]: compound size 1920, alignment 8
+compound-sizes.c:58:25: float static [toplevel] floats[42]: compound size 168, alignment 4
+compound-sizes.c:59:25: double static [toplevel] doubles[84]: compound size 672, alignment 8
+ * check-error-end
+ */