From patchwork Thu Jul 26 10:28:26 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Christopher Li X-Patchwork-Id: 1241161 Return-Path: X-Original-To: patchwork-linux-sparse@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork1.kernel.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by patchwork1.kernel.org (Postfix) with ESMTP id F1FEF3FC5A for ; Thu, 26 Jul 2012 10:28:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751542Ab2GZK22 (ORCPT ); Thu, 26 Jul 2012 06:28:28 -0400 Received: from mail-lb0-f174.google.com ([209.85.217.174]:65333 "EHLO mail-lb0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751350Ab2GZK22 (ORCPT ); Thu, 26 Jul 2012 06:28:28 -0400 Received: by lbbgm6 with SMTP id gm6so1358191lbb.19 for ; Thu, 26 Jul 2012 03:28:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type; bh=PJe1QX8+N0iKGe1ZhUp+6oSO4tVXdb4K32ZGfEzO3Zo=; b=v2bGrKwYD9uIxrzfUB/4pbIiSUegZ2ep1J+JcctZvi/nuQsCN91tk16aIgwJrPOWfw +nYKmpjdk2GYQgohq0Uy/tEAp8FGOW4yWdq6YdHKMUQzUzv8ucHIBMxVgSNWhUYYR0cQ GTG4wdqCD+wI0DSkzdSR+POPFtNeiORc0liM2C2SBGMXIxFZj8qHdH6WPQ0/VxYBnOj5 4sHc7KOx3NOr3ltfBj+jJR0yolCvrI6PunPohGROlMYDMkrconhvFQKE2JxX2YGa4OXO sRhWX99+lSxXPh55YuAoNppIiLn/nFNOX7hQBHoRc27QtDSj9JsLeQkpwcrT0bOenzPX b5Bw== MIME-Version: 1.0 Received: by 10.112.82.197 with SMTP id k5mr13115181lby.98.1343298506254; Thu, 26 Jul 2012 03:28:26 -0700 (PDT) Received: by 10.112.10.5 with HTTP; Thu, 26 Jul 2012 03:28:26 -0700 (PDT) In-Reply-To: <20120726074554.GM4403@mwanda> References: <20120726074554.GM4403@mwanda> Date: Thu, 26 Jul 2012 03:28:26 -0700 X-Google-Sender-Auth: dGJwAFs7tL8GiWhwk5HGtpYE9pg Message-ID: Subject: Re: Adding default for m64/m32 handle From: Christopher Li To: Dan Carpenter Cc: linux-sparse@vger.kernel.org Sender: linux-sparse-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-sparse@vger.kernel.org On Thu, Jul 26, 2012 at 12:45 AM, Dan Carpenter wrote: > Hi Chris, > > The patch 7aa79f8401f0 "Adding default for m64/m32 handle" causes > a problem for variables called x86_64. > > $ echo "unsigned char x86_64;" > test.c > $ ./sparse test.c > test.c:1:15: warning: missing identifier in declaration > test.c:1:15: error: Expected ; at the end of type declaration > test.c:1:15: error: got 1 Are you suggesting we do some thing like this patch to remove the define of x86_64? Gcc does not seem to define x86_64. Any objections? Chris --- To unsubscribe from this list: send the line "unsubscribe linux-sparse" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/lib.c b/lib.c index b4d3944..bb814f2 100644 --- a/lib.c +++ b/lib.c @@ -372,8 +372,6 @@ static void handle_arch_m64_finalize(void) size_t_ctype = &ulong_ctype; ssize_t_ctype = &long_ctype; #ifdef __x86_64__ - add_pre_buffer("#weak_define x86_64 1\n"); - add_pre_buffer("#weak_define __x86_64 1\n"); add_pre_buffer("#weak_define __x86_64__ 1\n"); #endif }