From patchwork Sun Oct 29 23:31:28 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Christopher Li X-Patchwork-Id: 10031823 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 4DB8F600C5 for ; Sun, 29 Oct 2017 23:31:31 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 34C4528743 for ; Sun, 29 Oct 2017 23:31:31 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 250F02874A; Sun, 29 Oct 2017 23:31:31 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.3 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI, RCVD_IN_SORBS_SPAM, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id C887828743 for ; Sun, 29 Oct 2017 23:31:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751342AbdJ2Xb3 (ORCPT ); Sun, 29 Oct 2017 19:31:29 -0400 Received: from mail-yw0-f176.google.com ([209.85.161.176]:49078 "EHLO mail-yw0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751319AbdJ2Xb3 (ORCPT ); Sun, 29 Oct 2017 19:31:29 -0400 Received: by mail-yw0-f176.google.com with SMTP id q1so10042157ywh.5 for ; Sun, 29 Oct 2017 16:31:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=EIQQoHN7dQV6ctqDtK7QZSr6HlAzcjit9qsTHH5/fqA=; b=kQ6ZLpVzh5y6p7aZReOKaRO3KIOgiepAmL/egGplY0Dzhe7WPW3jVall3nCetCpsqB r5U2aFu05Nx6OjnhIQl6pz1uHqt2hEKlbzaPW6anoQTUHSFqPLMzXB8uesHN3JQMf4WC Sa/u72mjAhnFcfV7tHhb3VaqiN87t2KTnZeBTC5aL/v6wo6YqRdHiJ50lCzDiZzdIFGC B2jTdUdFda1TVlCR/tGyKWd19rmJKHdgC+TxAOSdi4DmR/bI389QO1wV9Q3GfGzfbY8q LrKzO3V3tpHBe+zRHdiQcvzGWNgouv4n4hbZlqFlM633zJSHCf+yJ962ZPdQPaiJFFBF sqUA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=EIQQoHN7dQV6ctqDtK7QZSr6HlAzcjit9qsTHH5/fqA=; b=W2UGzzhadGTxIUf/HfL8aYUDEZFo2McrmlcyzZsDtLeQABCBBVHL+xifsAlLG2X3xp w71IvjwB5jtXR+ljyuvPZgbCIE66kYTEOdcvzqNTCueYbBeB/WJfmoj75AK0CbFO2+xU o7beptkVjk5ml+h7GZGHWTZrfmCWF9btkTkxrjdaF7cOrMxBXe/ds4DUBqFMea1nEacm iJFfx2HitdLKIsi+i09sFLxX7dJcJgQEfPYfLAZ+dUHyvbRM+mRo2rcIMWvDnm5cAYk/ iLARResIn96DIFC/1fawdrD85UyGdXKBT/vRkOHsed0E5n9UUoUd721vUj5HIUE5xhHs 62xw== X-Gm-Message-State: AMCzsaX7KBFEvxzx2byo4KNnv+WvAhO4dh/oRyHPIhshKJaMAClh5pSN qCgJ669rUcK586pMbtPsLXhwUPktuiVdMASwOw== X-Google-Smtp-Source: ABhQp+T6AodZP1fO+Io4vUwMDZEWsqK/TX5pJUbqPxi5yZ/TY66xWtiMyJ5DH3bDcJr7xHwZb8iWcxetmNB6fchc+J8= X-Received: by 10.13.233.70 with SMTP id s67mr5032240ywe.381.1509319888670; Sun, 29 Oct 2017 16:31:28 -0700 (PDT) MIME-Version: 1.0 Received: by 10.129.103.133 with HTTP; Sun, 29 Oct 2017 16:31:28 -0700 (PDT) In-Reply-To: <20170918095135.12066-1-luc.vanoostenryck@gmail.com> References: <20170918095135.12066-1-luc.vanoostenryck@gmail.com> From: Christopher Li Date: Mon, 30 Oct 2017 07:31:28 +0800 X-Google-Sender-Auth: 77I6rEur1_94uVh1q4GZTPdKK3Y Message-ID: Subject: Re: [GIT PULL] llvm fixes To: Luc Van Oostenryck Cc: Linux-Sparse Sender: linux-sparse-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-sparse@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On Mon, Sep 18, 2017 at 5:51 PM, Luc Van Oostenryck wrote: > Chris, > > Please, pull these patches for master. Ah, I can't find the exact corresponding patch series in the email. So I will just comment from the git change. I think it is better not print out the %p for NULL. Just skip the %p if not verbose was set. BTW, I understand you are reluctant to make trivial change to very old series of branch. That make sense. In that case, I can make a topic branch to track the feedback and fix up as incremental change. Then integrate that branch when all the feedback settle down. I don't mind writing some feedback patches myself if you prefer. Thanks Chris --- To unsubscribe from this list: send the line "unsubscribe linux-sparse" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html =========quote=========== commit ae7fd3b06c225fd8faf67c3e20db07b64eca7fc3 don't output value of anonymous symbol's pointer The value of this pointer is of no use unless you're using a debugger (or just to see if two things are identical or not) and it's presence produces noise when comparing the output of two runs for testing. Change this by issuing it only if 'verbose' is set. diff --git a/linearize.c b/linearize.c index 42d1680..b69f838 100644 --- a/linearize.c +++ b/linearize.c @@ -120,7 +120,7 @@ const char *show_pseudo(pseudo_t pseudo) break; } expr = sym->initializer; - snprintf(buf, 64, "", sym); + snprintf(buf, 64, "", verbose ? sym : NULL); ======================================================= Very trivial feed back: