From patchwork Sat Feb 24 23:30:44 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Christopher Li X-Patchwork-Id: 10240635 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 851CE602B8 for ; Sat, 24 Feb 2018 23:30:47 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 64B0B29BD4 for ; Sat, 24 Feb 2018 23:30:47 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 5822229C07; Sat, 24 Feb 2018 23:30:47 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id F05B729BD4 for ; Sat, 24 Feb 2018 23:30:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751461AbeBXXaq (ORCPT ); Sat, 24 Feb 2018 18:30:46 -0500 Received: from mail-qk0-f169.google.com ([209.85.220.169]:40130 "EHLO mail-qk0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751459AbeBXXap (ORCPT ); Sat, 24 Feb 2018 18:30:45 -0500 Received: by mail-qk0-f169.google.com with SMTP id o25so9580979qkl.7 for ; Sat, 24 Feb 2018 15:30:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=IXcVd/Sf9tadmc0rUEQNaoJjJCNnfLf5OTpLPB83yEo=; b=H86JF3URsytOFap7PLJTMpI99l3HLw3SNNQ1Nvk5Odk0iahRo5JlShb26EgY03i3Zj uGzfhFlyz/EFmPZWF1g37y9kfAj6hd2LrQGjsUfBaEuqlld+EnGBSd9ol+ooYKOlwhyD qLfCR7lOq4QOOCtIk2izhXCB5CTuULp4L4zsG6ya596i5l91ADMJsRY0W2apJpDUxwQz hfTX+YQThSuADXIBAFn/2belBp0eeqDdpbUQrRb3LYNConSAv4EgZdb8ECQvS1eUJvyT Jh6wtH6toyBc5pjgtHph2R6UN6xK6NFcjzGDFnvjdgiwc7KtToA5awtv8I5Jm5ssQ4kw +lKw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=IXcVd/Sf9tadmc0rUEQNaoJjJCNnfLf5OTpLPB83yEo=; b=prUPs4SV+3Lmcjo4MTRAor3EN29pcfMm++LAugH6ClbAEf2P/kXCGew8Zop3AFAn/v VMoRK9igKA/lxIMrf7WVb0Tba1T4xa0V6gxO2IlutV2hzPQBoFvnKjXZgUKA9dfRFK8h 7nmgmGnjuC/lqoo26WFBncHcMTyZN2mZS1gLqeB0O6OldzjwHyaOPRzqHSLWVzZ+xvFH xFvwyo1TUxJLTrnzuHiWFypTjjGjFtmScPVY7A/MR1Pxk1IN7HlykPS1gEV/YXe9uWT/ 5pvbBq6Vn9IALep4nsHxLhX+1EJXr+Q1KbjTX5v47RbRKnOuQQZlQ6E+h3XyVuziBNsn z8uw== X-Gm-Message-State: APf1xPCbbxLQhVWYUnlt1qAvGD0dQB1SV1APeW+8GQve2Z1QIQS4oal2 mplCgqX36G2UJNgyeERXcG+aC1TR7odFSNfWLQ== X-Google-Smtp-Source: AG47ELvqly2aTtGFjcyEbwGeHuB738bsmWdlOCJD0vsYGDK5mEV/+KAaF7ZkyyJue+hyDfI/gxPX92AFmTjRR2p2ESw= X-Received: by 10.55.167.143 with SMTP id q137mr10186340qke.27.1519515045077; Sat, 24 Feb 2018 15:30:45 -0800 (PST) MIME-Version: 1.0 Received: by 10.140.91.52 with HTTP; Sat, 24 Feb 2018 15:30:44 -0800 (PST) In-Reply-To: <20180224220029.l5soju2azz3vsy4g@ltop.local> References: <20180224220029.l5soju2azz3vsy4g@ltop.local> From: Christopher Li Date: Sat, 24 Feb 2018 15:30:44 -0800 X-Google-Sender-Auth: 7JBrSpr29RoPaT4zqkplCyH1C8E Message-ID: Subject: Re: regressions on HEAD To: Luc Van Oostenryck Cc: Linux-Sparse , Josh Triplett Sender: linux-sparse-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-sparse@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On Sat, Feb 24, 2018 at 2:00 PM, Luc Van Oostenryck wrote: > Hi Chris, > > I saw that a few patches have been pushed on the head, > including the two I disagreed with and which I explained *why* > they where wrong. Well. > > Meanwhile, I see some regressions with the current head. > For example some simple programs like: > void a(void) > { > int b[] = { 8 }; > int c; > for (;;) > b[c] = b[0]; > } > now crashes when used with test-linearize. Oops, reproduced. Thanks for the report. I see pseudo->ident polluted by pseudo->size. Separate them out of the union seems to fix the crash. Taking a look now. If it is hard to fix I will apply the revert. > I also see regressions in the generated IR, of course, > like I explained in November. More detail of the regression? Chris --- To unsubscribe from this list: send the line "unsubscribe linux-sparse" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/linearize.h b/linearize.h index fd8e00d3..7841ba23 100644 --- a/linearize.h +++ b/linearize.h @@ -31,11 +31,9 @@ enum pseudo_type { struct pseudo { int nr; enum pseudo_type type; + int size; /* OP_SETVAL only */ struct pseudo_user_list *users; - union { - struct ident *ident; - int size; /* OP_SETVAL only */ - }; + struct ident *ident; union { struct symbol *sym; struct instruction *def;