| Message ID | 20190325142439.22032-1-tstoyanov@vmware.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | trace-cmd: Timetamps sync between host and guest machines, relying on vsock events. | expand |
I'm having issues building this. Does it depend on some other series
that haven't made it to master yet?
Also the warnings need to be fixed too.
trace-input.c: In function ‘timestamp_correct’:
trace-input.c:1094:9: warning: implicit declaration of function ‘n’ [-
Wimplicit-function-declaration]
return n(ts, &handle->ts_samples[mid],
^
trace-output.c: In function ‘tracecmd_add_option’:
trace-output.c:963:16: warning: assignment discards ‘const’ qualifier
from pointer target type [-Wdiscarded-qualifiers]
vect.iov_base = data;
^
trace-timesync.c: In function ‘get_events_in_page’:
trace-timesync.c:184:11: warning: implicit declaration of function
‘tep_data_event_from_type’; did you mean ‘tep_data_pid_from_comm’? [-
Wimplicit-function-declaration]
event = tep_data_event_from_type(tep, id);
^~~~~~~~~~~~~~~~~~~~~~~~
tep_data_pid_from_comm
trace-timesync.c:184:9: warning: assignment to ‘struct tep_event *’
from ‘int’ makes pointer from integer without a cast [-Wint-conversion]
event = tep_data_event_from_type(tep, id);
^
/usr/bin/ld: /home/kaslevs/src/tc-gh/tracecmd/trace-timesync.o: in
function `get_events_in_page':
/home/kaslevs/src/tc-gh/tracecmd/trace-timesync.c:184: undefined
reference to `tep_data_event_from_type'
/usr/bin/ld: /home/kaslevs/src/tc-gh/lib/trace-cmd/libtracecmd.a(trace-
input.o): in function `timestamp_correct':
/home/kaslevs/src/tc-gh/lib/trace-cmd/trace-input.c:1094: undefined
reference to `n'
collect2: error: ld returned 1 exit status
make[1]: *** [Makefile:66: /home/kaslevs/src/tc-gh/tracecmd/trace-cmd]
Error 1
Cheers,
-- Slavi
[ v9 changes: - Fixed implementation of binary search algorithm in timestamp_correct() v8 changes: - Added rmdir() call in tracecmd_remove_instance(), to completely remove the instance. However, there is an issue with deleting the instances using rmdir(), which is investigated. - Few changes in read_qemu_guests_pids(), timestamp_correct(), tsync_offset_load() tracecmd_clock_context_new() and find_raw_events() suggested by Slavomir. v7 changes: - Added warning messages in case time synchronization cannot be negotiated or fails. - Few optimizations and checks in read_qemu_guests_pids(), tsync_offset_load(), and find_raw_events(), suggested by Slavomir Kaslev. - Reworked timestamp_correct() to not use static variables. - Check TRACECMD_OPTION_TIME_SHIFT before reading time sync samples from the trace.dat file v6 changes: - Refactored tracecmd_msg_snd_time_sync() and tracecmd_msg_rcv_time_sync() functions: removed any time sync calculations logic as separate functions in trace-timesync.c file - Defined TSYNC_PROBE, TSYNC_REQ and TSYNC_RESP messages, in order to make the time sync protocol comprehensible. - Addressed Steven Rostedt comments. - Addressed Slavomir Kaslev commnets. v5 changes: - Rebased to Slavomir's v8 "Add VM kernel tracing over vsockets and FIFOs" patch series. - Implemented an algorithm for time drift correction. - Addressed Slavomir's commnets. - Refactored the code: moved all time sync specific implementation in trace-timesync.c - Isolated all hardcoded event specific stuff in a structure, so it could be easily moved to external plugins. - Added a check for VSOCK support: do not perform vsock dependent time synchronisation in case there is no VSOCK support. v4 changes: - Removed the implementation of PTP-like algorithm. The current logic relies on matching time stamps of kvm_exit/virtio_transport_recv_pkt events on host to virtio_transport_alloc_pkt/vp_notify events on guest. - Rebased to Slavomir's v7 "Add VM kernel tracing over vsockets and FIFOs" patch series. - Decreased the time synch probes from 5000 to 300. - Addressed Steven Rostedt comments. - Code cleanup. v3 changes: - Removed any magic constants, used in the PTP-like algorithm, as Slavomir Kaslev suggested. - Implemented new algorithm, based on mapping kvm_exit events in host context to vsock_send events in guest context, suggested by Steven Rostedt. v2 changes: - Addressed Steven Rostedt comments. - Modified PTP-like timestamps sync algorithm to gain more accuracy, with the help of Yordan Karadzhov and Slavomir Kaslev. ] This patch series is a POC for timestamps sync between guest and host machines. The algorithm relies on matching time stamps of guest and host vsock events. The patch series depends on Slavomir's changes, introduced by the v8 patch series "Add VM kernel tracing over vsockets and FIFOs" Tzvetomir Stoyanov (9): trace-cmd: Implemented new lib API: tracecmd_local_events_system() trace-cmd: Added support for negative time offsets in trace.dat file trace-cmd: Fix tracecmd_read_page_record() to read more than one event trace-cmd: Added implementation of htonll() and ntohll() trace-cmd: Refactored few functions in trace-record.c trace-cmd: Find and store pids of tasks, which run virtual CPUs of given VM trace-cmd: Implemented new API tracecmd_add_option_v() trace-cmd: Implemented new option in trace.dat file: TRACECMD_OPTION_TIME_SHIFT trace-cmd [POC]: Implemented timestamps synch algorithm, using vsock events. include/trace-cmd/trace-cmd.h | 31 +- include/traceevent/event-parse.h | 1 + lib/trace-cmd/trace-input.c | 144 +++++- lib/trace-cmd/trace-util.c | 95 ++-- tracecmd/Makefile | 1 + tracecmd/include/trace-local.h | 43 +- tracecmd/include/trace-msg.h | 10 + tracecmd/trace-agent.c | 13 +- tracecmd/trace-msg.c | 208 +++++++- tracecmd/trace-output.c | 117 ++++- tracecmd/trace-read.c | 4 +- tracecmd/trace-record.c | 230 +++++++-- tracecmd/trace-timesync.c | 805 +++++++++++++++++++++++++++++++ 13 files changed, 1569 insertions(+), 133 deletions(-) create mode 100644 tracecmd/trace-timesync.c