mbox series

[0/5] Modifications needed for KS 1.0

Message ID 20190423132741.17864-1-ykaradzhov@vmware.com (mailing list archive)
Headers show
Series Modifications needed for KS 1.0 | expand

Message

Yordan Karadzhov April 23, 2019, 1:27 p.m. UTC 
The patch-set contains reimplementation (almost from scratch) of patches
that have been sent already. The aims is to optimize the workflow of the
user when running the application from its build (source code) location
or installation location.

Yordan Karadzhov (5):
  kernel-shark: Add INSTALL PREFIX to the Cmake-generated header file.
  kernel-shark: Add logic for the initial path of Open-File dialogs
  kernel-shark: Add logic for the plugins search path
  kernel-shark: Remove the definition of KS_DIR
  kernel-shark: Remember the paths used by the Open-File dialogs.

 kernel-shark/build/deff.h.cmake         |   4 +-
 kernel-shark/src/KsCaptureDialog.cpp    |  34 ++---
 kernel-shark/src/KsCaptureDialog.hpp    |   2 +
 kernel-shark/src/KsMainWindow.cpp       |  81 ++++++------
 kernel-shark/src/KsMainWindow.hpp       |   6 +-
 kernel-shark/src/KsUtils.cpp            | 161 ++++++++++++++++++++++--
 kernel-shark/src/KsUtils.hpp            |  19 +++
 kernel-shark/src/plugins/CMakeLists.txt |   2 +-
 8 files changed, 229 insertions(+), 80 deletions(-)

Comments

Slavomir Kaslev May 2, 2019, 8:42 a.m. UTC | #1 
On Tue, Apr 23, 2019 at 4:28 PM Yordan Karadzhov <ykaradzhov@vmware.com> wrote:
>
> The patch-set contains reimplementation (almost from scratch) of patches
> that have been sent already. The aims is to optimize the workflow of the
> user when running the application from its build (source code) location
> or installation location.
>
> Yordan Karadzhov (5):
>   kernel-shark: Add INSTALL PREFIX to the Cmake-generated header file.
>   kernel-shark: Add logic for the initial path of Open-File dialogs
>   kernel-shark: Add logic for the plugins search path
>   kernel-shark: Remove the definition of KS_DIR
>   kernel-shark: Remember the paths used by the Open-File dialogs.
>
>  kernel-shark/build/deff.h.cmake         |   4 +-
>  kernel-shark/src/KsCaptureDialog.cpp    |  34 ++---
>  kernel-shark/src/KsCaptureDialog.hpp    |   2 +
>  kernel-shark/src/KsMainWindow.cpp       |  81 ++++++------
>  kernel-shark/src/KsMainWindow.hpp       |   6 +-
>  kernel-shark/src/KsUtils.cpp            | 161 ++++++++++++++++++++++--
>  kernel-shark/src/KsUtils.hpp            |  19 +++
>  kernel-shark/src/plugins/CMakeLists.txt |   2 +-
>  8 files changed, 229 insertions(+), 80 deletions(-)

Looks good to me.

Reviewed-by: Slavomir Kaslev <kaslevs@vmware.com>

Cheers,

-- Slavi