[v7,0/4] libtraceevent: Optimize the print of tep fields

Message

Yordan Karadzhov Aug. 23, 2021, 9:56 a.m. UTC

Provide new capabilities for printing the content of the individual
fields of the event.

Changes in v7:
 - Proper naming (without 'tep' prefix) of the static methods defined
 in the patches.
 - Fixing the 'for' loop in print_selected_fields()
 - 'tep_print_selected_fields()' was renamed to 
 'tep_record_print_selected_fields()'. 'tep_record_print_fields()' was
 added.
 - Adding documentation for the new APIs.

Changes in v6:
 - Cleanup in [PATCH 1/5].
 - Protection against infinite loop in _tep_print_field()
 ([PATCH 4/5]).

Changes in v5:
 - The loop over the tokens in _tep_print_field() is made circular
 in order to support the corner case when the fields and the tokens
 are listed in different order.
 - _tep_print_field() and print_selected_fields() are made "inline"
 in order to help the compiler to optimize out the unused variables
 (suggested by Steven).

Changes in v4:
 - Directly applying the modification in tep_print_field() suggested
 by Steven.
 - Optimizing the loop over the tokens in tep_print_fields().
 

Yordan Karadzhov (VMware) (4):
  libtraceevent: Improve tep_print_field()
  libtraceevent: Optimize tep_print_fields()
  libtraceevent: Add APIs for printing the fields of a record
  libtraceevent: Add documentation for the new printing APIs

 Documentation/libtraceevent-field_print.txt |  11 +-
 Documentation/libtraceevent.txt             |   2 +
 src/event-parse.c                           | 184 ++++++++++++++++----
 src/event-parse.h                           |   7 +
 4 files changed, 170 insertions(+), 34 deletions(-)

Comments

Steven Rostedt Sept. 8, 2021, 8:06 p.m. UTC | #1

On Mon, 23 Aug 2021 12:56:14 +0300
"Yordan Karadzhov (VMware)" <[e-mail]> wrote:


> Yordan Karadzhov (VMware) (4):
>   libtraceevent: Improve tep_print_field()
>   libtraceevent: Optimize tep_print_fields()

I accepted the first two patches. I had a comment for the one below.

-- Steve

>   libtraceevent: Add APIs for printing the fields of a record
>   libtraceevent: Add documentation for the new printing APIs
> 
>  Documentation/libtraceevent-field_print.txt |  11 +-
>  Documentation/libtraceevent.txt             |   2 +
>  src/event-parse.c                           | 184 ++++++++++++++++----
>  src/event-parse.h                           |   7 +
>  4 files changed, 170 insertions(+), 34 deletions(-)
>