| Message ID | 20230208091204.7443-1-dwagner@suse.de (mailing list archive) |
|---|---|
| Headers | show |
| Series | Add initial support for meson | expand |
On Wed, Feb 08, 2023 at 10:12:02AM +0100, Daniel Wagner wrote: > The libtracecmd.pc didn't list the subdir 'trace-cmd' which caused > our kernelshard builds to fail. FWIW, I've updated the Tumbleweed packages (libtraceevent, libtracefs, libtracecmd, trace-cmd) to build with Meson and everything looks good now. As indicated there was only small fallout in our kernelshark build but that is now fixed with this latest version of these patches here. So all v7 of the patches are also properly tested in a productive environment. All these changes don't touch the existing Makefiles, so there is zero chance that existing build setups break with adding the Meson build files. Obviously, there will be additional work to keep both builds working, though I don't expect it should be much after this initial work to get it going. Steven, any chance you are going to apply them any time soon?
On Thu, 9 Feb 2023 10:38:05 +0100 Daniel Wagner <dwagner@suse.de> wrote: > On Wed, Feb 08, 2023 at 10:12:02AM +0100, Daniel Wagner wrote: > > The libtracecmd.pc didn't list the subdir 'trace-cmd' which caused > > our kernelshard builds to fail. > > FWIW, I've updated the Tumbleweed packages (libtraceevent, libtracefs, > libtracecmd, trace-cmd) to build with Meson and everything looks good now. As > indicated there was only small fallout in our kernelshark build but that is now > fixed with this latest version of these patches here. So all v7 of the patches > are also properly tested in a productive environment. > > All these changes don't touch the existing Makefiles, so there is zero chance > that existing build setups break with adding the Meson build files. Obviously, > there will be additional work to keep both builds working, though I don't expect > it should be much after this initial work to get it going. > > Steven, any chance you are going to apply them any time soon? I'll take a look. Sorry I didn't get to it on my trip (other things came up). Also, I'm still recovering from the flu now :-p -- Steve
On Fri, Feb 10, 2023 at 04:47:44PM -0500, Steven Rostedt wrote: > I'll take a look. Sorry I didn't get to it on my trip (other things came > up). Also, I'm still recovering from the flu now :-p Thanks! No hurry, I don't have a problem if takes some more time if it moves forward eventually :)
The libtracecmd.pc didn't list the subdir 'trace-cmd' which caused our kernelshard builds to fail. Changes: v7: - lib: list trace-cmd subdir in pkg-config file. Revert previous attempt to fix it. v6: - lib: isntall trace-cmd.h directly in /usr/include and not subdir trace-cmd. kernelshark builds breaks otherwise v5: - lib: set default html doc path to share/doc/libtracemd-doc - lib: list libtraceevent and libtracefs in Required pkg-config section. - lib: install (any) man5 pages (keep it in sync with other projects) - trace-cmd: install (any) man5 pages (keep it in sync with other projects) - trace-cmd: set default html doch patch to share/doc/trace-cmd-doc v4: - changed project defaults to --default-library=both - code style consistency updates - hardening doc install script (shellcheck) - renamed install-man.sh.in to install-docs.sh.in - install-docs.sh.in installs html pages too - introduces docs target - updated copyright year - streamlined documentation meson build file v3: - generate tc_version.h file - lib: cleaning up the standalone build vs trace-cmd build - s/conf10.set/conf.set10/ - default build target is debug - do not install man pages into subdirs v2: - make audit dependency optional as default - integrate static libtracecmd build into trace-cmd directly - remove check-manpages target in trace-cmd v1: - initial version Daniel Wagner (2): libtracecmd: Add initial support for meson trace-cmd: Add initial support for meson Documentation/libtracecmd/install-docs.sh.in | 20 ++ Documentation/libtracecmd/meson.build | 168 +++++++++++++++++ Documentation/trace-cmd/install-docs.sh.in | 20 ++ Documentation/trace-cmd/meson.build | 187 +++++++++++++++++++ lib/Documentation | 1 + lib/check-manpages.sh | 1 + lib/meson.build | 114 +++++++++++ lib/meson_options.txt | 19 ++ lib/trace-cmd/include/meson.build | 5 + lib/trace-cmd/include/private/meson.build | 14 ++ lib/trace-cmd/meson.build | 88 +++++++++ meson-vcs-tag.sh | 17 ++ meson.build | 149 +++++++++++++++ meson_options.txt | 23 +++ python/meson.build | 40 ++++ tracecmd/meson.build | 59 ++++++ utest/meson.build | 26 +++ 17 files changed, 951 insertions(+) create mode 100755 Documentation/libtracecmd/install-docs.sh.in create mode 100644 Documentation/libtracecmd/meson.build create mode 100755 Documentation/trace-cmd/install-docs.sh.in create mode 100644 Documentation/trace-cmd/meson.build create mode 120000 lib/Documentation create mode 120000 lib/check-manpages.sh create mode 100644 lib/meson.build create mode 100644 lib/meson_options.txt create mode 100644 lib/trace-cmd/include/meson.build create mode 100644 lib/trace-cmd/include/private/meson.build create mode 100644 lib/trace-cmd/meson.build create mode 100755 meson-vcs-tag.sh create mode 100644 meson.build create mode 100644 meson_options.txt create mode 100644 python/meson.build create mode 100644 tracecmd/meson.build create mode 100644 utest/meson.build