From patchwork Thu Dec 21 15:25:20 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Vladislav Valtchev (VMware)" X-Patchwork-Id: 10758363 Return-Path: linux-trace-devel-owner@vger.kernel.org Received: from mail-wr0-f194.google.com ([209.85.128.194]:44428 "EHLO mail-wr0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751239AbdLUPZw (ORCPT ); Thu, 21 Dec 2017 10:25:52 -0500 From: "Vladislav Valtchev (VMware)" To: rostedt@goodmis.org Cc: y.karadz@gmail.com, linux-trace-devel@vger.kernel.org, linux-kernel@vger.kernel.org, "Vladislav Valtchev (VMware)" Subject: [PATCH v2 3/3] trace-cmd: Making stat to report when the stack tracer is ON Date: Thu, 21 Dec 2017 17:25:20 +0200 Message-Id: <20171221152520.25867-4-vladislav.valtchev@gmail.com> In-Reply-To: <20171221152520.25867-1-vladislav.valtchev@gmail.com> References: <20171221152520.25867-1-vladislav.valtchev@gmail.com> Sender: linux-trace-devel-owner@vger.kernel.org List-ID: Content-Length: 1981 trace-cmd stat is a handy way for users to see what tracing is currently going on, but currently it does not say anything about the stack tracing. This patch makes the command to show a message when the stack tracer is ON. Signed-off-by: Vladislav Valtchev (VMware) --- trace-cmd.h | 2 ++ trace-stack.c | 6 ++++++ trace-stat.c | 8 ++++++++ 3 files changed, 16 insertions(+) diff --git a/trace-cmd.h b/trace-cmd.h index 6fd34d7..9704b2e 100644 --- a/trace-cmd.h +++ b/trace-cmd.h @@ -358,6 +358,8 @@ void tracecmd_free_hooks(struct hook_list *hooks); /* --- Hack! --- */ int tracecmd_blk_hack(struct tracecmd_input *handle); +/* --- Stack tracer functions --- */ +int tracecmd_stack_tracer_status(int *status); /* --- Debugging --- */ struct kbuffer *tracecmd_record_kbuf(struct tracecmd_input *handle, diff --git a/trace-stack.c b/trace-stack.c index d55d994..0028ecc 100644 --- a/trace-stack.c +++ b/trace-stack.c @@ -107,6 +107,12 @@ static int read_proc(int *status) return 1; /* full success */ } +/* Public wrapper of read_proc() */ +int tracecmd_stack_tracer_status(int *status) +{ + return read_proc(status); +} + /* NOTE: this implementation only accepts new_status in the range [0..9]. */ static void change_stack_tracer_status(int new_status) { diff --git a/trace-stat.c b/trace-stat.c index fd16354..61dd41f 100644 --- a/trace-stat.c +++ b/trace-stat.c @@ -894,6 +894,7 @@ void trace_stat (int argc, char **argv) struct buffer_instance *instance = &top_instance; int topt = 0; int c; + int stack_tracer_status; for (;;) { c = getopt(argc-1, argv+1, "tB:"); @@ -928,5 +929,12 @@ void trace_stat (int argc, char **argv) stat_instance(instance); } + if (tracecmd_stack_tracer_status(&stack_tracer_status) >= 0) { + if (stack_tracer_status > 0) + printf("Stack tracing is enabled\n\n"); + } else { + printf("The status of the stack tracer is indeterminate\n\n"); + } + exit(0); }