diff mbox series

[v2,1/2] kernel-shark-qt: Add "DEBUG" build mode.

Message ID 20180918170832.7865-1-y.karadz@gmail.com (mailing list archive)
State Accepted
Headers show
Series [v2,1/2] kernel-shark-qt: Add "DEBUG" build mode. | expand

Commit Message

Yordan Karadzhov Sept. 18, 2018, 5:08 p.m. UTC 
"-g" compiler option is added to both C and C++ compiler flags, allowing
debug information to be generated. If the DEBUG Command-Line option is not
provided or is set to zero, the "-O2" compiler flag is added as well.

Signed-off-by: Yordan Karadzhov (VMware) <y.karadz@gmail.com>
---
 kernel-shark-qt/CMakeLists.txt | 11 +++++++++--
 kernel-shark-qt/README         | 15 +++++++++------
 2 files changed, 18 insertions(+), 8 deletions(-)

Comments

Steven Rostedt Sept. 18, 2018, 5:17 p.m. UTC | #1 
On Tue, 18 Sep 2018 20:08:31 +0300
"Yordan Karadzhov (VMware)" <y.karadz@gmail.com> wrote:

> "-g" compiler option is added to both C and C++ compiler flags, allowing
> debug information to be generated. If the DEBUG Command-Line option is not
> provided or is set to zero, the "-O2" compiler flag is added as well.
> 
> Signed-off-by: Yordan Karadzhov (VMware) <y.karadz@gmail.com>

Looks good, I accepted both patches.

Thanks Yordan!

-- Steve
diff mbox series

Patch

diff --git a/kernel-shark-qt/CMakeLists.txt b/kernel-shark-qt/CMakeLists.txt
index 0187eb4..4a40b11 100644
--- a/kernel-shark-qt/CMakeLists.txt
+++ b/kernel-shark-qt/CMakeLists.txt
@@ -23,8 +23,15 @@  find_package(GLUT)
 set(LIBRARY_OUTPUT_PATH    "${KS_DIR}/lib")
 set(EXECUTABLE_OUTPUT_PATH "${KS_DIR}/bin")
 
-set(CMAKE_C_FLAGS   "${CMAKE_C_FLAGS} -Wall -pthread")
-set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wall -std=c++11 -pthread")
+set(CMAKE_C_FLAGS   "${CMAKE_C_FLAGS} -Wall -g -pthread")
+set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wall -g -std=c++11 -pthread")
+
+if (NOT _DEBUG)
+
+	set(CMAKE_C_FLAGS   "${CMAKE_C_FLAGS} -O2")
+	set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -O2")
+
+endif (NOT _DEBUG)
 
 include_directories(${KS_DIR}/src/
                     ${KS_DIR}/build/src/
diff --git a/kernel-shark-qt/README b/kernel-shark-qt/README
index f03288c..84708bd 100644
--- a/kernel-shark-qt/README
+++ b/kernel-shark-qt/README
@@ -31,16 +31,19 @@  the original trace-cmd end traceevent libraries.
     cmake ../
     make
 
-2.1 In order to create a Doxygen documentation add -D_DOXYGEN_DOC=1
+2.1.1 In order to create a Doxygen documentation add -D_DOXYGEN_DOC=1
 as a CMake Command-Line option.
-    cd kernel-shark-qt/build
-    cmake -D_DOXYGEN_DOC=1 ../
-    make
 
-2.2.1 Use "make clean" if you want to delete all already compiled object.
+2.1.2 In order to generates complete debug information to be used by GDB add
+-D_DEBUG=1 as a CMake Command-Line option.
+
+Example:
+    cmake -D_DOXYGEN_DOC=1 -D_DEBUG=1 ../
+
+2.2.1 Use "make clean" if you want to delete all already compiled objects.
 
 2.2.2 Use the script "cmake_clean.sh" if you want to delete all already
-compiled object and all files generated by CMake.
+compiled objects and all files generated by CMake.
 
 3. After building the code "kernel-shark-qt/lib" will contain all libraries
 and "kernel-shark-qt/bin" will contain all executables.