From patchwork Mon Dec 10 18:45:22 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Steven Rostedt X-Patchwork-Id: 10760141 Return-Path: Received: from mail.kernel.org ([198.145.29.99]:52874 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727395AbeLJSpZ (ORCPT ); Mon, 10 Dec 2018 13:45:25 -0500 Date: Mon, 10 Dec 2018 13:45:22 -0500 From: Steven Rostedt To: LKML , Linux Trace Devel Cc: Arnaldo Carvalho de Melo , Jiri Olsa , Ingo Molnar , Namhyung Kim Subject: [PATCH] tools/lib/traceevent: Fix processing of dereferenced args in bprintk events Message-ID: <20181210134522.3f71e2ca@gandalf.local.home> MIME-Version: 1.0 Sender: linux-trace-devel-owner@vger.kernel.org List-ID: Content-Length: 1045 From: "Steven Rostedt (VMware)" In the case that a bprintk event has a dereferenced pointer that is stored as a string, and there's more values to process (more args), the arg was not updated to point to the next arg after processing the dereferenced pointer, and it screwed up what was to be displayed. Cc: stable@vger.kernel.org Fixes: 7db96bb49629 ("tools lib traceevent: Handle new pointer processing of bprint strings") Signed-off-by: Steven Rostedt (VMware) --- tools/lib/traceevent/event-parse.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tools/lib/traceevent/event-parse.c b/tools/lib/traceevent/event-parse.c index 3692f29fee46..70144b98141c 100644 --- a/tools/lib/traceevent/event-parse.c +++ b/tools/lib/traceevent/event-parse.c @@ -4970,6 +4970,7 @@ static void pretty_print(struct trace_seq *s, void *data, int size, struct tep_e if (arg->type == TEP_PRINT_BSTRING) { trace_seq_puts(s, arg->string.string); + arg = arg->next; break; }