| Message ID | 20190214140723.27804-3-kaslevs@vmware.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 23e1e7c168298f1724e01e41fd712a518c2207cd |
| Headers | show |
| Series | [1/3] trace-cmd: Fix tracecmd_recorder leaking file descriptors | expand |
On Thu, 14 Feb 2019 16:07:23 +0200 Slavomir Kaslev <kaslevs@vmware.com> wrote: > This patch removes several unused #include directives. > > No changes in behaviour intended. > > Signed-off-by: Slavomir Kaslev <kaslevs@vmware.com> > --- > lib/trace-cmd/trace-input.c | 9 --------- > lib/trace-cmd/trace-recorder.c | 9 +-------- > 2 files changed, 1 insertion(+), 17 deletions(-) > > diff --git a/lib/trace-cmd/trace-input.c b/lib/trace-cmd/trace-input.c > index b628570..34a8301 100644 > --- a/lib/trace-cmd/trace-input.c > +++ b/lib/trace-cmd/trace-input.c > @@ -4,22 +4,13 @@ > * > */ > #define _LARGEFILE64_SOURCE > -#include <dirent.h> > #include <stdbool.h> > #include <stdio.h> > #include <stdlib.h> > -#include <string.h> > -#include <getopt.h> > -#include <stdarg.h> > -#include <sys/types.h> > -#include <sys/stat.h> > -#include <sys/wait.h> > #include <sys/mman.h> > -#include <pthread.h> > #include <regex.h> > #include <fcntl.h> > #include <unistd.h> > -#include <ctype.h> > #include <errno.h> > > #include <linux/time64.h> > diff --git a/lib/trace-cmd/trace-recorder.c b/lib/trace-cmd/trace-recorder.c > index 1b6a995..0b8d98a 100644 > --- a/lib/trace-cmd/trace-recorder.c > +++ b/lib/trace-cmd/trace-recorder.c > @@ -4,18 +4,11 @@ > * > */ > #define _LARGEFILE64_SOURCE > -#include <dirent.h> > #include <stdio.h> > #include <stdlib.h> > -#include <string.h> > -#include <stdarg.h> > -#include <sys/types.h> > -#include <sys/stat.h> > -#include <sys/wait.h> > -#include <pthread.h> > #include <fcntl.h> > +#include <time.h> > #include <unistd.h> > -#include <ctype.h> > #include <errno.h> > > #include "trace-cmd.h" Nice cleanup. Just an FYI, even on random patches, it's still good to have a cover email for more than one patch series "[PATCH 0/3]", as it organizes it better in inboxes. BTW, I applied all of these. Thanks Slavomir! -- Steve
diff --git a/lib/trace-cmd/trace-input.c b/lib/trace-cmd/trace-input.c index b628570..34a8301 100644 --- a/lib/trace-cmd/trace-input.c +++ b/lib/trace-cmd/trace-input.c @@ -4,22 +4,13 @@ * */ #define _LARGEFILE64_SOURCE -#include <dirent.h> #include <stdbool.h> #include <stdio.h> #include <stdlib.h> -#include <string.h> -#include <getopt.h> -#include <stdarg.h> -#include <sys/types.h> -#include <sys/stat.h> -#include <sys/wait.h> #include <sys/mman.h> -#include <pthread.h> #include <regex.h> #include <fcntl.h> #include <unistd.h> -#include <ctype.h> #include <errno.h> #include <linux/time64.h> diff --git a/lib/trace-cmd/trace-recorder.c b/lib/trace-cmd/trace-recorder.c index 1b6a995..0b8d98a 100644 --- a/lib/trace-cmd/trace-recorder.c +++ b/lib/trace-cmd/trace-recorder.c @@ -4,18 +4,11 @@ * */ #define _LARGEFILE64_SOURCE -#include <dirent.h> #include <stdio.h> #include <stdlib.h> -#include <string.h> -#include <stdarg.h> -#include <sys/types.h> -#include <sys/stat.h> -#include <sys/wait.h> -#include <pthread.h> #include <fcntl.h> +#include <time.h> #include <unistd.h> -#include <ctype.h> #include <errno.h> #include "trace-cmd.h"
This patch removes several unused #include directives. No changes in behaviour intended. Signed-off-by: Slavomir Kaslev <kaslevs@vmware.com> --- lib/trace-cmd/trace-input.c | 9 --------- lib/trace-cmd/trace-recorder.c | 9 +-------- 2 files changed, 1 insertion(+), 17 deletions(-)