From patchwork Thu Mar 14 15:10:05 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yordan Karadzhov X-Patchwork-Id: 10853075 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 00F796C2 for ; Thu, 14 Mar 2019 15:10:41 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id E03BD2A34B for ; Thu, 14 Mar 2019 15:10:40 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id DE8862A3E6; Thu, 14 Mar 2019 15:10:40 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 8BFC72A30B for ; Thu, 14 Mar 2019 15:10:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726501AbfCNPKk (ORCPT ); Thu, 14 Mar 2019 11:10:40 -0400 Received: from mail-pg1-f194.google.com ([209.85.215.194]:44184 "EHLO mail-pg1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726360AbfCNPKk (ORCPT ); Thu, 14 Mar 2019 11:10:40 -0400 Received: by mail-pg1-f194.google.com with SMTP id h34so4161569pgh.11 for ; Thu, 14 Mar 2019 08:10:39 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=wJcoGckOFj9oO8wuQMOOcPmhEAHLrH/VEmKbEF+MBVs=; b=b2HhKG6E3kq78oAUqoM3eaVSYgssYZTHX/QnYK0k1fUrLRmIvOTGKeDZpn3qw7SACz BqWeys7LHzOik+eSPS21fW5+mMAfMc/DtpoFz7ACYAik/8hii0mdQ18CKzNAPhC8RSWa d+2pwJrctEuvC3BENs2tgPHJ8Q3iWcp+8bL9BcQl50efB9RIISODgZr+c1gh4UxDE0Rc O8v93M7sI2k83Jy3SnynyQqneeFVraOYiEmHjsW+i93pLKLW3Iod9BTunj7nKRNmMOD7 Rijuvf+F5o7avutvspHR/D/JZbRSiBldSbf1KW3xZoEAXMb6h2nM0Pt+4qljBL8I3ous 96+w== X-Gm-Message-State: APjAAAVD87GEKGOnnUbCPbb6iQnm+hqK7x29nkEqKQk1P6dEWP9GU7pL NXmApfdQWLKc9p72OGeEwDEEKyEu X-Google-Smtp-Source: APXvYqxol9kmjrGdbtL+B/qTjeJvxsB7AhmHRXFdrjbhDXWT0jt7OFECjvmjucWUsUWk5KkLc43ZEg== X-Received: by 2002:a63:e101:: with SMTP id z1mr46046421pgh.190.1552576239506; Thu, 14 Mar 2019 08:10:39 -0700 (PDT) Received: from mamba.eng.vmware.com ([146.247.46.5]) by smtp.gmail.com with ESMTPSA id f65sm8165585pfg.98.2019.03.14.08.10.37 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 14 Mar 2019 08:10:38 -0700 (PDT) From: Yordan Karadzhov To: rostedt@goodmis.org Cc: linux-trace-devel@vger.kernel.org Subject: [PATCH 05/12] kernel-shark: Disables automatic quotation for errors in KsMainWindow Date: Thu, 14 Mar 2019 17:10:05 +0200 Message-Id: <20190314151012.905-6-ykaradzhov@vmware.com> X-Mailer: git-send-email 2.19.1 In-Reply-To: <20190314151012.905-1-ykaradzhov@vmware.com> References: <20190314151012.905-1-ykaradzhov@vmware.com> MIME-Version: 1.0 Sender: linux-trace-devel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-trace-devel@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP When quoting in the output stream is disabled, the text of the message is printed without quotations and without escaping of non-printable characters. example output with quoting enabled: ERROR: "Unable to open trace data file for session mysession.json\n" and with quoting disabled: ERROR: Unable to open session description file mysession.json. Signed-off-by: Yordan Karadzhov --- kernel-shark/src/KsMainWindow.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel-shark/src/KsMainWindow.cpp b/kernel-shark/src/KsMainWindow.cpp index 44221f6..9bcf9e2 100644 --- a/kernel-shark/src/KsMainWindow.cpp +++ b/kernel-shark/src/KsMainWindow.cpp @@ -980,7 +980,7 @@ void KsMainWindow::_error(const QString &text, const QString &errCode, if (unloadPlugins) _plugins.unloadAll(); - qCritical() << "ERROR: " << text; + qCritical().noquote() << "ERROR: " << text; em->showMessage(text, errCode); em->exec(); }