From patchwork Mon Apr 15 16:47:39 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Slavomir Kaslev X-Patchwork-Id: 10901237 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 9A3E61800 for ; Mon, 15 Apr 2019 16:47:51 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 7FE5F2890C for ; Mon, 15 Apr 2019 16:47:51 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 743D628929; Mon, 15 Apr 2019 16:47:51 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 16BCF2890C for ; Mon, 15 Apr 2019 16:47:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727143AbfDOQru (ORCPT ); Mon, 15 Apr 2019 12:47:50 -0400 Received: from mail-wr1-f67.google.com ([209.85.221.67]:45794 "EHLO mail-wr1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727164AbfDOQru (ORCPT ); Mon, 15 Apr 2019 12:47:50 -0400 Received: by mail-wr1-f67.google.com with SMTP id s15so22824098wra.12 for ; Mon, 15 Apr 2019 09:47:49 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=9AHh+BHdlpA7+fjnfpP674fzbLB/dMy/uY5gldnutBc=; b=c6502Mm8+peL1fmZmE899Mc7LrwmQz1Ckwa+bcAY1jSJIDDfJg7AnD0xLcSPHPujSo QQfrmUi/Oyt778/B6LJGvvfBTve1aFSOLqfkZwHXwvaUHgoVTVuclwYMjZaw0ZXuqBaX To9tOASSuRNh0TjLxxUsrRctC9Eeqst24lxh2wUbFLPvmJWWr37047q1VE1H9vHvGf7i /6AGnMzC+w7M2DQboPBJ9Xxr2RcG9uCZTapGOyzCfOItzOddkq3AF/1tRWcTJg/ljira J+P+k1Qm0oUGPkattBnmdi8GnGs5hJ2QwJ+P33pPkATo106BN5jRFIE+M80nyyG5Iy+T bSEw== X-Gm-Message-State: APjAAAWdnbIU24DsIiyUSuG06maU2btnLryiY+1Gyk1AWjTWBHHPOapE 2FnKWozLc9dMpHM6TXIEcg== X-Google-Smtp-Source: APXvYqzkzshvbbkOs3M0qVJL24qga0knI7RPVYlC131grH9nEMaQLQaufqKqkxC20mkC0hghUG5wYw== X-Received: by 2002:adf:fd46:: with SMTP id h6mr50000500wrs.139.1555346868890; Mon, 15 Apr 2019 09:47:48 -0700 (PDT) Received: from localhost.localdomain ([151.251.250.145]) by smtp.gmail.com with ESMTPSA id r30sm165941104wrr.46.2019.04.15.09.47.47 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 15 Apr 2019 09:47:48 -0700 (PDT) From: Slavomir Kaslev To: rostedt@goodmis.org Cc: linux-trace-devel@vger.kernel.org, pauld@redhat.com, ykaradzhov@vmware.com, jbacik@fb.com, tstoyanov@vmware.com, slavomir.kaslev@gmail.com Subject: [PATCH v2 2/2] trace-cmd: Add --no-filter option to not filter recording processes Date: Mon, 15 Apr 2019 19:47:39 +0300 Message-Id: <20190415164739.17223-3-kaslevs@vmware.com> X-Mailer: git-send-email 2.19.1 In-Reply-To: <20190415164739.17223-1-kaslevs@vmware.com> References: <20190415164739.17223-1-kaslevs@vmware.com> MIME-Version: 1.0 Sender: linux-trace-devel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-trace-devel@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Add --no-filter option which doesn't install filters for the trace-cmd recording processes pids. Signed-off-by: Slavomir Kaslev Suggested-by: Steven Rostedt (VMware) --- tracecmd/trace-record.c | 14 +++++++++++--- tracecmd/trace-usage.c | 1 + 2 files changed, 12 insertions(+), 3 deletions(-) diff --git a/tracecmd/trace-record.c b/tracecmd/trace-record.c index eeee5e9..133dfdf 100644 --- a/tracecmd/trace-record.c +++ b/tracecmd/trace-record.c @@ -86,6 +86,7 @@ static int do_ptrace; static int filter_task; static int filter_pid = -1; +static bool no_filter = false; static int local_cpu_count; @@ -1061,6 +1062,9 @@ static void update_task_filter(void) struct buffer_instance *instance; int pid = getpid(); + if (no_filter) + return; + if (filter_task) add_filter_pid(pid, 0); @@ -4375,9 +4379,9 @@ void update_first_instance(struct buffer_instance *instance, int topt) } enum { - - OPT_quiet = 246, - OPT_debug = 247, + OPT_quiet = 245, + OPT_debug = 246, + OPT_no_filter = 247, OPT_max_graph_depth = 248, OPT_tsoffset = 249, OPT_bycomm = 250, @@ -4601,6 +4605,7 @@ static void parse_record_options(int argc, {"by-comm", no_argument, NULL, OPT_bycomm}, {"ts-offset", required_argument, NULL, OPT_tsoffset}, {"max-graph-depth", required_argument, NULL, OPT_max_graph_depth}, + {"no-filter", no_argument, NULL, OPT_no_filter}, {"debug", no_argument, NULL, OPT_debug}, {"quiet", no_argument, NULL, OPT_quiet}, {"help", no_argument, NULL, '?'}, @@ -4875,6 +4880,9 @@ static void parse_record_options(int argc, if (!ctx->max_graph_depth) die("Could not allocate option"); break; + case OPT_no_filter: + no_filter = true; + break; case OPT_debug: debug = 1; break; diff --git a/tracecmd/trace-usage.c b/tracecmd/trace-usage.c index 9ea1906..29a7081 100644 --- a/tracecmd/trace-usage.c +++ b/tracecmd/trace-usage.c @@ -56,6 +56,7 @@ static struct usage_help usage_help[] = { " --func-stack perform a stack trace for function tracer\n" " (use with caution)\n" " --max-graph-depth limit function_graph depth\n" + " --no-filter do not set any event filters\n" }, { "start",