| Message ID | 20190709155650.2345-7-y.karadz@gmail.com (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
| Series | Fixes needed befor KS 1.0 | expand |
On Tue, 9 Jul 2019 18:56:48 +0300 "Yordan Karadzhov (VMware)" <y.karadz@gmail.com> wrote: > The message is not appropriate, although it is most likely that the > error occurs because the user didn't install KernelShark and it runs > the executable from its build location.= I don't believe it is most likely, as I hit this error several times and that wasn't the solution. But we need to have an error stating what was missing. -- Steve > > Signed-off-by: Yordan Karadzhov (VMware) <y.karadz@gmail.com> > --- > kernel-shark/src/KsMainWindow.cpp | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/kernel-shark/src/KsMainWindow.cpp b/kernel-shark/src/KsMainWindow.cpp > index 752a17a..3f238db 100644 > --- a/kernel-shark/src/KsMainWindow.cpp > +++ b/kernel-shark/src/KsMainWindow.cpp > @@ -1154,8 +1154,6 @@ void KsMainWindow::_captureError(QProcess::ProcessError error) > QString message = "Capture process failed:<br>"; > > message += capture->errorString(); > - message += "<br>Try doing:<br> sudo make install"; > - > _error(message, "captureFinishedErr", false, false); > } >
diff --git a/kernel-shark/src/KsMainWindow.cpp b/kernel-shark/src/KsMainWindow.cpp index 752a17a..3f238db 100644 --- a/kernel-shark/src/KsMainWindow.cpp +++ b/kernel-shark/src/KsMainWindow.cpp @@ -1154,8 +1154,6 @@ void KsMainWindow::_captureError(QProcess::ProcessError error) QString message = "Capture process failed:<br>"; message += capture->errorString(); - message += "<br>Try doing:<br> sudo make install"; - _error(message, "captureFinishedErr", false, false); }
The message is not appropriate, although it is most likely that the error occurs because the user didn't install KernelShark and it runs the executable from its build location. Signed-off-by: Yordan Karadzhov (VMware) <y.karadz@gmail.com> --- kernel-shark/src/KsMainWindow.cpp | 2 -- 1 file changed, 2 deletions(-)