From patchwork Tue Jul 9 15:56:48 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yordan Karadzhov X-Patchwork-Id: 11037185 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 5BF2414C0 for ; Tue, 9 Jul 2019 15:57:30 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 4C7982870C for ; Tue, 9 Jul 2019 15:57:30 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 4131928714; Tue, 9 Jul 2019 15:57:30 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id ECB172870C for ; Tue, 9 Jul 2019 15:57:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726282AbfGIP53 (ORCPT ); Tue, 9 Jul 2019 11:57:29 -0400 Received: from mail-wm1-f65.google.com ([209.85.128.65]:36270 "EHLO mail-wm1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726211AbfGIP53 (ORCPT ); Tue, 9 Jul 2019 11:57:29 -0400 Received: by mail-wm1-f65.google.com with SMTP id g67so3812983wme.1 for ; Tue, 09 Jul 2019 08:57:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=oafdOE8cfRFcWDHI3K/XrnurRFkCwhoOhyD3nfV4xjc=; b=dsnBZ+3xtGobcd4JSiENGMzhLM9tNbjUdHw1/3UebxFHWXPssY7ep7lX4QIqQxjE56 FkaeiipwZVJMHtGjY/o8Ye1v+f5cZ0rsZa2rGRA7kZwpjsv6zJHFLkV4wj/yM8A/H6Ak EKcrXnukrTc+amF6OeCxiO5n3zmJhlrjuvFt94XXgADGG9Nn2AJiPe8AVOBmMTFTLqpk 0iArAA84Q0nFVwbFFABU6b4Elr+VCUnzIW45aYO5Q5JK4115H7iXMk7ZFOcyY3SNgfOj d0fNdLhEId2A8j/bTW6eGVGGLqnvzWJka4ZyWbIHhzCtW/5dHhAb1LoBLz1k0YZJnn7B ZdaA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=oafdOE8cfRFcWDHI3K/XrnurRFkCwhoOhyD3nfV4xjc=; b=IudCVsRi6BwazfL1Gdgcjn+/z/MgvlNaPXfaUH4MMF6GiqN1DAmVeaiqSau+MBmzbD +BOqAV1Fq5679nWkWBOGfs6yKHIMNd9OuSa2qRz4nN22sR8co5t28qHi3gSGSrsMC5ix oIQLk30ID8dzjHVHykarsuF0phUUFsynwFLj9FKIugx28iGtXyXwP9Ne1CDAoaWiPLPo Au+3gmNhVIPmnt9XrhaqTAktKQwc/KSgMz3dXtsURD4ph6CEoYWH/+Ti19nNGcaLKcIF I0VoSgZHHbNG33WiY1GsbAzG8DAu2SULYn77HxOdXh6wbHP7mq8Hve4C+MOeNKDnIsUR NErw== X-Gm-Message-State: APjAAAU8is7MN1VGpbQxgSRUog+sOSJAEC/0QumJb8BnoczGX5SKJfw/ FYLnAhiJVVVCtekn7KbolvM= X-Google-Smtp-Source: APXvYqzhhRbw/4AEN7R0yl6ZSKTv8OrxyAQJ5GuGWimKZ3tGoOv++2VoZqKCLL2hjxmvMTeDTinD8A== X-Received: by 2002:a7b:c0d0:: with SMTP id s16mr556271wmh.136.1562687847497; Tue, 09 Jul 2019 08:57:27 -0700 (PDT) Received: from mamba.eng.vmware.com ([146.247.46.5]) by smtp.gmail.com with ESMTPSA id v5sm24313746wre.50.2019.07.09.08.57.26 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Tue, 09 Jul 2019 08:57:27 -0700 (PDT) From: "Yordan Karadzhov (VMware)" To: rostedt@goodmis.org Cc: linux-trace-devel@vger.kernel.org, "Yordan Karadzhov (VMware)" Subject: [PATCH 6/8] kernel-shark: remove the "make install" suggestion for capture errors Date: Tue, 9 Jul 2019 18:56:48 +0300 Message-Id: <20190709155650.2345-7-y.karadz@gmail.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190709155650.2345-1-y.karadz@gmail.com> References: <20190709155650.2345-1-y.karadz@gmail.com> MIME-Version: 1.0 Sender: linux-trace-devel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-trace-devel@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The message is not appropriate, although it is most likely that the error occurs because the user didn't install KernelShark and it runs the executable from its build location. Signed-off-by: Yordan Karadzhov (VMware) --- kernel-shark/src/KsMainWindow.cpp | 2 -- 1 file changed, 2 deletions(-) diff --git a/kernel-shark/src/KsMainWindow.cpp b/kernel-shark/src/KsMainWindow.cpp index 752a17a..3f238db 100644 --- a/kernel-shark/src/KsMainWindow.cpp +++ b/kernel-shark/src/KsMainWindow.cpp @@ -1154,8 +1154,6 @@ void KsMainWindow::_captureError(QProcess::ProcessError error) QString message = "Capture process failed:
"; message += capture->errorString(); - message += "
Try doing:
sudo make install"; - _error(message, "captureFinishedErr", false, false); }