From patchwork Mon Jul 22 15:37:07 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Steven Rostedt X-Patchwork-Id: 11052721 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 416C11398 for ; Mon, 22 Jul 2019 15:37:11 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 2B01822A68 for ; Mon, 22 Jul 2019 15:37:11 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 1ED8627D16; Mon, 22 Jul 2019 15:37:11 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id B1F4322A68 for ; Mon, 22 Jul 2019 15:37:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728386AbfGVPhK (ORCPT ); Mon, 22 Jul 2019 11:37:10 -0400 Received: from mail.kernel.org ([198.145.29.99]:53310 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726553AbfGVPhK (ORCPT ); Mon, 22 Jul 2019 11:37:10 -0400 Received: from gandalf.local.home (cpe-66-24-58-225.stny.res.rr.com [66.24.58.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 1DBF22190F; Mon, 22 Jul 2019 15:37:09 +0000 (UTC) Date: Mon, 22 Jul 2019 11:37:07 -0400 From: Steven Rostedt To: Linux Trace Devel Cc: howaboutsynergy@pm.me Subject: [PATCH] kernel-shark: Add quotes around $XDG_SESSION_TYPE in kshark-su-record Message-ID: <20190722113707.156a099f@gandalf.local.home> X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Sender: linux-trace-devel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-trace-devel@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: "Steven Rostedt (VMware)" If XDG_SESSION_TYPE is not set, then $XDG_SESSION_TYPE will become nothing, which means the test: if [ $XDG_SESSION_TYPE = "wayland" ]; turns into if [ = "wayland" ]; And will cause a shell error. Adding quotes around "$XDG_SESSION_TYPE" changes an empty $XDG_SESSION_TYPE into: if [ "" = "wayland" ]; which the shell can understand. Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=204261 Signed-off-by: Steven Rostedt (VMware) Reviewed-by: Yordan Karadzhov (VMware) --- kernel-shark/bin/kshark-su-record | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel-shark/bin/kshark-su-record b/kernel-shark/bin/kshark-su-record index ee839a26..2477045f 100755 --- a/kernel-shark/bin/kshark-su-record +++ b/kernel-shark/bin/kshark-su-record @@ -1,6 +1,6 @@ #!/bin/bash -if [ $XDG_SESSION_TYPE = "wayland" ] +if [ "$XDG_SESSION_TYPE" = "wayland" ] then xhost +si:localuser:root &>/dev/null fi