From patchwork Fri Aug 9 08:06:23 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yordan Karadzhov X-Patchwork-Id: 11085629 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 192BB13AC for ; Fri, 9 Aug 2019 08:06:50 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 0D40828C37 for ; Fri, 9 Aug 2019 08:06:50 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 0180328C47; Fri, 9 Aug 2019 08:06:49 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 9180A28C37 for ; Fri, 9 Aug 2019 08:06:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2405690AbfHIIGt (ORCPT ); Fri, 9 Aug 2019 04:06:49 -0400 Received: from mail-wm1-f66.google.com ([209.85.128.66]:38914 "EHLO mail-wm1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2405567AbfHIIGt (ORCPT ); Fri, 9 Aug 2019 04:06:49 -0400 Received: by mail-wm1-f66.google.com with SMTP id u25so4756711wmc.4 for ; Fri, 09 Aug 2019 01:06:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=VqMOUTuD2s5Dbp59FMHyRSWw9hchSLCbb+LBTKkCOv0=; b=XgPctS15VmVBrbuFUKDCuAqYuD+EsUdOptQ4SSfBKPVIf33XaqS89XChWgoNPpXE/i Pw2TYdtUOJHiUe9lQjapIKAlVAFRUS+Y8q/IZXSVd9G5tXaGuXG4A3uLlWcFK/bAIMnk zMs53olaf9LoQn0yElTC1/s8LgZRuDSiGAsIGvAyacj0lOPAB8vzRw3rgJut1LjRMcT0 enaryLh1fdZJzoJk7ShUiTdUajvNDci74S4+uYBEn6Iuo/qjB2EaHe9+Minksylzldql xqRXlmB7cLC9216Uaq3AUehJujZ9+0RWHPT0pnNSOTR8hFHs0Cguxmg0vMDwXUdq/y0G IYnA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=VqMOUTuD2s5Dbp59FMHyRSWw9hchSLCbb+LBTKkCOv0=; b=LDE5BWeC1RO1gLRLvxBF069/3LokuxG+6luJR6Nh8U6FNZOio/np5In+5ZxXY3PhSj 0ciK5TKirg7lNiNsqZ9VDK64cuv8LmUbsBw5JLLKnprkkRNobJw4rLrbXCHxIRiVuVpd eaH/dZUHuCkU0IyM20bI/aUuUeKDpTgFmrG1cpYVSA5+ylQR/slclV5D1+9IOsrRGLDS /FdEyDpDDn2OuaXA0CV/vQsu01Tt3ppLnShKSytfmDfDCV+++WA++wNbEkUCxSzgGFPD wgBVWTPmXMZ2NmXLdqz/YS4IlMTILuynolysiV69dyVXgGHclH8/PDC/M7l7hTaYh9zi Fkpg== X-Gm-Message-State: APjAAAWbXYYFBYzhV8y9ReyeD3O4ScIh8smNH0kHpqoWaKHOMRqVz/sJ JYGMmXL6AqlwtdR4yFXuhB0= X-Google-Smtp-Source: APXvYqzGf5d21BPmT9EXM2MCivDs0G0cfbobE7RQjvcRa0EQg8THhO74BZRt6ZcT6DfLOSZmr3qg1Q== X-Received: by 2002:a7b:c149:: with SMTP id z9mr9570761wmi.0.1565338007162; Fri, 09 Aug 2019 01:06:47 -0700 (PDT) Received: from mamba.eng.vmware.com ([146.247.46.5]) by smtp.gmail.com with ESMTPSA id q124sm6964302wma.33.2019.08.09.01.06.46 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Fri, 09 Aug 2019 01:06:46 -0700 (PDT) From: "Yordan Karadzhov (VMware)" To: rostedt@goodmis.org Cc: linux-trace-devel@vger.kernel.org, mike.auty@gmail.com, "Yordan Karadzhov (VMware)" Subject: [PATCH 3/3] kernel-shark: Use standart error message in KsMainWindow::_record() Date: Fri, 9 Aug 2019 11:06:23 +0300 Message-Id: <20190809080623.7548-4-y.karadz@gmail.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190809080623.7548-1-y.karadz@gmail.com> References: <20190809080623.7548-1-y.karadz@gmail.com> MIME-Version: 1.0 Sender: linux-trace-devel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-trace-devel@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The error message is printed using the method KsMainWindow::_error(). The message itself remains unchanged. If we want to change the message, this can be done in another patch. Signed-off-by: Yordan Karadzhov (VMware) --- kernel-shark/src/KsMainWindow.cpp | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/kernel-shark/src/KsMainWindow.cpp b/kernel-shark/src/KsMainWindow.cpp index e9c6d54..b462ded 100644 --- a/kernel-shark/src/KsMainWindow.cpp +++ b/kernel-shark/src/KsMainWindow.cpp @@ -890,7 +890,6 @@ void KsMainWindow::_record() #endif if (geteuid() && !canDoAsRoot) { - QErrorMessage *em = new QErrorMessage(this); QString message; message = "Record is currently not supported."; @@ -899,8 +898,7 @@ void KsMainWindow::_record() message += " ./cmake_clean.sh
cmake ..
make
"; message += " sudo make install"; - em->showMessage(message); - qCritical() << "ERROR: " << message; + _error(message, "recordCantStart", false, false); return; }