| Message ID | 20190918020530.974032887@goodmis.org (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
| Series | trace-cmd: Update for the new trace_print_event() logic | expand |
On Wed, Sep 18, 2019 at 5:03 AM Steven Rostedt <rostedt@goodmis.org> wrote: > > From: "Steven Rostedt (VMware)" <rostedt@goodmis.org> > > When testing the output of the old trace-cmd compared to the one that uses > the updated tep_print_event() logic, it was different in that the time stamp > precision in the old format would round up to the nearest precision, where > as the new logic truncates. Bring back the old method of rounding up. > > Signed-off-by: Steven Rostedt (VMware) <rostedt@goodmis.org> > --- > lib/traceevent/event-parse.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/lib/traceevent/event-parse.c b/lib/traceevent/event-parse.c > index d1085aab9c43..7fbbbccab78a 100644 > --- a/lib/traceevent/event-parse.c > +++ b/lib/traceevent/event-parse.c > @@ -5527,8 +5527,10 @@ static void print_event_time(struct tep_handle *tep, struct trace_seq *s, > if (divstr && isdigit(*(divstr + 1))) > div = atoi(divstr + 1); > time = record->ts; > - if (div) > + if (div) { > + time += div / 2; > time /= div; > + } > pr = prec; > while (pr--) > p10 *= 10; > -- > 2.20.1 > > Looks good to me. Reviewed-by: Tzvetomir Stoyanov (VMware) <tz.stoyanov@gmail.com>
diff --git a/lib/traceevent/event-parse.c b/lib/traceevent/event-parse.c index d1085aab9c43..7fbbbccab78a 100644 --- a/lib/traceevent/event-parse.c +++ b/lib/traceevent/event-parse.c @@ -5527,8 +5527,10 @@ static void print_event_time(struct tep_handle *tep, struct trace_seq *s, if (divstr && isdigit(*(divstr + 1))) div = atoi(divstr + 1); time = record->ts; - if (div) + if (div) { + time += div / 2; time /= div; + } pr = prec; while (pr--) p10 *= 10;