[v2,17/21] trace-cmd report: Do not print empty buffer name

Message ID	20210913122759.3672494-18-tz.stoyanov@gmail.com (mailing list archive)
State	Superseded
Headers	show Return-Path: <linux-trace-devel-owner@kernel.org> From: "Tzvetomir Stoyanov (VMware)" <tz.stoyanov@gmail.com> To: rostedt@goodmis.org Cc: linux-trace-devel@vger.kernel.org Subject: [PATCH v2 17/21] trace-cmd report: Do not print empty buffer name Date: Mon, 13 Sep 2021 15:27:55 +0300 Message-Id: <20210913122759.3672494-18-tz.stoyanov@gmail.com> In-Reply-To: <20210913122759.3672494-1-tz.stoyanov@gmail.com> References: <20210913122759.3672494-1-tz.stoyanov@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk
Series	trace-cmd fixes and clean-ups \| expand [v2,00/21] trace-cmd fixes and clean-ups [v2,01/21] trace-cmd library: Read option id with correct endian [v2,02/21] trace-cmd report: Fix typos in error messages [v2,03/21] trace-cmd library: Fix version string memory leak [v2,04/21] trace-cmd library: Fixed a memory leak on input handler close [v2,05/21] trace-cmd library: Do not pass guests list to a buffer instance [v2,06/21] trace-cmd library: Set long size to the input tep handler when it is read from the file [v2,07/21] trace-cmd library: Do not use local variables when reading CPU stat option [v2,08/21] trace-cmd library: Reuse within the library the function that checks file state. [v2,09/21] trace-cmd library: Fix possible memory leak in read_ftrace_files() [v2,10/21] trace-cmd library: Fix possible memory leak in read_event_files() [v2,11/21] trace-cmd library: Fix possible memory leak in read_proc_kallsyms() [v2,12/21] trace-cmd library: Fix possible memory leak in read_ftrace_printk() [v2,13/21] trace-cmd library: Fix possible memory leak in read_and_parse_cmdlines() [v2,14/21] trace-cmd library: Set input handler default values in allocation function [v2,15/21] trace-cmd library: Track maximum CPUs count in input handler [v2,16/21] trace-cmd report: Close input file handlers on exit [v2,17/21] trace-cmd report: Do not print empty buffer name [v2,18/21] trace-cmd library: Set correct CPU to the record, retrieved with tracecmd_peek_data [v2,19/21] trace-cmd library: Refactor APIs for creating output handler [v2,20/21] trace-cmd library: Refactor the logic for writing trace data in the file [v2,21/21] trace-cmd report: Init the top trace instance earlier

Message ID

20210913122759.3672494-18-tz.stoyanov@gmail.com (mailing list archive)

State

Superseded

Headers

From: "Tzvetomir Stoyanov (VMware)" <tz.stoyanov@gmail.com>
To: rostedt@goodmis.org
Cc: linux-trace-devel@vger.kernel.org
Subject: [PATCH v2 17/21] trace-cmd report: Do not print empty buffer name
Date: Mon, 13 Sep 2021 15:27:55 +0300
Message-Id: <20210913122759.3672494-18-tz.stoyanov@gmail.com>
In-Reply-To: <20210913122759.3672494-1-tz.stoyanov@gmail.com>
References: <20210913122759.3672494-1-tz.stoyanov@gmail.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Precedence: bulk

Series

trace-cmd fixes and clean-ups | expand

Commit Message

Tzvetomir Stoyanov (VMware) Sept. 13, 2021, 12:27 p.m. UTC

This clean up is needed for the design of the next version of the trace
file, where the top buffer is saved with its empty file name, string "".

Signed-off-by: Tzvetomir Stoyanov (VMware) <tz.stoyanov@gmail.com>
---
 tracecmd/trace-read.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tracecmd/trace-read.c b/tracecmd/trace-read.c
index 4261088d..02f75cb9 100644
--- a/tracecmd/trace-read.c
+++ b/tracecmd/trace-read.c
@@ -1173,7 +1173,7 @@  static void print_handle_file(struct handle_list *handles)
 	/* Only print file names if more than one file is read */
 	if (!multi_inputs && !instances)
 		return;
-	if (handles->file)
+	if (handles->file && *handles->file != '\0')
 		printf("%*s: ", max_file_size, handles->file);
 	else
 		printf("%*s  ", max_file_size, "");

[v2,17/21] trace-cmd report: Do not print empty buffer name

Commit Message

Patch