| Message ID | 20220503064857.260937-3-tz.stoyanov@gmail.com (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
| Series | trace-cruncher: Small fixes | expand |
On 3.05.22 г. 9:48 ч., Tzvetomir Stoyanov (VMware) wrote: > Recent commits add functionality for function name to address resolving, > using bfd library. This breaks the github action, used for > trace-cruncher CI, as it does not have bfd development files. Updated > the workflow with bfd development package. > > Signed-off-by: Tzvetomir Stoyanov (VMware) <tz.stoyanov@gmail.com> > --- > .github/workflows/main.yml | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml > index a9520e7..0d72bbf 100644 > --- a/.github/workflows/main.yml > +++ b/.github/workflows/main.yml > @@ -17,7 +17,7 @@ jobs: > shell: bash > run: | > sudo apt-get update > - sudo apt-get install build-essential git cmake libjson-c-dev -y > + sudo apt-get install build-essential git cmake libjson-c-dev binutils-dev -y This must be added to the install instructions in README as well. Probably in a separate patch. Everything else looks good to me. Reviewed-by: Yordan Karadzhov (VMware) <y.karadz@gmail.com> > sudo apt-get install libpython3-dev cython3 python3-numpy -y > sudo apt install python3-pip > sudo pip3 install --system pkgconfig GitPython
diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index a9520e7..0d72bbf 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -17,7 +17,7 @@ jobs: shell: bash run: | sudo apt-get update - sudo apt-get install build-essential git cmake libjson-c-dev -y + sudo apt-get install build-essential git cmake libjson-c-dev binutils-dev -y sudo apt-get install libpython3-dev cython3 python3-numpy -y sudo apt install python3-pip sudo pip3 install --system pkgconfig GitPython
Recent commits add functionality for function name to address resolving, using bfd library. This breaks the github action, used for trace-cruncher CI, as it does not have bfd development files. Updated the workflow with bfd development package. Signed-off-by: Tzvetomir Stoyanov (VMware) <tz.stoyanov@gmail.com> --- .github/workflows/main.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)