diff mbox series

libtracefs: Have tracefs_tracer_set() return zero on success

Message ID 20221115000031.5f2da5dd@gandalf.local.home (mailing list archive)
State Accepted
Commit a60e3a1bd086b730014c2d01b7d822c9b49454ae
Headers show
Series libtracefs: Have tracefs_tracer_set() return zero on success | expand

Commit Message

Steven Rostedt Nov. 15, 2022, 5 a.m. UTC 
From: "Steven Rostedt (Google)" <rostedt@goodmis.org>

The tracefs_tracer_set() does a ret = write() to write the tracer name
into the current_tracer file, but then it returns the ret as well. "write"
returns the number of bytes written, but tracefs_tracer_set() is suppose
to return 0 on success.

Have it return 0 instead of the number of bytes written on success.

Fixes: df130d4915b15 ("libtracefs: Add support for setting tracers")
Signed-off-by: Steven Rostedt (Google) <rostedt@goodmis.org>
---
 src/tracefs-tools.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff mbox series

Patch

diff --git a/src/tracefs-tools.c b/src/tracefs-tools.c
index 489be28a3b94..8e7b46db86e9 100644
--- a/src/tracefs-tools.c
+++ b/src/tracefs-tools.c
@@ -1055,7 +1055,7 @@  int tracefs_tracer_set(struct tracefs_instance *instance,
  out:
 	tracefs_put_tracing_file(tracer_path);
 	close(fd);
-	return ret;
+	return ret > 0 ? 0 : ret;
 }
 
 int  tracefs_tracer_clear(struct tracefs_instance *instance)