[v3,0/5] tracing/probes: Cleanup with guard and __free for kprobe and fprobe

Message

Masami Hiramatsu (Google) Jan. 7, 2025, 11:50 a.m. UTC

Hi,

Here is the 3rd version of the series to fix and cleanup probe events in
ftrace with __free(). I resend this without dynevent and argv_free
parts because it has been sent by Steve[1]. And I updated the version
tag.

In this version, I fixed some issues[5/7] and update DEFINE_FREE() tag
name to specify freeing function name so that reader can understand it
easily[2/7].
Also, I added trace_fprobe cleanup with free[7/7].

Thanks,

---

Masami Hiramatsu (Google) (5):
      tracing/kprobes: Fix to free objects when failed to copy a symbol
      tracing: Use __free() in trace_probe for cleanup
      tracing: Use __free() for kprobe events to cleanup
      tracing/kprobes: Simplify __trace_kprobe_create() by removing gotos
      tracing: Adopt __free() and guard() for trace_fprobe.c


 kernel/trace/trace_fprobe.c |  129 +++++++++++++++++++-----------------------
 kernel/trace/trace_kprobe.c |  133 ++++++++++++++++++++++---------------------
 kernel/trace/trace_probe.c  |   52 ++++++-----------
 3 files changed, 145 insertions(+), 169 deletions(-)

--
Masami Hiramatsu (Google) <[e-mail]>

Comments

Masami Hiramatsu (Google) Jan. 7, 2025, 11:53 a.m. UTC | #1

On Tue,  7 Jan 2025 20:50:03 +0900
"Masami Hiramatsu (Google)" <[e-mail]> wrote:

> Hi,
> 
> Here is the 3rd version of the series to fix and cleanup probe events in
> ftrace with __free(). I resend this without dynevent and argv_free
> parts because it has been sent by Steve[1]. And I updated the version
> tag.
> 
> In this version, I fixed some issues[5/7] and update DEFINE_FREE() tag
> name to specify freeing function name so that reader can understand it
> easily[2/7].
> Also, I added trace_fprobe cleanup with free[7/7].

Ah, these numbers should be updated. So fixed some issues in [3/5] and
add trace_fprobe.c update in [5/5].

Thanks,

> 
> Thanks,
> 
> ---
> 
> Masami Hiramatsu (Google) (5):
>       tracing/kprobes: Fix to free objects when failed to copy a symbol
>       tracing: Use __free() in trace_probe for cleanup
>       tracing: Use __free() for kprobe events to cleanup
>       tracing/kprobes: Simplify __trace_kprobe_create() by removing gotos
>       tracing: Adopt __free() and guard() for trace_fprobe.c
> 
> 
>  kernel/trace/trace_fprobe.c |  129 +++++++++++++++++++-----------------------
>  kernel/trace/trace_kprobe.c |  133 ++++++++++++++++++++++---------------------
>  kernel/trace/trace_probe.c  |   52 ++++++-----------
>  3 files changed, 145 insertions(+), 169 deletions(-)
> 
> --
> Masami Hiramatsu (Google) <[e-mail]>