| Message ID | 20240319-tracing-fully-silence-wstring-compare-v1-0-81adb44403f5@kernel.org (mailing list archive) |
|---|---|
| Headers | show |
| Series | tracing: Fully silence instance of -Wstring-compare | expand |
On Tue, 19 Mar 2024 09:07:51 -0700 Nathan Chancellor <nathan@kernel.org> wrote: > Hi all, > > This series fully resolves the new instance of -Wstring-compare from > within the __assign_str() macro. The first patch resolves a build > failure with GCC that would be seen with just the second patch applied. > The second patch actually hides the warning. > > NOTE: This is based on trace/for-next, which does not contain the > minimum LLVM version bump that occurred later in the current merge > window, so this uses > > __diag_ignore(clang, 11, ... > > instead of > > __diag_ignore(clang, 13, ... > > which will be required when this is merged into Linus's tree. If you can > base this series on a tree that has the merge commit e5eb28f6d1af ("Merge > tag 'mm-nonmm-stable-2024-03-14-09-36' of > git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm") in it, then that > change can be done at application time, rather than merge time (or I can > send a v2). It would be really nice for this to make the merge window so > that this warning does not proliferate into other trees that base on > -rc1. > I'm guessing this isn't needed with the last update. -- Steve
On Tue, Mar 19, 2024 at 06:15:09PM -0400, Steven Rostedt wrote: > On Tue, 19 Mar 2024 09:07:51 -0700 > Nathan Chancellor <nathan@kernel.org> wrote: > > > Hi all, > > > > This series fully resolves the new instance of -Wstring-compare from > > within the __assign_str() macro. The first patch resolves a build > > failure with GCC that would be seen with just the second patch applied. > > The second patch actually hides the warning. > > > > NOTE: This is based on trace/for-next, which does not contain the > > minimum LLVM version bump that occurred later in the current merge > > window, so this uses > > > > __diag_ignore(clang, 11, ... > > > > instead of > > > > __diag_ignore(clang, 13, ... > > > > which will be required when this is merged into Linus's tree. If you can > > base this series on a tree that has the merge commit e5eb28f6d1af ("Merge > > tag 'mm-nonmm-stable-2024-03-14-09-36' of > > git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm") in it, then that > > change can be done at application time, rather than merge time (or I can > > send a v2). It would be really nice for this to make the merge window so > > that this warning does not proliferate into other trees that base on > > -rc1. > > > > I'm guessing this isn't needed with the last update. Correct, this is resolved in Linus's tree and should be in -next tomorrow. The first patch may be worth sending standalone, I'll think about sending it later but that can go in via some other tree, not yours. Cheers, Nathan
Hi all, This series fully resolves the new instance of -Wstring-compare from within the __assign_str() macro. The first patch resolves a build failure with GCC that would be seen with just the second patch applied. The second patch actually hides the warning. NOTE: This is based on trace/for-next, which does not contain the minimum LLVM version bump that occurred later in the current merge window, so this uses __diag_ignore(clang, 11, ... instead of __diag_ignore(clang, 13, ... which will be required when this is merged into Linus's tree. If you can base this series on a tree that has the merge commit e5eb28f6d1af ("Merge tag 'mm-nonmm-stable-2024-03-14-09-36' of git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm") in it, then that change can be done at application time, rather than merge time (or I can send a v2). It would be really nice for this to make the merge window so that this warning does not proliferate into other trees that base on -rc1. --- Nathan Chancellor (2): compiler_types: Ensure __diag_clang() is always available tracing: Ignore -Wstring-compare with diagnostic macros include/linux/compiler_types.h | 4 ++++ include/trace/stages/stage6_event_callback.h | 5 +++++ 2 files changed, 9 insertions(+) --- base-commit: 7604256cecef34a82333d9f78262d3180f4eb525 change-id: 20240319-tracing-fully-silence-wstring-compare-e71e2fd17b2a Best regards,