diff mbox series

kprobes: Fix to check symbol prefixes correctly

Message ID 172260679559.362040.7360872132937227206.stgit@devnote2 (mailing list archive)
State Accepted
Commit 8c8acb8f26cbde665b233dd1b9bbcbb9b86822dc
Headers show
Series kprobes: Fix to check symbol prefixes correctly | expand

Commit Message

Masami Hiramatsu (Google) Aug. 2, 2024, 1:53 p.m. UTC 
From: Masami Hiramatsu (Google) <mhiramat@kernel.org>

Since str_has_prefix() takes the prefix as the 2nd argument and the string
as the first, is_cfi_preamble_symbol() always fails to check the prefix.
Fix the function parameter order so that it correctly check the prefix.

Fixes: de02f2ac5d8c ("kprobes: Prohibit probing on CFI preamble symbol")
Signed-off-by: Masami Hiramatsu (Google) <mhiramat@kernel.org>
---
 kernel/kprobes.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
diff mbox series

Patch

diff --git a/kernel/kprobes.c b/kernel/kprobes.c
index e85de37d9e1e..da59c68df841 100644
--- a/kernel/kprobes.c
+++ b/kernel/kprobes.c
@@ -1557,8 +1557,8 @@  static bool is_cfi_preamble_symbol(unsigned long addr)
 	if (lookup_symbol_name(addr, symbuf))
 		return false;
 
-	return str_has_prefix("__cfi_", symbuf) ||
-		str_has_prefix("__pfx_", symbuf);
+	return str_has_prefix(symbuf, "__cfi_") ||
+		str_has_prefix(symbuf, "__pfx_");
 }
 
 static int check_kprobe_address_safe(struct kprobe *p,