diff mbox series

tracing/hist: Fix wrong return value in parse_action_params()

Message ID 20221207034635.2253990-1-zhengyejian1@huawei.com (mailing list archive)
State Accepted
Commit 2cc6a528882d0e0ccbc1bca5f95b8c963cedac54
Headers show
Series tracing/hist: Fix wrong return value in parse_action_params() | expand

Commit Message

Zheng Yejian Dec. 7, 2022, 3:46 a.m. UTC 
When number of synth fields is more than SYNTH_FIELDS_MAX,
parse_action_params() should return -EINVAL.

Fixes: c282a386a397 ("tracing: Add 'onmatch' hist trigger action support")
Signed-off-by: Zheng Yejian <zhengyejian1@huawei.com>
---
 kernel/trace/trace_events_hist.c | 1 +
 1 file changed, 1 insertion(+)
diff mbox series

Patch

diff --git a/kernel/trace/trace_events_hist.c b/kernel/trace/trace_events_hist.c
index 1c82478e8dff..370474659827 100644
--- a/kernel/trace/trace_events_hist.c
+++ b/kernel/trace/trace_events_hist.c
@@ -3586,6 +3586,7 @@  static int parse_action_params(struct trace_array *tr, char *params,
 	while (params) {
 		if (data->n_params >= SYNTH_FIELDS_MAX) {
 			hist_err(tr, HIST_ERR_TOO_MANY_PARAMS, 0);
+			ret = -EINVAL;
 			goto out;
 		}