From patchwork Wed Sep 25 06:53:24 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Shivani Agarwal X-Patchwork-Id: 13811668 Received: from mail-oi1-f173.google.com (mail-oi1-f173.google.com [209.85.167.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 48171155A25 for ; Wed, 25 Sep 2024 06:53:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.173 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727247228; cv=none; b=BVZ1hagzWwId1vnCS3kAv64PzqXlTGPbUBrmjPZ8mscZeOD37kTb1de01NTdkAar4buAfPFhtrSWkOmwbQBLiPdMIuM15YFZ0IiZz24eK1KlbL3x+UbvwlwHVNzE6yQNkH3SOooIg/+9lKNmzT8bkLLuoR1uy/R8X14vj8kP0I8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727247228; c=relaxed/simple; bh=csK1+3FQxeqwT+kWCan2aSo2Vhaq89PesCbCgsxJviw=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=VNnTNSb0HzqVxzo6y+m3Dow6ZtX/6mCAC8CnKB1xfbz41PNGPol7+zN3uPuMUR2OYW2Nx98JbrTFrn8myYg01bxz1n99+N5K4qLf1IoQyQDXZbAKbgPEhTU/qhI36Fq3YpQGFZeXfNbSEkEhCeEYEs58dob2HTqihNJjTF14HKA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=broadcom.com; spf=fail smtp.mailfrom=broadcom.com; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b=bsNqwnPC; arc=none smtp.client-ip=209.85.167.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=broadcom.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=broadcom.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="bsNqwnPC" Received: by mail-oi1-f173.google.com with SMTP id 5614622812f47-3e03f0564c6so3770388b6e.2 for ; Tue, 24 Sep 2024 23:53:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1727247226; x=1727852026; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=QP99Ku+a6IJXsn+8AEBbbuYDfnHxeFpoLL1XUmm2vQA=; b=bsNqwnPC5wCeafLP1QfKNCiA+VD36NVrJvc3xNaoo9mnrjJAg9CUvQVTAXWzJ74S/+ vLAj/Ry4hjD7PlGPtl2SudtmN31UQi930fihcDkaLFSMHlCI5VwE4HwDqtW/8eoMNmKR 0uF6W1CoDtKrsI3CIngWqq+H4DR9vuaP3taAI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727247226; x=1727852026; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=QP99Ku+a6IJXsn+8AEBbbuYDfnHxeFpoLL1XUmm2vQA=; b=YGKBNLMywsGQhJFgHHk2ExB0So5b9KfSaPf7pb2r3VReZewItG5QDS9Om9EdcZuTVy gJ79n4DzkbJKIt8YVKMbSe03CRLO+QWrdoYpngNSi9Sn0AFIsfbJ+ba0/gdyEtW66oUc 9NLr9BzUbG4FZ1TUdvEa+wCKFx2XZLfr0LFULqTtcfBgI6+/nsKS2VDs9ChPgy8oCGEg leNnuBgArcfX1UKtc756lfVfvohNUICxkK+KhXXTPqZapZ9wMH4hEN6AVfGgABXRMAIz /aJw57t084UTNXz+Sj5PtHbDtSiA7+sqvUVEP5qiUEbF8oQqaqSS03SU1MwYM/sAKwSp qJBg== X-Forwarded-Encrypted: i=1; AJvYcCXWcVEaa1Cnr/FRzPhRegyLA5WPbq7YVzFg8qAmgLCSIEvk0i3+J4jOPbHy8l5BQWPQXirA0KRcSye/ffPjJoN0lSA=@vger.kernel.org X-Gm-Message-State: AOJu0Yx71R4JvT3aBtK66+IqIaMfj+3AfllaHHY9TVpSeiSGrLGTh9sX jcLtzNkOPKkdVeL+RB7QNmguCoZP3H9M1mxySQ5/dliqjl9jHeqFuNdHamijgA== X-Google-Smtp-Source: AGHT+IHoWUqsTosHKyrA0jfFvpKkB148Mv/L1s6g06uFRkgf7hEk4lI7klp+SGwtK/lNUD8ehoE7Mg== X-Received: by 2002:a05:6808:3a10:b0:3e0:1299:4dc with SMTP id 5614622812f47-3e29b7a0d21mr1308604b6e.25.1727247226229; Tue, 24 Sep 2024 23:53:46 -0700 (PDT) Received: from shivania.eng.vmware.com ([66.170.99.1]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-71afc97b623sm2147203b3a.169.2024.09.24.23.53.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Sep 2024 23:53:45 -0700 (PDT) From: Shivani Agarwal To: stable@vger.kernel.org, gregkh@linuxfoundation.org Cc: ajay.kaher@broadcom.com, alexey.makhalov@broadcom.com, vasavi.sirnapalli@broadcom.com, rostedt@goodmis.org, mhiramat@kernel.org, mathieu.desnoyers@efficios.com, linux-trace-kernel@vger.kernel.org, peterz@infradead.org, jpoimboe@redhat.com, sashal@kernel.org, Zheng Yejian , mark.rutland@arm.com, Shivani Agarwal Subject: [PATCH 2/2 v5.10] ftrace: Fix possible use-after-free issue in ftrace_location() Date: Tue, 24 Sep 2024 23:53:24 -0700 Message-Id: <20240925065324.121176-3-shivani.agarwal@broadcom.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20240925065324.121176-1-shivani.agarwal@broadcom.com> References: <20240925065324.121176-1-shivani.agarwal@broadcom.com> Precedence: bulk X-Mailing-List: linux-trace-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 From: Zheng Yejian [ Upstream commit e60b613df8b6253def41215402f72986fee3fc8d ] KASAN reports a bug: BUG: KASAN: use-after-free in ftrace_location+0x90/0x120 Read of size 8 at addr ffff888141d40010 by task insmod/424 CPU: 8 PID: 424 Comm: insmod Tainted: G W 6.9.0-rc2+ [...] Call Trace: dump_stack_lvl+0x68/0xa0 print_report+0xcf/0x610 kasan_report+0xb5/0xe0 ftrace_location+0x90/0x120 register_kprobe+0x14b/0xa40 kprobe_init+0x2d/0xff0 [kprobe_example] do_one_initcall+0x8f/0x2d0 do_init_module+0x13a/0x3c0 load_module+0x3082/0x33d0 init_module_from_file+0xd2/0x130 __x64_sys_finit_module+0x306/0x440 do_syscall_64+0x68/0x140 entry_SYSCALL_64_after_hwframe+0x71/0x79 The root cause is that, in lookup_rec(), ftrace record of some address is being searched in ftrace pages of some module, but those ftrace pages at the same time is being freed in ftrace_release_mod() as the corresponding module is being deleted: CPU1 | CPU2 register_kprobes() { | delete_module() { check_kprobe_address_safe() { | arch_check_ftrace_location() { | ftrace_location() { | lookup_rec() // USE! | ftrace_release_mod() // Free! To fix this issue: 1. Hold rcu lock as accessing ftrace pages in ftrace_location_range(); 2. Use ftrace_location_range() instead of lookup_rec() in ftrace_location(); 3. Call synchronize_rcu() before freeing any ftrace pages both in ftrace_process_locs()/ftrace_release_mod()/ftrace_free_mem(). Link: https://lore.kernel.org/linux-trace-kernel/20240509192859.1273558-1-zhengyejian1@huawei.com Cc: stable@vger.kernel.org Cc: Cc: Cc: Fixes: ae6aa16fdc16 ("kprobes: introduce ftrace based optimization") Suggested-by: Steven Rostedt Signed-off-by: Zheng Yejian Signed-off-by: Steven Rostedt (Google) Signed-off-by: Sasha Levin [Shivani: Modified to apply on v5.10.y] Signed-off-by: Shivani Agarwal --- kernel/trace/ftrace.c | 39 +++++++++++++++++++++++---------------- 1 file changed, 23 insertions(+), 16 deletions(-) diff --git a/kernel/trace/ftrace.c b/kernel/trace/ftrace.c index a781733b2a01..36182e7e0cd7 100644 --- a/kernel/trace/ftrace.c +++ b/kernel/trace/ftrace.c @@ -1566,12 +1566,15 @@ static struct dyn_ftrace *lookup_rec(unsigned long start, unsigned long end) unsigned long ftrace_location_range(unsigned long start, unsigned long end) { struct dyn_ftrace *rec; + unsigned long ip = 0; + rcu_read_lock(); rec = lookup_rec(start, end); if (rec) - return rec->ip; + ip = rec->ip; + rcu_read_unlock(); - return 0; + return ip; } /** @@ -1584,25 +1587,22 @@ unsigned long ftrace_location_range(unsigned long start, unsigned long end) */ unsigned long ftrace_location(unsigned long ip) { - struct dyn_ftrace *rec; + unsigned long loc; unsigned long offset; unsigned long size; - rec = lookup_rec(ip, ip); - if (!rec) { + loc = ftrace_location_range(ip, ip); + if (!loc) { if (!kallsyms_lookup_size_offset(ip, &size, &offset)) goto out; /* map sym+0 to __fentry__ */ if (!offset) - rec = lookup_rec(ip, ip + size - 1); + loc = ftrace_location_range(ip, ip + size - 1); } - if (rec) - return rec->ip; - out: - return 0; + return loc; } /** @@ -6331,6 +6331,8 @@ static int ftrace_process_locs(struct module *mod, /* We should have used all pages unless we skipped some */ if (pg_unuse) { WARN_ON(!skipped); + /* Need to synchronize with ftrace_location_range() */ + synchronize_rcu(); ftrace_free_pages(pg_unuse); } return ret; @@ -6513,6 +6515,9 @@ void ftrace_release_mod(struct module *mod) out_unlock: mutex_unlock(&ftrace_lock); + /* Need to synchronize with ftrace_location_range() */ + if (tmp_page) + synchronize_rcu(); for (pg = tmp_page; pg; pg = tmp_page) { /* Needs to be called outside of ftrace_lock */ @@ -6835,6 +6840,7 @@ void ftrace_free_mem(struct module *mod, void *start_ptr, void *end_ptr) unsigned long start = (unsigned long)(start_ptr); unsigned long end = (unsigned long)(end_ptr); struct ftrace_page **last_pg = &ftrace_pages_start; + struct ftrace_page *tmp_page = NULL; struct ftrace_page *pg; struct dyn_ftrace *rec; struct dyn_ftrace key; @@ -6878,12 +6884,8 @@ void ftrace_free_mem(struct module *mod, void *start_ptr, void *end_ptr) ftrace_update_tot_cnt--; if (!pg->index) { *last_pg = pg->next; - if (pg->records) { - free_pages((unsigned long)pg->records, pg->order); - ftrace_number_of_pages -= 1 << pg->order; - } - ftrace_number_of_groups--; - kfree(pg); + pg->next = tmp_page; + tmp_page = pg; pg = container_of(last_pg, struct ftrace_page, next); if (!(*last_pg)) ftrace_pages = pg; @@ -6900,6 +6902,11 @@ void ftrace_free_mem(struct module *mod, void *start_ptr, void *end_ptr) clear_func_from_hashes(func); kfree(func); } + /* Need to synchronize with ftrace_location_range() */ + if (tmp_page) { + synchronize_rcu(); + ftrace_free_pages(tmp_page); + } } void __init ftrace_free_init_mem(void)