| Message ID | 20241026150040.GC892629@lichtman.org (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Replace the use of simple_strtol/ul functions with kstrto | expand |
Hi, On Sat, Oct 26, 2024 at 8:00 AM Nir Lichtman <nir@lichtman.org> wrote: > > Remove logic that enables a fallback of interpreting numbers supplied in KDB CLI > to be interpreted as hex without explicit "0x" prefix as this can be confusing > for the end users. > > Suggested-by: Douglas Anderson <dianders@chromium.org> > Signed-off-by: Nir Lichtman <nir@lichtman.org> > > --- > kernel/debug/kdb/kdb_main.c | 16 ++++------------ > 1 file changed, 4 insertions(+), 12 deletions(-) Reviewed-by: Douglas Anderson <dianders@chromium.org>
diff --git a/kernel/debug/kdb/kdb_main.c b/kernel/debug/kdb/kdb_main.c index 930de4fdc708..d929a4335078 100644 --- a/kernel/debug/kdb/kdb_main.c +++ b/kernel/debug/kdb/kdb_main.c @@ -402,23 +402,15 @@ static void kdb_printenv(void) */ int kdbgetularg(const char *arg, unsigned long *value) { - /* - * If the first fails, also try base 16, for us - * folks too lazy to type the leading 0x... - */ - if (kstrtoul(arg, 0, value)) { - if (kstrtoul(arg, 16, value)) - return KDB_BADINT; - } + if (kstrtoul(arg, 0, value)) + return KDB_BADINT; return 0; } int kdbgetu64arg(const char *arg, u64 *value) { - if (kstrtou64(arg, 0, value)) { - if (kstrtou64(arg, 16, value)) - return KDB_BADINT; - } + if (kstrtou64(arg, 0, value)) + return KDB_BADINT; return 0; }
Remove logic that enables a fallback of interpreting numbers supplied in KDB CLI to be interpreted as hex without explicit "0x" prefix as this can be confusing for the end users. Suggested-by: Douglas Anderson <dianders@chromium.org> Signed-off-by: Nir Lichtman <nir@lichtman.org> --- kernel/debug/kdb/kdb_main.c | 16 ++++------------ 1 file changed, 4 insertions(+), 12 deletions(-)