tracing/fprobe: Call trace_probe_log_set_index(0) only once in __trace_fprobe_create()

Commit Message

Markus Elfring Sept. 26, 2024, 2:31 p.m. UTC

From: Markus Elfring <[e-mail]>
Date: Thu, 26 Sep 2024 16:22:32 +0200

A trace_probe_log_set_index(0) call was immediately used after a condition
check in this function implementation.
Thus call such a function only once instead directly before the check.

This issue was transformed by using the Coccinelle software.

Signed-off-by: Markus Elfring <[e-mail]>
---
 kernel/trace/trace_fprobe.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

--
2.46.1

Patch

diff --git a/kernel/trace/trace_fprobe.c b/kernel/trace/trace_fprobe.c
index 62e6a8f4aae9..752d1f163258 100644
--- a/kernel/trace/trace_fprobe.c
+++ b/kernel/trace/trace_fprobe.c
@@ -1047,13 +1047,12 @@  static int __trace_fprobe_create(int argc, const char *argv[])
 	if (ret < 0)
 		goto parse_error;

+	trace_probe_log_set_index(0);
 	if (!is_return && maxactive) {
-		trace_probe_log_set_index(0);
 		trace_probe_log_err(1, BAD_MAXACT_TYPE);
 		goto parse_error;
 	}

-	trace_probe_log_set_index(0);
 	if (event) {
 		ret = traceprobe_parse_event_name(&event, &group, gbuf,
 						  event - argv[0]);