From patchwork Thu Jul 26 20:07:26 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Doug Anderson X-Patchwork-Id: 10546407 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id C469114E2 for ; Thu, 26 Jul 2018 20:08:29 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id B978B2BCA3 for ; Thu, 26 Jul 2018 20:08:29 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id ABBC82BCAD; Thu, 26 Jul 2018 20:08:29 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 49B602BCA3 for ; Thu, 26 Jul 2018 20:08:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731537AbeGZV0x (ORCPT ); Thu, 26 Jul 2018 17:26:53 -0400 Received: from mail-pf1-f194.google.com ([209.85.210.194]:44430 "EHLO mail-pf1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730363AbeGZV0Y (ORCPT ); Thu, 26 Jul 2018 17:26:24 -0400 Received: by mail-pf1-f194.google.com with SMTP id k21-v6so926127pff.11 for ; Thu, 26 Jul 2018 13:07:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=YCd02/vZxpMRlLHq7ybx5SvTkjkTxXqzWT78stp+hMw=; b=ct+kS34NZ3WDSxHib4Np79lqIZVBgcbR2PXaSbW+F8rF0UlVvAv8Qc8rBDRgGyLRNc adLFHX93ew/4LgbwcLMuxLkBtLOgcjfVZI3WOZ/xDPeYvhuUwxOaUwcJ7YvvWDOohhWZ 4+Ihqnw8Fy6gEyO/xkHQpaZH3dzIxXyDOOkuM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=YCd02/vZxpMRlLHq7ybx5SvTkjkTxXqzWT78stp+hMw=; b=EiwLCt95V51G7o5oZqgpw/f7sAF8nC8JamST3GCLkyyzaBP0Xu6m9CfIQ34/Y48zyI C6uT5JWnJB0Lvf5PQMJNJUlbwL/gZL4/c7pywKYL/unmcgYJbAgrhIWcECzeley7WcO5 HkGKMzN+5YPcE97ZMvdBc9ke2cKjLcxiBC0m2DZ21I4e3lav3PmvDPdN8zgJ91Whih9d TT7gBle04S+s/epFkgqegJhoKwSAVyFX9Z356YmWnEOYNcLME7e420Pyg3eB92kKc7Rv Wc0ejZnR2x6uXVBV5rQJc16baNmsMKyA4a2Hf+pqULTLfu3NcxjFU/scndULd+oQBvMY hwbw== X-Gm-Message-State: AOUpUlEvmccO9FjpdOn63aSCyhFj0YieFjzJaacRYx2ikwPyIVenOm7Y di2jHO6iNRgv1alqOUEh5Ehc1tn7Qqo= X-Google-Smtp-Source: AAOMgpctpliepydZIdjwcvave/W+iGH40G0PASuXWg7hzHdtylPJp/9mBa/Eee8hhCwtLM+DKB1RyA== X-Received: by 2002:a62:57dc:: with SMTP id i89-v6mr3518847pfj.65.1532635678848; Thu, 26 Jul 2018 13:07:58 -0700 (PDT) Received: from tictac2.mtv.corp.google.com ([2620:0:1000:1501:38e4:86fe:ec0c:4007]) by smtp.gmail.com with ESMTPSA id u11-v6sm5784169pfd.117.2018.07.26.13.07.57 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 26 Jul 2018 13:07:57 -0700 (PDT) From: Douglas Anderson To: balbi@kernel.org, hminas@synopsys.com, gregkh@linuxfoundation.org Cc: stefan.wahren@i2se.com, grigor.tovmasyan@synopsys.com, Bruno Herrera , Zhangfei Gao , john.stultz@linaro.org, Stephen Warren , Jerome Brunet , Douglas Anderson , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [REPOST PATCH 0/4] usb: dwc2: Turn on uframe sched everywhere Date: Thu, 26 Jul 2018 13:07:26 -0700 Message-Id: <20180726200730.18290-1-dianders@chromium.org> X-Mailer: git-send-email 2.18.0.345.g5c9ce644c3-goog MIME-Version: 1.0 Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP While looking at a dwc2 recently, I noticed that some platforms still have the uframe scheduler off. As far as I know, nothing good can come out of having the uframe scheduler off. Let's turn it on everywhere. Assuming this all works out then some time in the future we can gut all the old code that handles the old non-uframe scheduler and make everything simpler. This is a repost of the original "RFT" (request for testing) series I posted a few weeks ago but without the "RFT" prefix. Two of the patches in the series now have "Tested-by:" tags. Since there should be nothing platform specific about the uFrame scheduler presumably this should mean we're good to go? Specificaly note that in at least one of the "Tested-by" reports this patch caused a notable improvement. In response to the original RFT, some notes about testing this: - In general, try to have lots of things plugged in. - Plug many different keyboards / mice in. See if keys are dropped / mouse is jerky. - Try USB audio (ideally full speed, not high speed). How is the audio? - If you're brave, try a USB webcam. How is the video? ...maybe try including patches from crbug.com/820961 too. Douglas Anderson (4): usb: dwc2: Turn on uframe_sched on "bcm" platforms usb: dwc2: Turn on uframe_sched on "his" platforms usb: dwc2: Turn on uframe_sched on "amlogic" platforms usb: dwc2: Turn on uframe_sched on "stm32f4x9_fsotg" platforms drivers/usb/dwc2/params.c | 4 ---- 1 file changed, 4 deletions(-) Reviewed-by: Minas Harutyunyan