| Message ID | 20181022054031.14027-1-peter.chen@nxp.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | usb: chipidea: imx: add HSIC support | expand |
Hi Peter, On 22.10.18 07:42, Peter Chen wrote: > Most of NXP (Freescale) i.mx USB part has HSIC support, in this series, > we add support for them, it should cover all imx6 and imx7d SoC. > > Changes for v2: > - Compile error reported by kbuild robot [Patch 2/4] > - Comment from Frieder Schrempf about code structure [Patch 2/4] > - Comment from Fabio about adding example for pinctrl [Patch 4/4] > > Peter Chen (4): > usb: chipidea: add flag for imx hsic implementation > usb: chipidea: imx: add HSIC support > usb: chipidea: host: override ehci->hub_control > doc: usb: ci-hdrc-usb2: Add pinctrl properties for HSIC pin groups > > .../devicetree/bindings/usb/ci-hdrc-usb2.txt | 1 + > drivers/usb/chipidea/ci_hdrc_imx.c | 140 ++++++++++++++++++--- > drivers/usb/chipidea/ci_hdrc_imx.h | 9 +- > drivers/usb/chipidea/host.c | 98 +++++++++++++++ > drivers/usb/chipidea/usbmisc_imx.c | 130 +++++++++++++++++++ > include/linux/usb/chipidea.h | 3 + > 6 files changed, 362 insertions(+), 19 deletions(-) As I already posted when I was testing v1 last week, there is a problem with auto suspend with my LAN9730 chip. I thought it was a problem with the smsc95xx/usbnet driver, but I'm not so sure anymore. So I'd like to figure out if it has something to do with the HSIC patches. I hope to find some time to do some more debugging soon. When this is sorted I will append my R-b, T-b tags. Regards, Frieder
> As I already posted when I was testing v1 last week, there is a problem with auto > suspend with my LAN9730 chip. I thought it was a problem with the > smsc95xx/usbnet driver, but I'm not so sure anymore. > > So I'd like to figure out if it has something to do with the HSIC patches. I hope to > find some time to do some more debugging soon. > When this is sorted I will append my R-b, T-b tags. > Thanks, Frieder Peter
Hi Peter, On 23.10.18 08:33, Peter Chen wrote: > >> As I already posted when I was testing v1 last week, there is a problem with auto >> suspend with my LAN9730 chip. I thought it was a problem with the >> smsc95xx/usbnet driver, but I'm not so sure anymore. >> >> So I'd like to figure out if it has something to do with the HSIC patches. I hope to >> find some time to do some more debugging soon. >> When this is sorted I will append my R-b, T-b tags. >> > Thanks, Frieder The problem is in the smsc95xx driver and I already sent a fix for it. So the HSIC patches are ok. I have some more small suggestions for the v2 patches, I will send separately. Could you send a v3, then I will add my R-b and T-b tags to the whole series? Thanks, Frieder
Hi Peter, On 05.11.18 09:52, Frieder Schrempf wrote: > Hi Peter, > > On 23.10.18 08:33, Peter Chen wrote: >>> As I already posted when I was testing v1 last week, there is a >>> problem with auto >>> suspend with my LAN9730 chip. I thought it was a problem with the >>> smsc95xx/usbnet driver, but I'm not so sure anymore. >>> >>> So I'd like to figure out if it has something to do with the HSIC >>> patches. I hope to >>> find some time to do some more debugging soon. >>> When this is sorted I will append my R-b, T-b tags. >>> >> Thanks, Frieder > > The problem is in the smsc95xx driver and I already sent a fix for it. > So the HSIC patches are ok. > > I have some more small suggestions for the v2 patches, I will send > separately. Could you send a v3, then I will add my R-b and T-b tags to > the whole series? Did you have some time to prepare v3 so we can move on? Also could you please have a quick look add the devicetree changes: https://patchwork.kernel.org/patch/10646853/ Thanks a lot, Frieder
> > > > On 23.10.18 08:33, Peter Chen wrote: > >>> As I already posted when I was testing v1 last week, there is a > >>> problem with auto suspend with my LAN9730 chip. I thought it was a > >>> problem with the smsc95xx/usbnet driver, but I'm not so sure > >>> anymore. > >>> > >>> So I'd like to figure out if it has something to do with the HSIC > >>> patches. I hope to find some time to do some more debugging soon. > >>> When this is sorted I will append my R-b, T-b tags. > >>> > >> Thanks, Frieder > > > > The problem is in the smsc95xx driver and I already sent a fix for it. > > So the HSIC patches are ok. > > > > I have some more small suggestions for the v2 patches, I will send > > separately. Could you send a v3, then I will add my R-b and T-b tags > > to the whole series? > > Did you have some time to prepare v3 so we can move on? > Also could you please have a quick look add the devicetree changes: > https://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpatchwork. > kernel.org%2Fpatch%2F10646853%2F&data=02%7C01%7Cpeter.chen%40nx > p.com%7Cd99fc15773814491afef08d64dfa0d0e%7C686ea1d3bc2b4c6fa92cd99c5 > c301635%7C0%7C0%7C636782133691575095&sdata=369DV9jAv17iBiZVjErI > XWRp63lJKueLBkgWPOilTTw%3D&reserved=0 > Hi Schrempf, I am afraid I am a little busy with some other USB tasks, I will send v3 at next week. Peter