mbox series

[0/9] USB: serial: fix initial-termios handling

Message ID 20190421122154.26465-1-johan@kernel.org (mailing list archive)
Headers show
Series USB: serial: fix initial-termios handling | expand

Message

Johan Hovold April 21, 2019, 12:21 p.m. UTC 
A few drivers override the default initial termios settings provided by
USB serial core, but due to a long-standing bug, the terminal settings
were being reset on every (first) open rather than on first use after
probe as intended.

This series fixes the bug and cleans up the various init_termios
implementations somewhat.

Johan


Johan Hovold (9):
  USB: serial: fix initial-termios handling
  USB: serial: ark3116: drop redundant init_termios
  USB: serial: cypress_m8: drop unused driver data flag
  USB: serial: cypress_m8: drop unused termios
  USB: serial: cypress_m8: clean up initial-termios handling
  USB: serial: iuu_phoenix: drop bogus initial cflag
  USB: serial: iuu_phoenix: simplify init_termios
  USB: serial: oti6858: simplify init_termios
  USB: serial: spcp8x5: simplify init_termios

 drivers/usb/serial/ark3116.c     | 11 -------
 drivers/usb/serial/cypress_m8.c  | 49 ++++++--------------------------
 drivers/usb/serial/iuu_phoenix.c |  4 +--
 drivers/usb/serial/oti6858.c     |  5 +---
 drivers/usb/serial/spcp8x5.c     |  5 +---
 drivers/usb/serial/usb-serial.c  | 11 ++++---
 6 files changed, 18 insertions(+), 67 deletions(-)

Comments

Johan Hovold April 26, 2019, 6:40 a.m. UTC | #1 
On Sun, Apr 21, 2019 at 02:21:45PM +0200, Johan Hovold wrote:
> A few drivers override the default initial termios settings provided by
> USB serial core, but due to a long-standing bug, the terminal settings
> were being reset on every (first) open rather than on first use after
> probe as intended.
> 
> This series fixes the bug and cleans up the various init_termios
> implementations somewhat.

> Johan Hovold (9):
>   USB: serial: fix initial-termios handling
>   USB: serial: ark3116: drop redundant init_termios
>   USB: serial: cypress_m8: drop unused driver data flag
>   USB: serial: cypress_m8: drop unused termios
>   USB: serial: cypress_m8: clean up initial-termios handling
>   USB: serial: iuu_phoenix: drop bogus initial cflag
>   USB: serial: iuu_phoenix: simplify init_termios
>   USB: serial: oti6858: simplify init_termios
>   USB: serial: spcp8x5: simplify init_termios

I have applied these now.

Johan