mbox series

[0/7] Input: fix USB alsetting bugs

Message ID 20191210113737.4016-1-johan@kernel.org (mailing list archive)
Headers show
Series Input: fix USB alsetting bugs | expand

Message

Johan Hovold Dec. 10, 2019, 11:37 a.m. UTC 
We had quite a few driver using the first alternate setting instead of
the current one when doing descriptor sanity checks. This is mostly an
issue on kernels with panic_on_warn set due to a WARN() in
usb_submit_urn(). Since we've started backporting such fixes (e.g. as
reported by syzbot), I've marked these for stable as well.

Included are also a couple of related clean ups to prevent future
issues.

Johan


Johan Hovold (7):
  Input: pegasus_notetaker: fix endpoint sanity check
  Input: aiptek: fix endpoint sanity check
  Input: aiptek: use descriptors of current altsetting
  Input: gtco: fix endpoint sanity check
  Input: gtco: fix extra-descriptor debug message
  Input: gtco: drop redundant variable reinit
  Input: sur40: fix interface sanity checks

 drivers/input/tablet/aiptek.c            |  8 ++++----
 drivers/input/tablet/gtco.c              | 13 ++++---------
 drivers/input/tablet/pegasus_notetaker.c |  2 +-
 drivers/input/touchscreen/sur40.c        |  2 +-
 4 files changed, 10 insertions(+), 15 deletions(-)

Comments

Vladis Dronov Dec. 12, 2019, 3:25 p.m. UTC | #1 
Hello,

On 10.12.19 12:37, Johan Hovold wrote:

> We had quite a few driver using the first alternate setting instead of
> the current one when doing descriptor sanity checks. This is mostly an
> issue on kernels with panic_on_warn set due to a WARN() in
> usb_submit_urn(). Since we've started backporting such fixes (e.g. as
> reported by syzbot), I've marked these for stable as well.
> 
> Included are also a couple of related clean ups to prevent future
> issues.

For the series:

Acked-by: Vladis Dronov <vdronov@redhat.com>

Best regards,
Vladis Dronov | Red Hat, Inc. | The Core Kernel | Senior Software Engineer
Dmitry Torokhov Jan. 10, 2020, 10:43 p.m. UTC | #2 
On Thu, Dec 12, 2019 at 04:25:18PM +0100, Vladis Dronov wrote:
> Hello,
> 
> On 10.12.19 12:37, Johan Hovold wrote:
> 
> > We had quite a few driver using the first alternate setting instead of
> > the current one when doing descriptor sanity checks. This is mostly an
> > issue on kernels with panic_on_warn set due to a WARN() in
> > usb_submit_urn(). Since we've started backporting such fixes (e.g. as
> > reported by syzbot), I've marked these for stable as well.
> > 
> > Included are also a couple of related clean ups to prevent future
> > issues.
> 
> For the series:
> 
> Acked-by: Vladis Dronov <vdronov@redhat.com>

Applied the lot, thank you.