| Message ID | 20200430184924.31690-1-mani@kernel.org (mailing list archive) |
|---|---|
| Headers | show |
| Series | Add support for MaxLinear/Exar USB to serial converters | expand |
Hi, On Fri, May 01, 2020 at 12:19:22AM +0530, mani@kernel.org wrote: > From: Manivannan Sadhasivam <mani@kernel.org> > > Hello, > > This series adds support for MaxLinear/Exar USB to serial converters. > This driver only supports XR21V141X series but it can easily be extended > to other series in future. > > This driver is inspired from the initial one submitted by Patong Yang: > > https://patchwork.kernel.org/patch/10543261/ > > While the initial driver was a custom tty USB driver exposing whole > new serial interface ttyXRUSBn, this version is completely based on USB > serial core thus exposing the interfaces as ttyUSBn. This will avoid > the overhead of exposing a new USB serial interface which the userspace > tools are unaware of. > > This series has been tested with Hikey970 board hosting XR21V141X chip. > Any update on this series? Thanks, Mani > Thanks, > Mani > > Changes in v3: > > * Dropped the check for PID and also the reg_width property. > > Changes in v2: > > * Dropped the code related to handling variable register size. It's all u8 now. > * Dropped the header file and moved the contents to driver itself. > * Added Linus's reviewed-by tag for gpiochip patch. > * Added PID to gpiochip label > * Dropped gpiochip for interface 0 > > Manivannan Sadhasivam (2): > usb: serial: Add MaxLinear/Exar USB to Serial driver > usb: serial: xr_serial: Add gpiochip support > > drivers/usb/serial/Kconfig | 9 + > drivers/usb/serial/Makefile | 1 + > drivers/usb/serial/xr_serial.c | 821 +++++++++++++++++++++++++++++++++ > 3 files changed, 831 insertions(+) > create mode 100644 drivers/usb/serial/xr_serial.c > > -- > 2.17.1 >
Em Fri, 1 May 2020 00:19:22 +0530 mani@kernel.org escreveu: > From: Manivannan Sadhasivam <mani@kernel.org> > > Hello, > > This series adds support for MaxLinear/Exar USB to serial converters. > This driver only supports XR21V141X series but it can easily be extended > to other series in future. > > This driver is inspired from the initial one submitted by Patong Yang: > > https://patchwork.kernel.org/patch/10543261/ > > While the initial driver was a custom tty USB driver exposing whole > new serial interface ttyXRUSBn, this version is completely based on USB > serial core thus exposing the interfaces as ttyUSBn. This will avoid > the overhead of exposing a new USB serial interface which the userspace > tools are unaware of. Hmm... I guess you also need the enclosed patch, to ensure that cdc_acm won't try to hijack it, when the Kernel is built with both drivers. Thanks, Mauro [PATCH] usb: cdc-acm: ignore Exar XR21V141X when serial driver is built The RTS/CTS line discipline for this device doesn't follow the standard. So, in order to properly support TX, a separate driver is needed. Ensure that cdc_acm will ignore it during probe time, if the Kernel is built with support for it. Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org> diff --git a/drivers/usb/class/cdc-acm.c b/drivers/usb/class/cdc-acm.c index ded8d93834ca..f87288834ded 100644 --- a/drivers/usb/class/cdc-acm.c +++ b/drivers/usb/class/cdc-acm.c @@ -1889,7 +1889,11 @@ static const struct usb_device_id acm_ids[] = { .driver_info = IGNORE_DEVICE, }, #endif - +#if IS_ENABLED(CONFIG_USB_SERIAL_XR) + { USB_DEVICE(0x04e2, 0x1410), /* XR21V141X uses a different rts/cts discipline */ + .driver_info = IGNORE_DEVICE, + }, +#endif /*Samsung phone in firmware update mode */ { USB_DEVICE(0x04e8, 0x685d), .driver_info = IGNORE_DEVICE,
Em Fri, 1 May 2020 00:19:22 +0530 mani@kernel.org escreveu: > From: Manivannan Sadhasivam <mani@kernel.org> > > Hello, > > This series adds support for MaxLinear/Exar USB to serial converters. > This driver only supports XR21V141X series but it can easily be extended > to other series in future. > > This driver is inspired from the initial one submitted by Patong Yang: > > https://patchwork.kernel.org/patch/10543261/ > > While the initial driver was a custom tty USB driver exposing whole > new serial interface ttyXRUSBn, this version is completely based on USB > serial core thus exposing the interfaces as ttyUSBn. This will avoid > the overhead of exposing a new USB serial interface which the userspace > tools are unaware of. > > This series has been tested with Hikey970 board hosting XR21V141X chip. I applied this series on the top of Kernel 5.7 (x86_64), and I'm using it to access the Hikey970 console. Seems to be working fine. So, feel free to add: Tested-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org> Thanks, Mauro
Hi Mauro, On Fri, Jun 05, 2020 at 01:13:55PM +0200, Mauro Carvalho Chehab wrote: > Em Fri, 1 May 2020 00:19:22 +0530 > mani@kernel.org escreveu: > > > From: Manivannan Sadhasivam <mani@kernel.org> > > > > Hello, > > > > This series adds support for MaxLinear/Exar USB to serial converters. > > This driver only supports XR21V141X series but it can easily be extended > > to other series in future. > > > > This driver is inspired from the initial one submitted by Patong Yang: > > > > https://patchwork.kernel.org/patch/10543261/ > > > > While the initial driver was a custom tty USB driver exposing whole > > new serial interface ttyXRUSBn, this version is completely based on USB > > serial core thus exposing the interfaces as ttyUSBn. This will avoid > > the overhead of exposing a new USB serial interface which the userspace > > tools are unaware of. > > Hmm... I guess you also need the enclosed patch, to ensure that cdc_acm > won't try to hijack it, when the Kernel is built with both drivers. > Ah right. I will include this patch in next iteration. Many thanks! Regards, Mani > Thanks, > Mauro > > [PATCH] usb: cdc-acm: ignore Exar XR21V141X when serial driver is > built > > The RTS/CTS line discipline for this device doesn't follow > the standard. So, in order to properly support TX, a separate > driver is needed. > > Ensure that cdc_acm will ignore it during probe time, if the > Kernel is built with support for it. > > Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org> > > diff --git a/drivers/usb/class/cdc-acm.c b/drivers/usb/class/cdc-acm.c > index ded8d93834ca..f87288834ded 100644 > --- a/drivers/usb/class/cdc-acm.c > +++ b/drivers/usb/class/cdc-acm.c > @@ -1889,7 +1889,11 @@ static const struct usb_device_id acm_ids[] = { > .driver_info = IGNORE_DEVICE, > }, > #endif > - > +#if IS_ENABLED(CONFIG_USB_SERIAL_XR) > + { USB_DEVICE(0x04e2, 0x1410), /* XR21V141X uses a different rts/cts discipline */ > + .driver_info = IGNORE_DEVICE, > + }, > +#endif > /*Samsung phone in firmware update mode */ > { USB_DEVICE(0x04e8, 0x685d), > .driver_info = IGNORE_DEVICE, >
From: Manivannan Sadhasivam <mani@kernel.org> Hello, This series adds support for MaxLinear/Exar USB to serial converters. This driver only supports XR21V141X series but it can easily be extended to other series in future. This driver is inspired from the initial one submitted by Patong Yang: https://patchwork.kernel.org/patch/10543261/ While the initial driver was a custom tty USB driver exposing whole new serial interface ttyXRUSBn, this version is completely based on USB serial core thus exposing the interfaces as ttyUSBn. This will avoid the overhead of exposing a new USB serial interface which the userspace tools are unaware of. This series has been tested with Hikey970 board hosting XR21V141X chip. Thanks, Mani Changes in v3: * Dropped the check for PID and also the reg_width property. Changes in v2: * Dropped the code related to handling variable register size. It's all u8 now. * Dropped the header file and moved the contents to driver itself. * Added Linus's reviewed-by tag for gpiochip patch. * Added PID to gpiochip label * Dropped gpiochip for interface 0 Manivannan Sadhasivam (2): usb: serial: Add MaxLinear/Exar USB to Serial driver usb: serial: xr_serial: Add gpiochip support drivers/usb/serial/Kconfig | 9 + drivers/usb/serial/Makefile | 1 + drivers/usb/serial/xr_serial.c | 821 +++++++++++++++++++++++++++++++++ 3 files changed, 831 insertions(+) create mode 100644 drivers/usb/serial/xr_serial.c