mbox series

[0/1] Add USB role switch to tps6598x

Message ID 20200507124556.1774311-1-bryan.odonoghue@linaro.org (mailing list archive)
Headers show
Series Add USB role switch to tps6598x | expand

Message

Bryan O'Donoghue May 7, 2020, 12:45 p.m. UTC 
This patch - adds USB role switching to the TI TPS6598x. It has been tested
out with a ChipIdea controller inside a Qualcomm MSM8939.

Right now you need to have configured the TPS firmware with the TI
configuration tool so that the chip knows if it should initiate or accept
data and power role swaps.

https://www.ti.com/lit/an/slva843a/slva843a.pdf

Heikki mentioned that on the ACPI systems the firmware had been
pre-configured to do data/power role swaps. On the hardware I have this is
the case also, which is why I did't invest more time in adding DT bindings
to control data/power roles that I don't need or necessarily support with
the reference hardware.

As-is this code will do role-swappping nicely for me, and I think should be
safe on existing ACPI systems.

Bryan O'Donoghue (1):
  usb: typec: tps6598x: Add USB role switching logic

 drivers/usb/typec/tps6598x.c | 56 +++++++++++++++++++++++++++++++-----
 1 file changed, 49 insertions(+), 7 deletions(-)

Comments

Andy Shevchenko May 7, 2020, 1:41 p.m. UTC | #1 
On Thu, May 07, 2020 at 01:45:55PM +0100, Bryan O'Donoghue wrote:
> This patch - adds USB role switching to the TI TPS6598x. It has been tested
> out with a ChipIdea controller inside a Qualcomm MSM8939.
> 
> Right now you need to have configured the TPS firmware with the TI
> configuration tool so that the chip knows if it should initiate or accept
> data and power role swaps.
> 
> https://www.ti.com/lit/an/slva843a/slva843a.pdf

Can you include that in the patch under DocLink tag with some background info?
Bryan O'Donoghue May 7, 2020, 2:15 p.m. UTC | #2 
On 07/05/2020 14:41, Andy Shevchenko wrote:
> On Thu, May 07, 2020 at 01:45:55PM +0100, Bryan O'Donoghue wrote:
>> This patch - adds USB role switching to the TI TPS6598x. It has been tested
>> out with a ChipIdea controller inside a Qualcomm MSM8939.
>>
>> Right now you need to have configured the TPS firmware with the TI
>> configuration tool so that the chip knows if it should initiate or accept
>> data and power role swaps.
>>
>> https://www.ti.com/lit/an/slva843a/slva843a.pdf
> 
> Can you include that in the patch under DocLink tag with some background info?
> 

yep, np.

thanks for the reivews