| Message ID | 20200607160809.20192-1-mani@kernel.org (mailing list archive) |
|---|---|
| Headers | show |
| Series | Add support for MaxLinear/Exar USB to serial converters | expand |
On Sun, Jun 07, 2020 at 09:38:06PM +0530, Manivannan Sadhasivam wrote: > Hello, > > This series adds support for MaxLinear/Exar USB to serial converters. > This driver only supports XR21V141X series but it can easily be extended > to other series in future. > > This driver is inspired from the initial one submitted by Patong Yang: > > https://patchwork.kernel.org/patch/10543261/ > > While the initial driver was a custom tty USB driver exposing whole > new serial interface ttyXRUSBn, this version is completely based on USB > serial core thus exposing the interfaces as ttyUSBn. This will avoid > the overhead of exposing a new USB serial interface which the userspace > tools are unaware of. > > This series has been tested with Hikey970 board hosting XR21V141X chip. > Gentle ping on this series! Thanks, Mani > Thanks, > Mani > > Changes in v4: > > * Multiple improvements based on Johan's review. Noticeable ones are: > - Now the driver claims both control and data interfaces but only registers > tty device for data interface. > - GPIO pin status is now shared between the console and gpiolib > implementations. This is done to avoid changing the lines spuriously. > - A separate port_open flag is added to reject GPIO requests while the tty > port is open. > - Removed padding PID to gpio device. > * Added Greg and Mauro's review and tested tags. > * Included a patch from Mauro to avoid the CDC-ACM driver to claim this device > when this driver is built. > > Changes in v3: > > * Dropped the check for PID and also the reg_width property. > > Changes in v2: > > * Dropped the code related to handling variable register size. It's all u8 now. > * Dropped the header file and moved the contents to driver itself. > * Added Linus's reviewed-by tag for gpiochip patch. > * Added PID to gpiochip label > * Dropped gpiochip for interface 0 > > Manivannan Sadhasivam (2): > usb: serial: Add MaxLinear/Exar USB to Serial driver > usb: serial: xr_serial: Add gpiochip support > > Mauro Carvalho Chehab (1): > usb: cdc-acm: Ignore Exar XR21V141X when serial driver is built > > drivers/usb/class/cdc-acm.c | 6 + > drivers/usb/serial/Kconfig | 9 + > drivers/usb/serial/Makefile | 1 + > drivers/usb/serial/xr_serial.c | 857 +++++++++++++++++++++++++++++++++ > 4 files changed, 873 insertions(+) > create mode 100644 drivers/usb/serial/xr_serial.c > > -- > 2.17.1 >
On Fri, Jun 26, 2020 at 08:01:36PM +0530, Manivannan Sadhasivam wrote: > On Sun, Jun 07, 2020 at 09:38:06PM +0530, Manivannan Sadhasivam wrote: > > Hello, > > > > This series adds support for MaxLinear/Exar USB to serial converters. > > This driver only supports XR21V141X series but it can easily be extended > > to other series in future. > > > > This driver is inspired from the initial one submitted by Patong Yang: > > > > https://patchwork.kernel.org/patch/10543261/ > > > > While the initial driver was a custom tty USB driver exposing whole > > new serial interface ttyXRUSBn, this version is completely based on USB > > serial core thus exposing the interfaces as ttyUSBn. This will avoid > > the overhead of exposing a new USB serial interface which the userspace > > tools are unaware of. > > > > This series has been tested with Hikey970 board hosting XR21V141X chip. > > > > Gentle ping on this series! You sending this in reply to your superseded v4. Please make sure to always increment the revision number when updating a series, including when changing authorship. Johan
Hello, This series adds support for MaxLinear/Exar USB to serial converters. This driver only supports XR21V141X series but it can easily be extended to other series in future. This driver is inspired from the initial one submitted by Patong Yang: https://patchwork.kernel.org/patch/10543261/ While the initial driver was a custom tty USB driver exposing whole new serial interface ttyXRUSBn, this version is completely based on USB serial core thus exposing the interfaces as ttyUSBn. This will avoid the overhead of exposing a new USB serial interface which the userspace tools are unaware of. This series has been tested with Hikey970 board hosting XR21V141X chip. Thanks, Mani Changes in v4: * Multiple improvements based on Johan's review. Noticeable ones are: - Now the driver claims both control and data interfaces but only registers tty device for data interface. - GPIO pin status is now shared between the console and gpiolib implementations. This is done to avoid changing the lines spuriously. - A separate port_open flag is added to reject GPIO requests while the tty port is open. - Removed padding PID to gpio device. * Added Greg and Mauro's review and tested tags. * Included a patch from Mauro to avoid the CDC-ACM driver to claim this device when this driver is built. Changes in v3: * Dropped the check for PID and also the reg_width property. Changes in v2: * Dropped the code related to handling variable register size. It's all u8 now. * Dropped the header file and moved the contents to driver itself. * Added Linus's reviewed-by tag for gpiochip patch. * Added PID to gpiochip label * Dropped gpiochip for interface 0 Manivannan Sadhasivam (2): usb: serial: Add MaxLinear/Exar USB to Serial driver usb: serial: xr_serial: Add gpiochip support Mauro Carvalho Chehab (1): usb: cdc-acm: Ignore Exar XR21V141X when serial driver is built drivers/usb/class/cdc-acm.c | 6 + drivers/usb/serial/Kconfig | 9 + drivers/usb/serial/Makefile | 1 + drivers/usb/serial/xr_serial.c | 857 +++++++++++++++++++++++++++++++++ 4 files changed, 873 insertions(+) create mode 100644 drivers/usb/serial/xr_serial.c