mbox series

[00/15] always use netdev_tx_t for xmit()'s return type

Message ID 20200628195337.75889-1-luc.vanoostenryck@gmail.com (mailing list archive)
Headers show
Series always use netdev_tx_t for xmit()'s return type | expand

Message

Luc Van Oostenryck June 28, 2020, 7:53 p.m. UTC
The ndo_start_xmit() methods should return a 'netdev_tx_t', not
an int, and so should return NETDEV_TX_OK, not 0.
The patches in the series fix most of the remaning drivers and
subsystems (those included in allyesconfig on x86).


Luc Van Oostenryck (15):
  cail,hsi: fix cfhsi_xmit()'s return type
  caif: fix caif_xmit()'s return type
  caif: fix cfspi_xmit()'s return type
  caif: fix cfv_netdev_tx()'s return type
  net: aquantia: fix aq_ndev_start_xmit()'s return type
  net: arc_emac: fix arc_emac_tx()'s return type
  net: nb8800: fix nb8800_xmit()'s return type
  net: nfp: fix nfp_net_tx()'s return type
  net: pch_gbe: fix pch_gbe_xmit_frame()'s return type
  net: dwc-xlgmac: fix xlgmac_xmit()'s return type
  net: plip: fix plip_tx_packet()'s return type
  usbnet: ipheth: fix ipheth_tx()'s return type
  net/hsr: fix hsr_dev_xmit()'s return type
  l2tp: fix l2tp_eth_dev_xmit()'s return type
  cxgb4vf: fix t4vf_eth_xmit()'s return type

 drivers/net/caif/caif_hsi.c                          | 6 +++---
 drivers/net/caif/caif_serial.c                       | 2 +-
 drivers/net/caif/caif_spi.c                          | 4 ++--
 drivers/net/caif/caif_virtio.c                       | 2 +-
 drivers/net/ethernet/aquantia/atlantic/aq_main.c     | 2 +-
 drivers/net/ethernet/arc/emac_main.c                 | 2 +-
 drivers/net/ethernet/aurora/nb8800.c                 | 2 +-
 drivers/net/ethernet/chelsio/cxgb4vf/adapter.h       | 2 +-
 drivers/net/ethernet/chelsio/cxgb4vf/sge.c           | 2 +-
 drivers/net/ethernet/netronome/nfp/nfp_net_common.c  | 2 +-
 drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c | 2 +-
 drivers/net/ethernet/synopsys/dwc-xlgmac-net.c       | 2 +-
 drivers/net/plip/plip.c                              | 4 ++--
 drivers/net/usb/ipheth.c                             | 2 +-
 net/hsr/hsr_device.c                                 | 2 +-
 net/l2tp/l2tp_eth.c                                  | 2 +-
 16 files changed, 20 insertions(+), 20 deletions(-)

Comments

David Miller June 29, 2020, 3:53 a.m. UTC | #1
From: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
Date: Sun, 28 Jun 2020 21:53:22 +0200

> The ndo_start_xmit() methods should return a 'netdev_tx_t', not
> an int, and so should return NETDEV_TX_OK, not 0.
> The patches in the series fix most of the remaning drivers and
> subsystems (those included in allyesconfig on x86).

Series applied, thanks.