mbox series

[0/5] USB: serial: cp210x: add support for line-status events

Message ID 20200713105517.27796-1-johan@kernel.org (mailing list archive)
Headers show
Series USB: serial: cp210x: add support for line-status events | expand

Message

Johan Hovold July 13, 2020, 10:55 a.m. UTC 
This series add supports for line-status events that specifically can be
used to detect parity errors.

The implementation relies on the device's event-insertion mode, which
can also be used to detect line-breaks and modem status changes. But as
this doesn't seem to work as expected on CP2102, support has been left
unimplemented for now.

Included are also a couple of cleanups.

Johan

Changes since RFC [1]:
 - drop sysrq support which relies on break detection
 - use 0xec (instead of 0xff) as escape character

[1] https://lore.kernel.org/r/20200703150104.GE3453@localhost

Johan Hovold (5):
  USB: serial: cp210x: disable interface on errors in open
  USB: serial: cp210x: add support for line-status events
  USB: serial: cp210x: add support for TIOCGICOUNT
  USB: serial: cp210x: drop unnecessary packed attributes
  USB: serial: cp210x: use in-kernel types in port data

 drivers/usb/serial/cp210x.c | 209 ++++++++++++++++++++++++++++++++++--
 1 file changed, 201 insertions(+), 8 deletions(-)

Comments

Greg Kroah-Hartman July 13, 2020, 1:41 p.m. UTC | #1 
On Mon, Jul 13, 2020 at 12:55:12PM +0200, Johan Hovold wrote:
> This series add supports for line-status events that specifically can be
> used to detect parity errors.
> 
> The implementation relies on the device's event-insertion mode, which
> can also be used to detect line-breaks and modem status changes. But as
> this doesn't seem to work as expected on CP2102, support has been left
> unimplemented for now.
> 
> Included are also a couple of cleanups.
> 
> Johan
> 
> Changes since RFC [1]:
>  - drop sysrq support which relies on break detection
>  - use 0xec (instead of 0xff) as escape character
> 
> [1] https://lore.kernel.org/r/20200703150104.GE3453@localhost


Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Johan Hovold July 14, 2020, 9:55 a.m. UTC | #2 
On Mon, Jul 13, 2020 at 03:41:29PM +0200, Greg Kroah-Hartman wrote:
> On Mon, Jul 13, 2020 at 12:55:12PM +0200, Johan Hovold wrote:
> > This series add supports for line-status events that specifically can be
> > used to detect parity errors.
> > 
> > The implementation relies on the device's event-insertion mode, which
> > can also be used to detect line-breaks and modem status changes. But as
> > this doesn't seem to work as expected on CP2102, support has been left
> > unimplemented for now.
> > 
> > Included are also a couple of cleanups.
> > 
> > Johan
> > 
> > Changes since RFC [1]:
> >  - drop sysrq support which relies on break detection
> >  - use 0xec (instead of 0xff) as escape character
> > 
> > [1] https://lore.kernel.org/r/20200703150104.GE3453@localhost
> 
> 
> Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

Thanks. Now applied.

Johan