From patchwork Fri Mar 26 14:34:32 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 12166833 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6663BC433E2 for ; Fri, 26 Mar 2021 14:35:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3A3EC61A24 for ; Fri, 26 Mar 2021 14:35:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230226AbhCZOfO (ORCPT ); Fri, 26 Mar 2021 10:35:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52592 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229984AbhCZOfD (ORCPT ); Fri, 26 Mar 2021 10:35:03 -0400 Received: from mail-wm1-x331.google.com (mail-wm1-x331.google.com [IPv6:2a00:1450:4864:20::331]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AC3C2C0613AA for ; Fri, 26 Mar 2021 07:35:02 -0700 (PDT) Received: by mail-wm1-x331.google.com with SMTP id p19so3115821wmq.1 for ; Fri, 26 Mar 2021 07:35:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=VoFNqvJqV3TdL84vFoklC/P+s5SxY+mp4X8TTiNgMtE=; b=P+VsgdwqxC7S+r3aEF02+Phf4siu0/ukHmkddSss85wkzBu4EICPyZs9fP4AJk7kdQ a5dW6dH70JwYO457Ljil7DbwsUtsiPgUC1cMner3cAcl4d3LlgxctQIOREK/EMxLUV8F q54mo9DrRKtujvY75fE8ck0i45ZCiT0WTzJ/DSCCjOOggIX97lR/7mCEjPO7bFzSGPwD qPd+6jvSgAZG2KTUf0sbZVGUUUFLu3eCBc+TbxiPuO09l8pI8Ug4ZrgnfaZniN+UZ0Z6 4G9n6eLtW0aHwoxyD6JuqeqHKz6R/GPtIksun4/V53szdCuUiSdL6rlV+Ri/BAgTJrjP pP0g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=VoFNqvJqV3TdL84vFoklC/P+s5SxY+mp4X8TTiNgMtE=; b=ZlPmH/ZnQShEqe67/+tS1FIecqA8g6J9p2Hie02t0f/llBVci6adeY3WJt+FCVdw9B d2Mk2JmXyFT621EUi6FDjSE9mf075PA7czVlOkNNGDzw7/AGsf4Z8xiDMuuF2XRamx9C ckmryfkTjo1eCbSWk+lgzsmi8mkAfkRCe0jFvOTCu3w6K+SHw+DXBKLpyYcuEZnVZQ+9 GWd8ntMLRly0n7zWBVzeAr6o1NM9D2b7J6NhUIeevUpW/B9KWfJA6D9SijYeOzUvNiEd 6Fn72Vt5dDxgZEdtQUoQbccaVLc8yWTxkpWVVWH92pV/CY10VuKhJ9z5tzupnaM7hZDK s/WQ== X-Gm-Message-State: AOAM533+0S6n4TB1N5ffnIy12rEksAFU/lSOkEsRQpNTTAhcjMqdYpmX mVfGXE5RUKa+1hmVLhhVg5f6Gw== X-Google-Smtp-Source: ABdhPJwVQ28g1uJ1l+3b8N6u3arMMfkW6TtopkB+1sfuYd5LjRqBrN12fvh40SnvFHqZ/sewwpeOGw== X-Received: by 2002:a1c:6a05:: with SMTP id f5mr13383680wmc.184.1616769301335; Fri, 26 Mar 2021 07:35:01 -0700 (PDT) Received: from dell.default ([91.110.221.194]) by smtp.gmail.com with ESMTPSA id j26sm12878225wrh.57.2021.03.26.07.34.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 26 Mar 2021 07:35:00 -0700 (PDT) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Alexandre Torgue , Anssi Hannula , Benjamin Tissoires , =?utf-8?q?Bruno_Pr?= =?utf-8?q?=C3=A9mont?= , =?utf-8?q?Christian_K?= =?utf-8?q?=C3=B6nig?= , Daniel Drubin , Dario Pagani , dri-devel@lists.freedesktop.org, Henrik Rydberg , Jiri Kosina , Jonathan Cameron , Kai-Heng Feng , Kim Kuparinen , =?utf-8?q?Krzysztof_Wilczy?= =?utf-8?q?=C5=84ski?= , linaro-mm-sig@lists.linaro.org, linux-arm-kernel@lists.infradead.org, linux-iio@vger.kernel.org, linux-input@vger.kernel.org, linux-media@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-usb@vger.kernel.org, Lopez Casado , "L. Vinyard, Jr" , Masaki Ota , Maxime Coquelin , message to , Michael Haboustak , Rushikesh S Kadam , Srinivas Pandruvada , Sumit Semwal , =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= , Vojtech Pavlik , Zhang Lixu Subject: [RESEND 00/25] Rid W=1 warnings from HID Date: Fri, 26 Mar 2021 14:34:32 +0000 Message-Id: <20210326143458.508959-1-lee.jones@linaro.org> X-Mailer: git-send-email 2.27.0 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org This set is part of a larger effort attempting to clean-up W=1 kernel builds, which are currently overwhelmingly riddled with niggly little warnings. Lee Jones (25): HID: intel-ish-hid: Remove unused variable 'err' HID: ishtp-hid-client: Move variable to where it's actually used HID: intel-ish-hid: pci-ish: Remove unused variable 'ret' HID: intel-ish: Supply some missing param descriptions HID: intel-ish: Fix a naming disparity and a formatting error HID: usbhid: Repair a formatting issue in a struct description HID: intel-ish-hid: Fix a little doc-rot HID: usbhid: hid-pidff: Demote a couple kernel-doc abuses HID: hid-alps: Correct struct misnaming HID: intel-ish-hid: Fix potential copy/paste error HID: hid-core: Fix incorrect function name in header HID: intel-ish-hid: ipc: Correct fw_reset_work_fn() function name in header HID: ishtp-hid-client: Fix incorrect function name report_bad_packet() HID: hid-kye: Fix incorrect function name for kye_tablet_enable() HID: hid-picolcd_core: Remove unused variable 'ret' HID: hid-logitech-hidpp: Fix conformant kernel-doc header and demote abuses HID: hid-uclogic-rdesc: Kernel-doc is for functions and structs HID: hid-thrustmaster: Demote a bunch of kernel-doc abuses HID: hid-uclogic-params: Ensure function names are present and correct in kernel-doc headers HID: hid-sensor-custom: Remove unused variable 'ret' HID: wacom_sys: Demote kernel-doc abuse HID: hid-sensor-hub: Remove unused struct member 'quirks' HID: hid-sensor-hub: Move 'hsdev' description to correct struct definition HID: intel-ish-hid: ishtp-fw-loader: Fix a bunch of formatting issues HID: ishtp-hid-client: Fix 'suggest-attribute=format' compiler warning drivers/hid/hid-alps.c | 2 +- drivers/hid/hid-core.c | 2 +- drivers/hid/hid-kye.c | 2 +- drivers/hid/hid-logitech-hidpp.c | 7 +-- drivers/hid/hid-picolcd_core.c | 5 +-- drivers/hid/hid-sensor-custom.c | 5 +-- drivers/hid/hid-sensor-hub.c | 4 +- drivers/hid/hid-thrustmaster.c | 24 +++++------ drivers/hid/hid-uclogic-params.c | 8 ++-- drivers/hid/hid-uclogic-rdesc.c | 2 +- drivers/hid/intel-ish-hid/ipc/ipc.c | 2 +- drivers/hid/intel-ish-hid/ipc/pci-ish.c | 3 +- drivers/hid/intel-ish-hid/ishtp-fw-loader.c | 45 ++++++++++---------- drivers/hid/intel-ish-hid/ishtp-hid-client.c | 11 +++-- drivers/hid/intel-ish-hid/ishtp-hid.c | 2 +- drivers/hid/intel-ish-hid/ishtp-hid.h | 9 +--- drivers/hid/intel-ish-hid/ishtp/bus.c | 9 +++- drivers/hid/intel-ish-hid/ishtp/client.c | 5 +-- drivers/hid/intel-ish-hid/ishtp/hbm.c | 4 +- drivers/hid/intel-ish-hid/ishtp/ishtp-dev.h | 4 +- drivers/hid/usbhid/hid-pidff.c | 4 +- drivers/hid/usbhid/usbkbd.c | 2 +- drivers/hid/wacom_sys.c | 2 +- include/linux/intel-ish-client-if.h | 8 +++- 24 files changed, 90 insertions(+), 81 deletions(-) Cc: Alexandre Torgue Cc: Anssi Hannula Cc: Benjamin Tissoires Cc: "Bruno Prémont" Cc: "Christian König" Cc: Daniel Drubin Cc: Dario Pagani Cc: dri-devel@lists.freedesktop.org Cc: Henrik Rydberg Cc: Jiri Kosina Cc: Jonathan Cameron Cc: Kai-Heng Feng Cc: Kim Kuparinen Cc: "Krzysztof Wilczyński" Cc: Lee Jones Cc: linaro-mm-sig@lists.linaro.org Cc: linux-arm-kernel@lists.infradead.org Cc: linux-iio@vger.kernel.org Cc: linux-input@vger.kernel.org Cc: linux-media@vger.kernel.org Cc: linux-stm32@st-md-mailman.stormreply.com Cc: linux-usb@vger.kernel.org Cc: Lopez Casado Cc: "L. Vinyard, Jr" Cc: Masaki Ota Cc: Maxime Coquelin Cc: message to Cc: Michael Haboustak Cc: Rushikesh S Kadam Cc: Srinivas Pandruvada Cc: Sumit Semwal Cc: "Uwe Kleine-König" Cc: Vojtech Pavlik Cc: Zhang Lixu