[v2,0/3] Add the support of SVDM Version 2.0 VDOs

Message ID	20210531095737.2258642-1-kyletso@google.com (mailing list archive)
Headers	show Return-Path: <linux-usb-owner@kernel.org> Date: Mon, 31 May 2021 17:57:34 +0800 Message-Id: <20210531095737.2258642-1-kyletso@google.com> Mime-Version: 1.0 Subject: [PATCH v2 0/3] Add the support of SVDM Version 2.0 VDOs From: Kyle Tso <kyletso@google.com> To: linux@roeck-us.net, heikki.krogerus@linux.intel.com, gregkh@linuxfoundation.org, robh+dt@kernel.org Cc: badhri@google.com, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Kyle Tso <kyletso@google.com> Content-Type: text/plain; charset="UTF-8" Precedence: bulk
Series	Add the support of SVDM Version 2.0 VDOs \| expand [v2,0/3] Add the support of SVDM Version 2.0 VDOs [v2,1/3] usb: typec: tcpm: Correct the responses in SVDM Version 2.0 DFP [v2,2/3] dt-bindings: connector: Add PD rev 2.0 VDO definition [v2,3/3] usb: typec: tcpm: Introduce snk_vdo_v1 for SVDM version 1.0

Message ID

20210531095737.2258642-1-kyletso@google.com (mailing list archive)

Headers

Date: Mon, 31 May 2021 17:57:34 +0800
Message-Id: <20210531095737.2258642-1-kyletso@google.com>
Mime-Version: 1.0
Subject: [PATCH v2 0/3] Add the support of SVDM Version 2.0 VDOs
From: Kyle Tso <kyletso@google.com>
To: linux@roeck-us.net, heikki.krogerus@linux.intel.com,
        gregkh@linuxfoundation.org, robh+dt@kernel.org
Cc: badhri@google.com, linux-usb@vger.kernel.org,
        linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
        Kyle Tso <kyletso@google.com>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Series

Add the support of SVDM Version 2.0 VDOs | expand

Message

Kyle Tso May 31, 2021, 9:57 a.m. UTC

Got the Ack by Heikki so I re-examined the patches and found a *stupid*
bug in the patch "usb: typec: tcpm: Introduce snk_vdo_v1 for SVDM
version 1.0" that I separate the "for loop" into two parts, which is not
only necessary but also redundant.

Changes since v1:
usb: typec: tcpm: Correct the responses in SVDM Version 2.0 DFP
- no code change
- add Acked-by tag

dt-bindings: connector: Add PD rev 2.0 VDO definition
- no code change

usb: typec: tcpm: Introduce snk_vdo_v1 for SVDM version 1.0
- merge the assignment to array element 1 into the for loop. No semantic
  code logic change.
- add Acked-by tag


=== v1 cover letter

The patches are primarily for the responses to the Discover Identity
command. This part was changed a lot from PD rev2.0 to PD rev3.0 (now
it's rev3.1 :D). e.g. DFP can respond to Discover Identity command with
ACK in PD rev3.x and the Product Type VDOs are quite different. Given
that tcpm.c moved on to PD rev3.x and PD rev2.0 is still supported, some
changes need to be made to support both PD rev3.x and rev2.0.

usb: typec: tcpm: Correct the responses in SVDM Version 2.0 DFP
- This patch is to unblock the responder ACK to Discover Identity if the
  port is DFP and the SVDM version is 2.0

dt-bindings: connector: Add PD rev 2.0 VDO definition
- similar changes to Commit 2a1673f0f1de ("usb: pd: Reland VDO
  definitions of PD2.0")
  https://lore.kernel.org/linux-usb/20210204005036.1555294-1-kyletso@google.com/
- add a new property sink-vdos-v1 to store the PD rev2.0 VDOs

usb: typec: tcpm: Introduce snk_vdo_v1 for SVDM version 1.0
- populate the legacy VDOs from fwnode
- send these data if the port partner is SVDM Version 1.0

===

Kyle Tso (3):
  usb: typec: tcpm: Correct the responses in SVDM Version 2.0 DFP
  dt-bindings: connector: Add PD rev 2.0 VDO definition
  usb: typec: tcpm: Introduce snk_vdo_v1 for SVDM version 1.0

 .../bindings/connector/usb-connector.yaml     | 15 ++++
 drivers/usb/typec/tcpm/tcpm.c                 | 52 ++++++++++----
 include/dt-bindings/usb/pd.h                  | 69 ++++++++++++++++++-
 3 files changed, 118 insertions(+), 18 deletions(-)