From patchwork Mon May 31 09:57:34 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kyle Tso X-Patchwork-Id: 12289095 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-21.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT, USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B0EBDC47094 for ; Mon, 31 May 2021 09:57:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8E37D61279 for ; Mon, 31 May 2021 09:57:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231138AbhEaJ73 (ORCPT ); Mon, 31 May 2021 05:59:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39452 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231124AbhEaJ72 (ORCPT ); Mon, 31 May 2021 05:59:28 -0400 Received: from mail-qk1-x74a.google.com (mail-qk1-x74a.google.com [IPv6:2607:f8b0:4864:20::74a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 71172C061760 for ; Mon, 31 May 2021 02:57:47 -0700 (PDT) Received: by mail-qk1-x74a.google.com with SMTP id e8-20020a05620a2088b02903a5edeec4d6so9075945qka.11 for ; Mon, 31 May 2021 02:57:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:message-id:mime-version:subject:from:to:cc; bh=8fReuMdCoAcvO7ejaCNc/y44/KE8D3vmhMB7psbwQpI=; b=R0DfqvjhtO+v5AiLIe1ZYXGAIOnQNWFEOS0027cd07uE/o9Z+f4HcdZXOzG24uq5Zw rCPp4KFPiZb5hzVHO0I2Q07l+TAUQDUJ4dC/28sEhxu/6wGr82cx4HSpGshlqFuagyox EgpSiTGyThSGCAEbst7B+uTY4TwWdnW8qhVfRDJ3pPw2c9ok/7lw6863ykpvwrY4btOq Kv8QW3W9bxiYiqypfR4YeJ/QMGSs405Pnp6fT/tG7EcRu72jbY7cEh8Mu3hxJ721Q3Fc bUQJDFFH2GfNZxharCC8fVrpUpaJlDbZ3b7f4AxPgztIez8FnsuPmH/ok4OEH+SgVfjk PAqw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:message-id:mime-version:subject:from:to:cc; bh=8fReuMdCoAcvO7ejaCNc/y44/KE8D3vmhMB7psbwQpI=; b=eAdwOVx8GycBoypB+q5fl0Sr1FitagUrjr6SW+auz7oHGND/xNQPDgwIW1N1/xvXAo ykTgGtnkrUuvfJvY5kAp3owT6T663//tr4RY8vUiuVpNqNsmWeQMJ2Hgrd5pZYtgYClN IDWRXczXIoF69PvbNAJevKSTNMJJEQTpfaK4SNTk5Pp510PhM5Rmxe/x/acGy/rIwry1 rTNN0azO4aIl6TaineozhvdFutPYEPQjnTR3pFmacTQWk7w2lId5tpyLb8t+MNRab9G8 4p3p+j6VRmerL7S+vdl3OwGFDvHjZKdQXbVUbfDifTwTj4wXtCQ35B3rx/HB37tMR8Q9 /9aA== X-Gm-Message-State: AOAM530RHWKX0Ny8w0tOMCzrSy+J4KFnS6dzCtEzWBakQ5zM4uOVmkBS ZiDl+/3fIZcu8k0bqQU/yWf/YsYgTrM+ X-Google-Smtp-Source: ABdhPJzY2fxdQ4i9TFUl47UHxvvNtiHzqOYZ57PKxOkd9YgYfbonMukdmsh4VIMxNqFv0Fah4fqmhG6fdjmA X-Received: from kyletso.ntc.corp.google.com ([2401:fa00:fc:202:1330:7a47:8be2:d9b7]) (user=kyletso job=sendgmr) by 2002:ad4:4b71:: with SMTP id m17mr13311850qvx.45.1622455065173; Mon, 31 May 2021 02:57:45 -0700 (PDT) Date: Mon, 31 May 2021 17:57:34 +0800 Message-Id: <20210531095737.2258642-1-kyletso@google.com> Mime-Version: 1.0 X-Mailer: git-send-email 2.32.0.rc0.204.g9fa02ecfa5-goog Subject: [PATCH v2 0/3] Add the support of SVDM Version 2.0 VDOs From: Kyle Tso To: linux@roeck-us.net, heikki.krogerus@linux.intel.com, gregkh@linuxfoundation.org, robh+dt@kernel.org Cc: badhri@google.com, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Kyle Tso Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org Got the Ack by Heikki so I re-examined the patches and found a *stupid* bug in the patch "usb: typec: tcpm: Introduce snk_vdo_v1 for SVDM version 1.0" that I separate the "for loop" into two parts, which is not only necessary but also redundant. Changes since v1: usb: typec: tcpm: Correct the responses in SVDM Version 2.0 DFP - no code change - add Acked-by tag dt-bindings: connector: Add PD rev 2.0 VDO definition - no code change usb: typec: tcpm: Introduce snk_vdo_v1 for SVDM version 1.0 - merge the assignment to array element 1 into the for loop. No semantic code logic change. - add Acked-by tag === v1 cover letter The patches are primarily for the responses to the Discover Identity command. This part was changed a lot from PD rev2.0 to PD rev3.0 (now it's rev3.1 :D). e.g. DFP can respond to Discover Identity command with ACK in PD rev3.x and the Product Type VDOs are quite different. Given that tcpm.c moved on to PD rev3.x and PD rev2.0 is still supported, some changes need to be made to support both PD rev3.x and rev2.0. usb: typec: tcpm: Correct the responses in SVDM Version 2.0 DFP - This patch is to unblock the responder ACK to Discover Identity if the port is DFP and the SVDM version is 2.0 dt-bindings: connector: Add PD rev 2.0 VDO definition - similar changes to Commit 2a1673f0f1de ("usb: pd: Reland VDO definitions of PD2.0") https://lore.kernel.org/linux-usb/20210204005036.1555294-1-kyletso@google.com/ - add a new property sink-vdos-v1 to store the PD rev2.0 VDOs usb: typec: tcpm: Introduce snk_vdo_v1 for SVDM version 1.0 - populate the legacy VDOs from fwnode - send these data if the port partner is SVDM Version 1.0 === Kyle Tso (3): usb: typec: tcpm: Correct the responses in SVDM Version 2.0 DFP dt-bindings: connector: Add PD rev 2.0 VDO definition usb: typec: tcpm: Introduce snk_vdo_v1 for SVDM version 1.0 .../bindings/connector/usb-connector.yaml | 15 ++++ drivers/usb/typec/tcpm/tcpm.c | 52 ++++++++++---- include/dt-bindings/usb/pd.h | 69 ++++++++++++++++++- 3 files changed, 118 insertions(+), 18 deletions(-)