[v3,0/2] Fix syzkaller bug: hung task in hub_port_init

Message ID	20210813182508.28127-1-mail@anirudhrb.com (mailing list archive)
Headers	show Return-Path: <linux-usb-owner@kernel.org> From: Anirudh Rayabharam <mail@anirudhrb.com> To: valentina.manea.m@gmail.com, shuah@kernel.org, gregkh@linuxfoundation.org Cc: Anirudh Rayabharam <mail@anirudhrb.com>, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kernel-mentees@lists.linuxfoundation.org Subject: [PATCH v3 0/2] Fix syzkaller bug: hung task in hub_port_init Date: Fri, 13 Aug 2021 23:55:06 +0530 Message-Id: <20210813182508.28127-1-mail@anirudhrb.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk
Series	Fix syzkaller bug: hung task in hub_port_init \| expand [v3,0/2] Fix syzkaller bug: hung task in hub_port_init [v3,1/2] usbip: give back URBs for unsent unlink requests during cleanup [v3,2/2] usbip: eliminate duplicate code in vhci_device_unlink_cleanup

Message ID

20210813182508.28127-1-mail@anirudhrb.com (mailing list archive)

Headers

From: Anirudh Rayabharam <mail@anirudhrb.com>
To: valentina.manea.m@gmail.com, shuah@kernel.org,
        gregkh@linuxfoundation.org
Cc: Anirudh Rayabharam <mail@anirudhrb.com>, linux-usb@vger.kernel.org,
        linux-kernel@vger.kernel.org,
        linux-kernel-mentees@lists.linuxfoundation.org
Subject: [PATCH v3 0/2] Fix syzkaller bug: hung task in hub_port_init
Date: Fri, 13 Aug 2021 23:55:06 +0530
Message-Id: <20210813182508.28127-1-mail@anirudhrb.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Precedence: bulk

Series

Fix syzkaller bug: hung task in hub_port_init | expand

Message

Anirudh Rayabharam Aug. 13, 2021, 6:25 p.m. UTC

This series fixes the hung task bug in hub_port_init reported by
syzkaller at:

https://syzkaller.appspot.com/bug?id=08f12df95ae7da69814e64eb5515d5a85ed06b76

The first patch in the series fixes the issue and the second patch does
some refactoring to avoid duplicate code.

Changes in v3:
- Split the patch into two patches
- Remove the convenience wrappers as suggested by Shuah
- Remove the WARN as suggested by Greg

Changes in v2:
Use WARN_ON() instead of BUG() when unlink_list is neither unlink_tx nor
unlink_rx.
v2: https://lore.kernel.org/lkml/20210806181335.2078-1-mail@anirudhrb.com/

v1: https://lore.kernel.org/lkml/20210806164015.25263-1-mail@anirudhrb.com/

Anirudh Rayabharam (2):
  usbip: give back URBs for unsent unlink requests during cleanup
  usbip: eliminate duplicate code in vhci_device_unlink_cleanup

 drivers/usb/usbip/vhci_hcd.c | 31 ++++++++++++++++++-------------
 1 file changed, 18 insertions(+), 13 deletions(-)