mbox series

[0/3] tools: usb: testusb: Fix reported gadget speeds

Message ID 20220708115859.2095714-1-bryan.odonoghue@linaro.org (mailing list archive)
Headers show
Series tools: usb: testusb: Fix reported gadget speeds | expand

Message

Bryan O'Donoghue July 8, 2022, 11:58 a.m. UTC
Using the testusb utility on a qcom platform which supports
super-speed-plus I found that "??" was being reported instead of
super speed or super-plus speed.

This is easily solved by aligning the test tool speeds with
include/uapi/linux/usb/ch9.h::enum usb_device_speed{}

Before:
sudo ./testusb -a -t 0
?? speed	/dev/bus/usb/004/027	0
/dev/bus/usb/004/027 test 0,    0.000004 secs

After:
sudo ./testusb -a -t 0
super-plus speed	/dev/bus/usb/004/027	0
/dev/bus/usb/004/027 test 0,    0.000004 secs

Bryan O'Donoghue (3):
  tools: usb: testusb: Add wireless speed reporting
  tools: usb: testusb: Add super speed reporting
  tools: usb: testusb: Add super-plus speed reporting

 tools/usb/testusb.c | 18 ++++++++++++------
 1 file changed, 12 insertions(+), 6 deletions(-)

Comments

Greg KH July 8, 2022, 12:55 p.m. UTC | #1
On Fri, Jul 08, 2022 at 12:58:56PM +0100, Bryan O'Donoghue wrote:
> Using the testusb utility on a qcom platform which supports
> super-speed-plus I found that "??" was being reported instead of
> super speed or super-plus speed.
> 
> This is easily solved by aligning the test tool speeds with
> include/uapi/linux/usb/ch9.h::enum usb_device_speed{}
> 
> Before:
> sudo ./testusb -a -t 0
> ?? speed	/dev/bus/usb/004/027	0
> /dev/bus/usb/004/027 test 0,    0.000004 secs
> 
> After:
> sudo ./testusb -a -t 0
> super-plus speed	/dev/bus/usb/004/027	0
> /dev/bus/usb/004/027 test 0,    0.000004 secs

Nice, thanks for fixing these, all now queued up.

greg k-h