From patchwork Tue Feb 7 11:05:28 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alexander Stein X-Patchwork-Id: 13131386 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3382BC636CC for ; Tue, 7 Feb 2023 11:05:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231891AbjBGLFq (ORCPT ); Tue, 7 Feb 2023 06:05:46 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34004 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231907AbjBGLFo (ORCPT ); Tue, 7 Feb 2023 06:05:44 -0500 Received: from mx1.tq-group.com (mx1.tq-group.com [93.104.207.81]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 17BBADBDC; Tue, 7 Feb 2023 03:05:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tq-group.com; i=@tq-group.com; q=dns/txt; s=key1; t=1675767943; x=1707303943; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=fXOh6l9nudX6hQdwn8eYhtvO+xZ109uDckra2QaO+SI=; b=qlQhJf1IMKpQRH2b4tgtZwUwuwrJ40cWdyGOeaoflaPIdd2SgM+iCFLR nsFYptyBLddQX5ifBfq1y+k2bm0YP78WsLpPD1aALY0sXIpdO6dW/Mljp L8wQIU3BSFPNlRoUXM1OqnbUkBHjpqatREJFnuG283KS6HNc6yhrcLEG4 67ag/C8TersWWNIZ9oUapY2yOZpDOsNImJmQcR1Jt7BXjzlNLcIyALNBc c8MwtSMyT8+H9kRsHuwKRaCuj8kT/sV7O2ZnzzJdWrMqCn9k9vMWRLdTt DXhBtfznQCfvAKNhlwyf7SLNBXtwMq1TcPDHBtpLxkmxX96OMR28rL8AX w==; X-IronPort-AV: E=Sophos;i="5.97,278,1669071600"; d="scan'208";a="28917148" Received: from unknown (HELO tq-pgp-pr1.tq-net.de) ([192.168.6.15]) by mx1-pgp.tq-group.com with ESMTP; 07 Feb 2023 12:05:41 +0100 Received: from mx1.tq-group.com ([192.168.6.7]) by tq-pgp-pr1.tq-net.de (PGP Universal service); Tue, 07 Feb 2023 12:05:41 +0100 X-PGP-Universal: processed; by tq-pgp-pr1.tq-net.de on Tue, 07 Feb 2023 12:05:41 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tq-group.com; i=@tq-group.com; q=dns/txt; s=key1; t=1675767941; x=1707303941; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=fXOh6l9nudX6hQdwn8eYhtvO+xZ109uDckra2QaO+SI=; b=X00C0+SePsts98wX9cda+PakGEd2IILpSE2otYYjPvoSasgm5/x0tZLs EDH/mxMGG30PsodMlMTqxd8CrCrEpSUymdG4L9Bk1LXHhPe/a+FqD+Zj9 j0lRPRnT84CtuSwiDr+W2Mia+qwGD6nttvss3JZO+ZuV2SJtXtLwBtQSP PQPcFJsEYdeCCKwM6jxjEterPuIZ6YY7rgv44sQUKwkcogUeRYXDy9n9t LuAimCLtS7SzFXgzFnQ6Aj4hKnTe0NPfw3Zmy5wf9/iqtrNRl0Y6LaSfU hxK5x3F47IpzgxQk5bdusIMclq9DQ1AgfMPlEZA0NKdPmzdcHCCi03Ju9 A==; X-IronPort-AV: E=Sophos;i="5.97,278,1669071600"; d="scan'208";a="28917147" Received: from vtuxmail01.tq-net.de ([10.115.0.20]) by mx1.tq-group.com with ESMTP; 07 Feb 2023 12:05:41 +0100 Received: from steina-w.tq-net.de (unknown [10.123.53.21]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by vtuxmail01.tq-net.de (Postfix) with ESMTPSA id 581E6280056; Tue, 7 Feb 2023 12:05:41 +0100 (CET) From: Alexander Stein To: Rob Herring , Frank Rowand , Greg Kroah-Hartman , Alan Stern , Darren Stevens Cc: Alexander Stein , devicetree@vger.kernel.org, linux-usb@vger.kernel.org Subject: [PATCH 0/3] Fix ehci-fsl autoload regression on fsl-mph-dr-of Date: Tue, 7 Feb 2023 12:05:28 +0100 Message-Id: <20230207110531.1060252-1-alexander.stein@ew.tq-group.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org Hi, I noticed on my ls1021a based platform (TQMLS102xA) that the platform device created by fsl-mph-dr-of does not autoload fsl-ehci. Digging into it I noticed that starting from commit bb160ee61c04f ("drivers/usb/host/ehci-fsl: Fix interrupt setup in host mode.") this platform device has the wrong modalias: $ cat /sys/bus/platform/devices/8600000.usb/fsl-ehci.0/modalias of:NusbT(null)Cfsl-usb2-dr-v2.5Cfsl-usb2-dr This is the modalias of the parent device, thus module ehci_fsl is not loaded automatically. Given the reason of removing the IRQ resource from DT in commit a1a2b7125e107 ("of/platform: Drop static setup of IRQ resource from DT core") the of_node has to be assigned to the subnode, but for modalias the reused of_node has to be ignored. Patch 2 is not strictly required to fix autoloading, but this is still a bug fix. Best regards, Alexander Alexander Stein (3): of: device: Ignore modalias of reused nodes of: device: Do not ignore error code in of_device_uevent_modalias usb: host: fsl-mph-dr-of: reuse device_set_of_node_from_dev drivers/of/device.c | 6 ++++-- drivers/usb/host/fsl-mph-dr-of.c | 3 +-- 2 files changed, 5 insertions(+), 4 deletions(-) Reviewed-by: Rob Herring