From patchwork Sun Mar 19 09:24:17 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 13180292 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8D5CEC7618A for ; Sun, 19 Mar 2023 09:25:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229861AbjCSJZL (ORCPT ); Sun, 19 Mar 2023 05:25:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59498 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229610AbjCSJZI (ORCPT ); Sun, 19 Mar 2023 05:25:08 -0400 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6B75324BCF for ; Sun, 19 Mar 2023 02:24:57 -0700 (PDT) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pdpHK-0003OR-Aa; Sun, 19 Mar 2023 10:24:38 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1pdpHE-005C7a-SW; Sun, 19 Mar 2023 10:24:32 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1pdpHE-0066Ox-9r; Sun, 19 Mar 2023 10:24:32 +0100 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Greg Kroah-Hartman , Ran Wang , Yang Yingliang , Li Jun , Sean Anderson , Sascha Hauer , Linus Walleij , Colin Ian King , Shawn Guo , Frank Li , Thierry Reding , Jonathan Hunter , Dmitry Torokhov Cc: linux-usb@vger.kernel.org, kernel@pengutronix.de, linuxppc-dev@lists.ozlabs.org, Fabio Estevam , NXP Linux Team , linux-arm-kernel@lists.infradead.org, linux-tegra@vger.kernel.org Subject: [PATCH 00/11] usb: phy: Convert to platform remove callback returning void Date: Sun, 19 Mar 2023 10:24:17 +0100 Message-Id: <20230319092428.283054-1-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=2248; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=vjf+A2GR88/lPDssebZLH6EPmN42VJTU/BC39sA+rZ4=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBkFtS78n0dRb5bSu2lBYcXVGDdi3EhA8J9JTZ05 DYpO9VScimJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZBbUuwAKCRCPgPtYfRL+ Tjp/B/458uY5AHP78FNs71P3sO3y0rxssHK5JDTAiXDUsAnWHrt13WJdoV+BOlwDNDJnRVqYcXG 9/ylVOxBor/Iv2INJD0Fv7KDikX2bvEAq5HArDWTmHloJUvu9bemsvhK6boVrtMBnUmx1F2/Bn9 bVjedCCxCXVJXR3AqZMl+U2H9bjPN2/TNfQt9OiZxGhcsfY733bbjtGIYEFQqXcNuPniCMmMhRu pmWPGv0KREpMJHzZn327mPsdHSzdSBGaECLleBZTn5GYOR1LH1RS/wL8NGTUaaqyDIlmIv9KgfE zIgqS2tbQ5WWhTG4Qn1IwMg67RrVvqdlMecirubg5vW0+byl X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-usb@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org Hello, this series adapts the platform drivers below drivers/usb/phy to use the .remove_new() callback. Compared to the traditional .remove() callback .remove_new() returns no value. This is a good thing because the driver core doesn't (and cannot) cope for errors during remove. The only effect of a non-zero return value in .remove() is that the driver core emits a warning. The device is removed anyhow and an early return from .remove() usually yields a resource leak. By changing the remove callback to return void driver authors cannot reasonably assume any more that there is some kind of cleanup later. All drivers could be converted trivally as they all returned zero unconditionally in their .remove() callback. Best regards Uwe Uwe Kleine-König (11): usb: phy: ab8500: Convert to platform remove callback returning void usb: phy: am335x: Convert to platform remove callback returning void usb: phy: fsl: Convert to platform remove callback returning void usb: phy: generic: Convert to platform remove callback returning void usb: phy: gpio-vbus: Convert to platform remove callback returning void usb: phy: keystone: Convert to platform remove callback returning void usb: phy: mv: Convert to platform remove callback returning void usb: phy: mxs: Convert to platform remove callback returning void usb: phy: tahvo: Convert to platform remove callback returning void usb: phy: tegra: Convert to platform remove callback returning void usb: phy: twl6030: Convert to platform remove callback returning void drivers/usb/phy/phy-ab8500-usb.c | 6 ++---- drivers/usb/phy/phy-am335x.c | 5 ++--- drivers/usb/phy/phy-fsl-usb.c | 6 ++---- drivers/usb/phy/phy-generic.c | 6 ++---- drivers/usb/phy/phy-gpio-vbus-usb.c | 6 ++---- drivers/usb/phy/phy-keystone.c | 6 ++---- drivers/usb/phy/phy-mv-usb.c | 6 ++---- drivers/usb/phy/phy-mxs-usb.c | 6 ++---- drivers/usb/phy/phy-tahvo.c | 6 ++---- drivers/usb/phy/phy-tegra-usb.c | 6 ++---- drivers/usb/phy/phy-twl6030-usb.c | 6 ++---- 11 files changed, 22 insertions(+), 43 deletions(-) base-commit: fe15c26ee26efa11741a7b632e9f23b01aca4cc6