From patchwork Tue Sep 3 16:30:25 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?=C5=81ukasz_Bartosik?= X-Patchwork-Id: 13789059 Received: from mail-ej1-f51.google.com (mail-ej1-f51.google.com [209.85.218.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 128A428382 for ; Tue, 3 Sep 2024 16:30:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.51 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725381040; cv=none; b=YuL2gtEJXognJutVLhnGk3T1x1QcYtoYBIR5MURG5kOBae2LLn4ax8hWDN0ucU+HyQl0rX4SWarwJSdjJz65jbVsP3brWaxdaVxWhV5WsxyCG7BA/cpGhmoj2SAELdHO+E3hJyDJHKM5aqyeXw9FDzjjyzRhxRAsxxx0oMh3jUk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725381040; c=relaxed/simple; bh=aFs9NPS8WCqwFZ1JxE68lfWCZWeMKzBWN/teIrkNEHw=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:Content-Type; b=ERyfkrueAu/DcOV3cXGxx8vTcfosamagyDq4ISicWlr5NvSgjWfoO+t5xIR1q8IbUL0ur+dJNgWbhHePDLNJ3euCxrF6i8uDpimCHYfXCEiBaH5FnR5Ps7jANBJxK/+yx7bXEdjvEgIk8IOkCnzxjX2nUrwB3ceT7DOjWLOFkAU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=GmuwKuxj; arc=none smtp.client-ip=209.85.218.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="GmuwKuxj" Received: by mail-ej1-f51.google.com with SMTP id a640c23a62f3a-a86859e2fc0so624674566b.3 for ; Tue, 03 Sep 2024 09:30:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1725381037; x=1725985837; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=jQdB3z5uEVHYQyhOM9/l8a+1Ce1iJPI+CxBf8lACdy8=; b=GmuwKuxjG9/nI/5OEVzz03VgBpcBN4z4nBni0+k9pnJUnsxdpNKhRfs9IghRZO5CUh fNrwd4RSrfO6kPsktzKjwMfCJph3xcasmCiDjau94yv8i9XMlaheYosAwseDDsCVZGyc Omox/pmxJHUFuiaJztZSZCchhlYXRLUFJlRXM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1725381037; x=1725985837; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=jQdB3z5uEVHYQyhOM9/l8a+1Ce1iJPI+CxBf8lACdy8=; b=PvBT8/3aYNHhIeXMNfRE7S53e+vv6FdbxrpALIDzAd6oLTXjEsLA/yqohwnyo3F1mP Myx7WOaQyM4AqGioLmz6gdnOrF9lktq+N0l3XU04EonzdlTO9kcmgehHkhNE5rr7fVQo tfV2Pv+48/Tww46lWBrEM+qLyfy2q3uzxlHnBI/Urdyg37CXGgkVIR1D43VBygM2e8zn Utq9syymJ6O3CFhVKsYLuT6AKCLXuBYqyuXeavZe3EBGD7aa96PBnj9cAfE2VAo0IR/F H0lFVxkTeuytMYzVhUWqcFwoB50D6qSAY26A9bGbnqiVtayGBRgLW5YHhWlOQ+ShBD6l Q+Nw== X-Forwarded-Encrypted: i=1; AJvYcCVVW3u4vIEVgxdZhNh1oQO3SIuT3NOZYlyAEE3MlajxadLeqjAyS7YgnnMlFQ1ltrZxWdy1x66mU6Y=@vger.kernel.org X-Gm-Message-State: AOJu0YxgAFaKnE4QEgQ6iT+325nueO2Y4xn5Ro3bvf7IrQ6rK/CI3KW9 DLyiPHl3MxKr6fBG3710JhAoHgwflmLl2818oPr7k9gu+ItARbw3DNmkGK7p X-Google-Smtp-Source: AGHT+IFxMW+43lrpAPVQhSBnzxQQCxffpIliq+fv8lcta5kGrjCZiV+i9JKs91BkiAzgF+OD67RyCA== X-Received: by 2002:a17:907:2d24:b0:a8a:1b59:59bc with SMTP id a640c23a62f3a-a8a32ed4f2cmr99476166b.31.1725381036746; Tue, 03 Sep 2024 09:30:36 -0700 (PDT) Received: from ukaszb-ng.c.googlers.com.com (140.20.91.34.bc.googleusercontent.com. [34.91.20.140]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a8989196bc4sm700685866b.125.2024.09.03.09.30.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 Sep 2024 09:30:36 -0700 (PDT) From: =?utf-8?q?=C5=81ukasz_Bartosik?= To: Heikki Krogerus , Greg Kroah-Hartman , Lee Jones , Benson Leung , Guenter Roeck Cc: Abhishek Pandit-Subedi , Pavan Holla , Tzung-Bi Shih , linux-usb@vger.kernel.org, chrome-platform@lists.linux.dev Subject: [PATCH v5 0/8] usb: typec: Implement UCSI driver for ChromeOS Date: Tue, 3 Sep 2024 16:30:25 +0000 Message-ID: <20240903163033.3170815-1-ukaszb@chromium.org> X-Mailer: git-send-email 2.46.0.469.g59c65b2a67-goog Precedence: bulk X-Mailing-List: linux-usb@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 This series implements a UCSI ChromeOS EC transport driver. The ChromeOS EC is expected to implement UCSI Platform Policy Manager (PPM). --- Changes in v5: - Increased WRITE_TMO_MS to 5000. - Replaced DRV_NAME with KBUILD_MODNAME. - Added comments for WRITE_TMO_MS and MAX_EC_DATA_SIZE defines. - Refactored cros_ucsi_async_control() to dynamically allocate memory for a message to EC instead of allocating the message on stack. - Replaced type names uint*_t with u*. - Removed ret variable in cros_ucsi_work(). - Updated ucsi_operations interface to align with changes introduced in v6.11. - Replaced test_bit() with test_and_clear_bit() in cros_ucsi_work(). - Added trace events in commit "usb: typec: cros_ec_ucsi: Add trace events". - Added netlink in commit "usb: typec: cros_ec_ucsi: Add netlink" for debugging and testing puropses. - Link to v4: https://lore.kernel.org/all/CAB2FV=6We88NrvN8NZYt8NkMFH9N_ZBGyUWVUpGwPdja2X_+NA@mail.gmail.com/T/ Changes in v4: - Setup notifications before calling ucsi_register. - Cancel work before destroying driver data. - Link to v3: https://lore.kernel.org/r/20240403-public-ucsi-h-v3-0-f848e18c8ed2@chromium.org Changes in v3: - Moved driver from platform/chrome to usb/typec/ucsi. - Used id_table instead of MODULE_ALIAS. - Split EC header changes into seperate commit. - Fixes from additional internal reviews and kernel bot warnings. - Link to v2: https://lore.kernel.org/r/20240325-public-ucsi-h-v2-0-a6d716968bb1@chromium.org Changes in v2: - No code or commit message changes. - Added drivers/platform/chrome maintainers for review. - Link to v1: https://lore.kernel.org/r/20240325-public-ucsi-h-v1-0-7c7e888edc0a@chromium.org Abhishek Pandit-Subedi (2): usb: typec: cros_ec_ucsi: Use complete instead of resume mfd: cros_ec: Don't load charger with UCSI Pavan Holla (4): platform/chrome: Update ChromeOS EC header for UCSI platform/chrome: Update EC feature flags usb: typec: ucsi: Implement ChromeOS UCSI driver mfd: cros_ec: Load cros_ec_ucsi on supported ECs Łukasz Bartosik (2): usb: typec: cros_ec_ucsi: Add trace events usb: typec: cros_ec_ucsi: Add netlink MAINTAINERS | 10 + drivers/mfd/cros_ec_dev.c | 25 +- drivers/usb/typec/ucsi/Kconfig | 13 + drivers/usb/typec/ucsi/Makefile | 3 + drivers/usb/typec/ucsi/cros_ec_ucsi_main.c | 351 ++++++++++++++++++ drivers/usb/typec/ucsi/cros_ec_ucsi_nl.c | 87 +++++ drivers/usb/typec/ucsi/cros_ec_ucsi_nl.h | 52 +++ drivers/usb/typec/ucsi/cros_ec_ucsi_trace.h | 92 +++++ .../linux/platform_data/cros_ec_commands.h | 54 ++- 9 files changed, 683 insertions(+), 4 deletions(-) create mode 100644 drivers/usb/typec/ucsi/cros_ec_ucsi_main.c create mode 100644 drivers/usb/typec/ucsi/cros_ec_ucsi_nl.c create mode 100644 drivers/usb/typec/ucsi/cros_ec_ucsi_nl.h create mode 100644 drivers/usb/typec/ucsi/cros_ec_ucsi_trace.h