[v2,0/9] Stop calling devm_request_irq() with invalid IRQs in the USB drivers

Message

Sergey Shtylyov Aug. 8, 2021, 8:30 p.m. UTC

Here are 9 patches against the 'usb-linus' branch of GregKH's 'usb.git' repo.
The affected drivers call platform_get_irq() but largely ignore its result --
they blithely pass the negative error codes to request_irq() (and its ilk)
which expects *unsinged* IRQ #s. Stop doing that by checking what exactly
platform_get_irq() returns.

[1/9] usb: dwc3: meson-g12a: add IRQ check
[2/9] usb: dwc3: qcom: add IRQ check
[3/61] usb: gadget: udc: at91: add IRQ check
[4/9] usb: gadget: udc: s3c2410: add IRQ check
[5/9] usb: host: ohci-tmio: add IRQ check
[6/9] usb: misc: brcmstb-usb-pinmap: add IRQ check
[7/9] usb: phy: fsl-usb: add IRQ check
[8/9] usb: phy: tahvo: add IRQ check
[9/9] usb: phy: twl6030: add IRQ checks

Comments

Greg KH Aug. 13, 2021, 6:58 a.m. UTC | #1

On Sun, Aug 08, 2021 at 11:30:57PM +0300, Sergey Shtylyov wrote:
> Here are 9 patches against the 'usb-linus' branch of GregKH's 'usb.git' repo.
> The affected drivers call platform_get_irq() but largely ignore its result --
> they blithely pass the negative error codes to request_irq() (and its ilk)
> which expects *unsinged* IRQ #s. Stop doing that by checking what exactly
> platform_get_irq() returns.
> 
> [1/9] usb: dwc3: meson-g12a: add IRQ check
> [2/9] usb: dwc3: qcom: add IRQ check
> [3/61] usb: gadget: udc: at91: add IRQ check

61?

> [4/9] usb: gadget: udc: s3c2410: add IRQ check
> [5/9] usb: host: ohci-tmio: add IRQ check
> [6/9] usb: misc: brcmstb-usb-pinmap: add IRQ check
> [7/9] usb: phy: fsl-usb: add IRQ check
> [8/9] usb: phy: tahvo: add IRQ check
> [9/9] usb: phy: twl6030: add IRQ checks


I only see 4 patches in this series, and the 4th, did not apply to my
tree :(

Can you please fix this up and resend it correctly?

thanks,

greg k-h

Greg KH Aug. 13, 2021, 7:01 a.m. UTC | #2

On Fri, Aug 13, 2021 at 08:58:58AM +0200, Greg Kroah-Hartman wrote:
> On Sun, Aug 08, 2021 at 11:30:57PM +0300, Sergey Shtylyov wrote:
> > Here are 9 patches against the 'usb-linus' branch of GregKH's 'usb.git' repo.
> > The affected drivers call platform_get_irq() but largely ignore its result --
> > they blithely pass the negative error codes to request_irq() (and its ilk)
> > which expects *unsinged* IRQ #s. Stop doing that by checking what exactly
> > platform_get_irq() returns.
> > 
> > [1/9] usb: dwc3: meson-g12a: add IRQ check
> > [2/9] usb: dwc3: qcom: add IRQ check
> > [3/61] usb: gadget: udc: at91: add IRQ check
> 
> 61?
> 
> > [4/9] usb: gadget: udc: s3c2410: add IRQ check
> > [5/9] usb: host: ohci-tmio: add IRQ check
> > [6/9] usb: misc: brcmstb-usb-pinmap: add IRQ check
> > [7/9] usb: phy: fsl-usb: add IRQ check
> > [8/9] usb: phy: tahvo: add IRQ check
> > [9/9] usb: phy: twl6030: add IRQ checks
> 
> 
> I only see 4 patches in this series, and the 4th, did not apply to my
> tree :(
> 
> Can you please fix this up and resend it correctly?

Ah, see your v2 now...