diff mbox

[v4,3/5] dt-bindings: usb: fusb302: remove max-sink-* properties

Message ID 1523629125-16332-4-git-send-email-jun.li@nxp.com (mailing list archive)
State New, archived
Headers show

Commit Message

Jun Li April 13, 2018, 2:18 p.m. UTC 
Remove max-sink-* properties since they are deprecated.

Reviewed-by: Rob Herring <robh@kernel.org>
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Li Jun <jun.li@nxp.com>
---
 Documentation/devicetree/bindings/usb/fcs,fusb302.txt | 6 ------
 1 file changed, 6 deletions(-)

Comments

Guenter Roeck April 13, 2018, 4:04 p.m. UTC | #1 
On Fri, Apr 13, 2018 at 10:18:43PM +0800, Li Jun wrote:
> Remove max-sink-* properties since they are deprecated.
> 
> Reviewed-by: Rob Herring <robh@kernel.org>
> Reviewed-by: Hans de Goede <hdegoede@redhat.com>
> Signed-off-by: Li Jun <jun.li@nxp.com>
> ---
>  Documentation/devicetree/bindings/usb/fcs,fusb302.txt | 6 ------
>  1 file changed, 6 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/usb/fcs,fusb302.txt b/Documentation/devicetree/bindings/usb/fcs,fusb302.txt
> index 472facf..6087dc7 100644
> --- a/Documentation/devicetree/bindings/usb/fcs,fusb302.txt
> +++ b/Documentation/devicetree/bindings/usb/fcs,fusb302.txt
> @@ -6,12 +6,6 @@ Required properties :
>  - interrupts             : Interrupt specifier
>  
>  Optional properties :
> -- fcs,max-sink-microvolt : Maximum voltage to negotiate when configured as sink
> -- fcs,max-sink-microamp  : Maximum current to negotiate when configured as sink
> -- fcs,max-sink-microwatt : Maximum power to negotiate when configured as sink
> -			   If this is less then max-sink-microvolt *
> -			   max-sink-microamp then the configured current will
> -			   be clamped.

Is it acceptable to just remove properties ?

>  - fcs,operating-sink-microwatt :
>  			   Minimum amount of power accepted from a sink
>  			   when negotiating
> -- 
> 2.7.4
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Jun Li April 13, 2018, 11:31 p.m. UTC | #2 
DQo+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+IEZyb206IEd1ZW50ZXIgUm9lY2sgW21h
aWx0bzpsaW51eEByb2Vjay11cy5uZXRdDQo+IFNlbnQ6IDIwMTjE6jTUwjE0yNUgMDowNA0KPiBU
bzogSnVuIExpIDxqdW4ubGlAbnhwLmNvbT4NCj4gQ2M6IGdyZWdraEBsaW51eGZvdW5kYXRpb24u
b3JnOyByb2JoK2R0QGtlcm5lbC5vcmc7DQo+IGhlaWtraS5rcm9nZXJ1c0BsaW51eC5pbnRlbC5j
b207IGhkZWdvZWRlQHJlZGhhdC5jb207IHJtZnJmc0BnbWFpbC5jb207DQo+IHl1ZXlhby56aHVA
Z21haWwuY29tOyBsaW51eC11c2JAdmdlci5rZXJuZWwub3JnOyBkbC1saW51eC1pbXgNCj4gPGxp
bnV4LWlteEBueHAuY29tPg0KPiBTdWJqZWN0OiBSZTogW1BBVENIIHY0IDMvNV0gZHQtYmluZGlu
Z3M6IHVzYjogZnVzYjMwMjogcmVtb3ZlIG1heC1zaW5rLSoNCj4gcHJvcGVydGllcw0KPiANCj4g
T24gRnJpLCBBcHIgMTMsIDIwMTggYXQgMTA6MTg6NDNQTSArMDgwMCwgTGkgSnVuIHdyb3RlOg0K
PiA+IFJlbW92ZSBtYXgtc2luay0qIHByb3BlcnRpZXMgc2luY2UgdGhleSBhcmUgZGVwcmVjYXRl
ZC4NCj4gPg0KPiA+IFJldmlld2VkLWJ5OiBSb2IgSGVycmluZyA8cm9iaEBrZXJuZWwub3JnPg0K
PiA+IFJldmlld2VkLWJ5OiBIYW5zIGRlIEdvZWRlIDxoZGVnb2VkZUByZWRoYXQuY29tPg0KPiA+
IFNpZ25lZC1vZmYtYnk6IExpIEp1biA8anVuLmxpQG54cC5jb20+DQo+ID4gLS0tDQo+ID4gIERv
Y3VtZW50YXRpb24vZGV2aWNldHJlZS9iaW5kaW5ncy91c2IvZmNzLGZ1c2IzMDIudHh0IHwgNiAt
LS0tLS0NCj4gPiAgMSBmaWxlIGNoYW5nZWQsIDYgZGVsZXRpb25zKC0pDQo+ID4NCj4gPiBkaWZm
IC0tZ2l0IGEvRG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdzL3VzYi9mY3MsZnVzYjMw
Mi50eHQNCj4gYi9Eb2N1bWVudGF0aW9uL2RldmljZXRyZWUvYmluZGluZ3MvdXNiL2ZjcyxmdXNi
MzAyLnR4dA0KPiA+IGluZGV4IDQ3MmZhY2YuLjYwODdkYzcgMTAwNjQ0DQo+ID4gLS0tIGEvRG9j
dW1lbnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdzL3VzYi9mY3MsZnVzYjMwMi50eHQNCj4gPiAr
KysgYi9Eb2N1bWVudGF0aW9uL2RldmljZXRyZWUvYmluZGluZ3MvdXNiL2ZjcyxmdXNiMzAyLnR4
dA0KPiA+IEBAIC02LDEyICs2LDYgQEAgUmVxdWlyZWQgcHJvcGVydGllcyA6DQo+ID4gIC0gaW50
ZXJydXB0cyAgICAgICAgICAgICA6IEludGVycnVwdCBzcGVjaWZpZXINCj4gPg0KPiA+ICBPcHRp
b25hbCBwcm9wZXJ0aWVzIDoNCj4gPiAtLSBmY3MsbWF4LXNpbmstbWljcm92b2x0IDogTWF4aW11
bSB2b2x0YWdlIHRvIG5lZ290aWF0ZSB3aGVuIGNvbmZpZ3VyZWQgYXMNCj4gc2luaw0KPiA+IC0t
IGZjcyxtYXgtc2luay1taWNyb2FtcCAgOiBNYXhpbXVtIGN1cnJlbnQgdG8gbmVnb3RpYXRlIHdo
ZW4gY29uZmlndXJlZA0KPiBhcyBzaW5rDQo+ID4gLS0gZmNzLG1heC1zaW5rLW1pY3Jvd2F0dCA6
IE1heGltdW0gcG93ZXIgdG8gbmVnb3RpYXRlIHdoZW4gY29uZmlndXJlZCBhcw0KPiBzaW5rDQo+
ID4gLQkJCSAgIElmIHRoaXMgaXMgbGVzcyB0aGVuIG1heC1zaW5rLW1pY3Jvdm9sdCAqDQo+ID4g
LQkJCSAgIG1heC1zaW5rLW1pY3JvYW1wIHRoZW4gdGhlIGNvbmZpZ3VyZWQgY3VycmVudCB3aWxs
DQo+ID4gLQkJCSAgIGJlIGNsYW1wZWQuDQo+IA0KPiBJcyBpdCBhY2NlcHRhYmxlIHRvIGp1c3Qg
cmVtb3ZlIHByb3BlcnRpZXMgPw0KDQpXaGF0IGVsc2UgeW91IHN1Z2dlc3QgSSBzaG91bGQgZG8/
IGFsc28gYWRkIGRvY3VtZW50IGhlcmUgdG8gZXhwbGFpbiB3aHkNCnJlbW92ZSB0aGVtPw0KDQpU
aGFua3MNCkp1bg0KPiANCj4gPiAgLSBmY3Msb3BlcmF0aW5nLXNpbmstbWljcm93YXR0IDoNCj4g
PiAgCQkJICAgTWluaW11bSBhbW91bnQgb2YgcG93ZXIgYWNjZXB0ZWQgZnJvbSBhIHNpbmsNCj4g
PiAgCQkJICAgd2hlbiBuZWdvdGlhdGluZw0KPiA+IC0tDQo+ID4gMi43LjQNCj4gPg0K
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Guenter Roeck April 14, 2018, 3:02 a.m. UTC | #3 
On 04/13/2018 04:31 PM, Jun Li wrote:
> 
>> -----Original Message-----
>> From: Guenter Roeck [mailto:linux@roeck-us.net]
>> Sent: 2018年4月14日 0:04
>> To: Jun Li <jun.li@nxp.com>
>> Cc: gregkh@linuxfoundation.org; robh+dt@kernel.org;
>> heikki.krogerus@linux.intel.com; hdegoede@redhat.com; rmfrfs@gmail.com;
>> yueyao.zhu@gmail.com; linux-usb@vger.kernel.org; dl-linux-imx
>> <linux-imx@nxp.com>
>> Subject: Re: [PATCH v4 3/5] dt-bindings: usb: fusb302: remove max-sink-*
>> properties
>>
>> On Fri, Apr 13, 2018 at 10:18:43PM +0800, Li Jun wrote:
>>> Remove max-sink-* properties since they are deprecated.
>>>
>>> Reviewed-by: Rob Herring <robh@kernel.org>
>>> Reviewed-by: Hans de Goede <hdegoede@redhat.com>
>>> Signed-off-by: Li Jun <jun.li@nxp.com>
>>> ---
>>>   Documentation/devicetree/bindings/usb/fcs,fusb302.txt | 6 ------
>>>   1 file changed, 6 deletions(-)
>>>
>>> diff --git a/Documentation/devicetree/bindings/usb/fcs,fusb302.txt
>> b/Documentation/devicetree/bindings/usb/fcs,fusb302.txt
>>> index 472facf..6087dc7 100644
>>> --- a/Documentation/devicetree/bindings/usb/fcs,fusb302.txt
>>> +++ b/Documentation/devicetree/bindings/usb/fcs,fusb302.txt
>>> @@ -6,12 +6,6 @@ Required properties :
>>>   - interrupts             : Interrupt specifier
>>>
>>>   Optional properties :
>>> -- fcs,max-sink-microvolt : Maximum voltage to negotiate when configured as
>> sink
>>> -- fcs,max-sink-microamp  : Maximum current to negotiate when configured
>> as sink
>>> -- fcs,max-sink-microwatt : Maximum power to negotiate when configured as
>> sink
>>> -			   If this is less then max-sink-microvolt *
>>> -			   max-sink-microamp then the configured current will
>>> -			   be clamped.
>>
>> Is it acceptable to just remove properties ?
> 
> What else you suggest I should do? also add document here to explain why
> remove them?
> 
I would suggest to either wait for Rob's feedback or check how other bindings
handle deprecated properties.

Guenter
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Jun Li April 14, 2018, 3:42 a.m. UTC | #4 
Hi Guenter,
> -----Original Message-----

> From: Guenter Roeck [mailto:groeck7@gmail.com] On Behalf Of Guenter Roeck

> Sent: 2018年4月14日 11:03

> To: Jun Li <jun.li@nxp.com>

> Cc: gregkh@linuxfoundation.org; robh+dt@kernel.org;

> heikki.krogerus@linux.intel.com; hdegoede@redhat.com; rmfrfs@gmail.com;

> yueyao.zhu@gmail.com; linux-usb@vger.kernel.org; dl-linux-imx

> <linux-imx@nxp.com>

> Subject: Re: [PATCH v4 3/5] dt-bindings: usb: fusb302: remove max-sink-*

> properties

> 

> On 04/13/2018 04:31 PM, Jun Li wrote:

> >

> >> -----Original Message-----

> >> From: Guenter Roeck [mailto:linux@roeck-us.net]

> >> Sent: 2018年4月14日 0:04

> >> To: Jun Li <jun.li@nxp.com>

> >> Cc: gregkh@linuxfoundation.org; robh+dt@kernel.org;

> >> heikki.krogerus@linux.intel.com; hdegoede@redhat.com;

> >> rmfrfs@gmail.com; yueyao.zhu@gmail.com; linux-usb@vger.kernel.org;

> >> dl-linux-imx <linux-imx@nxp.com>

> >> Subject: Re: [PATCH v4 3/5] dt-bindings: usb: fusb302: remove

> >> max-sink-* properties

> >>

> >> On Fri, Apr 13, 2018 at 10:18:43PM +0800, Li Jun wrote:

> >>> Remove max-sink-* properties since they are deprecated.

> >>>

> >>> Reviewed-by: Rob Herring <robh@kernel.org>

> >>> Reviewed-by: Hans de Goede <hdegoede@redhat.com>

> >>> Signed-off-by: Li Jun <jun.li@nxp.com>

> >>> ---

> >>>   Documentation/devicetree/bindings/usb/fcs,fusb302.txt | 6 ------

> >>>   1 file changed, 6 deletions(-)

> >>>

> >>> diff --git a/Documentation/devicetree/bindings/usb/fcs,fusb302.txt

> >> b/Documentation/devicetree/bindings/usb/fcs,fusb302.txt

> >>> index 472facf..6087dc7 100644

> >>> --- a/Documentation/devicetree/bindings/usb/fcs,fusb302.txt

> >>> +++ b/Documentation/devicetree/bindings/usb/fcs,fusb302.txt

> >>> @@ -6,12 +6,6 @@ Required properties :

> >>>   - interrupts             : Interrupt specifier

> >>>

> >>>   Optional properties :

> >>> -- fcs,max-sink-microvolt : Maximum voltage to negotiate when

> >>> configured as

> >> sink

> >>> -- fcs,max-sink-microamp  : Maximum current to negotiate when

> >>> configured

> >> as sink

> >>> -- fcs,max-sink-microwatt : Maximum power to negotiate when

> >>> configured as

> >> sink

> >>> -			   If this is less then max-sink-microvolt *

> >>> -			   max-sink-microamp then the configured current will

> >>> -			   be clamped.

> >>

> >> Is it acceptable to just remove properties ?

> >

> > What else you suggest I should do? also add document here to explain

> > why remove them?

> >

> I would suggest to either wait for Rob's feedback or check how other bindings

> handle deprecated properties.


Rob already reviewed this patch and gave his reviewed-by[1], you can see it in the
patch tags.

[1]https://www.spinics.net/lists/devicetree/msg221601.html

Thanks
Jun
> 

> Guenter
Guenter Roeck April 14, 2018, 5:15 a.m. UTC | #5 
On 04/13/2018 08:42 PM, Jun Li wrote:
> Hi Guenter,
>> -----Original Message-----
>> From: Guenter Roeck [mailto:groeck7@gmail.com] On Behalf Of Guenter Roeck
>> Sent: 2018年4月14日 11:03
>> To: Jun Li <jun.li@nxp.com>
>> Cc: gregkh@linuxfoundation.org; robh+dt@kernel.org;
>> heikki.krogerus@linux.intel.com; hdegoede@redhat.com; rmfrfs@gmail.com;
>> yueyao.zhu@gmail.com; linux-usb@vger.kernel.org; dl-linux-imx
>> <linux-imx@nxp.com>
>> Subject: Re: [PATCH v4 3/5] dt-bindings: usb: fusb302: remove max-sink-*
>> properties
>>
>> On 04/13/2018 04:31 PM, Jun Li wrote:
>>>
>>>> -----Original Message-----
>>>> From: Guenter Roeck [mailto:linux@roeck-us.net]
>>>> Sent: 2018年4月14日 0:04
>>>> To: Jun Li <jun.li@nxp.com>
>>>> Cc: gregkh@linuxfoundation.org; robh+dt@kernel.org;
>>>> heikki.krogerus@linux.intel.com; hdegoede@redhat.com;
>>>> rmfrfs@gmail.com; yueyao.zhu@gmail.com; linux-usb@vger.kernel.org;
>>>> dl-linux-imx <linux-imx@nxp.com>
>>>> Subject: Re: [PATCH v4 3/5] dt-bindings: usb: fusb302: remove
>>>> max-sink-* properties
>>>>
>>>> On Fri, Apr 13, 2018 at 10:18:43PM +0800, Li Jun wrote:
>>>>> Remove max-sink-* properties since they are deprecated.
>>>>>
>>>>> Reviewed-by: Rob Herring <robh@kernel.org>
>>>>> Reviewed-by: Hans de Goede <hdegoede@redhat.com>
>>>>> Signed-off-by: Li Jun <jun.li@nxp.com>
>>>>> ---
>>>>>    Documentation/devicetree/bindings/usb/fcs,fusb302.txt | 6 ------
>>>>>    1 file changed, 6 deletions(-)
>>>>>
>>>>> diff --git a/Documentation/devicetree/bindings/usb/fcs,fusb302.txt
>>>> b/Documentation/devicetree/bindings/usb/fcs,fusb302.txt
>>>>> index 472facf..6087dc7 100644
>>>>> --- a/Documentation/devicetree/bindings/usb/fcs,fusb302.txt
>>>>> +++ b/Documentation/devicetree/bindings/usb/fcs,fusb302.txt
>>>>> @@ -6,12 +6,6 @@ Required properties :
>>>>>    - interrupts             : Interrupt specifier
>>>>>
>>>>>    Optional properties :
>>>>> -- fcs,max-sink-microvolt : Maximum voltage to negotiate when
>>>>> configured as
>>>> sink
>>>>> -- fcs,max-sink-microamp  : Maximum current to negotiate when
>>>>> configured
>>>> as sink
>>>>> -- fcs,max-sink-microwatt : Maximum power to negotiate when
>>>>> configured as
>>>> sink
>>>>> -			   If this is less then max-sink-microvolt *
>>>>> -			   max-sink-microamp then the configured current will
>>>>> -			   be clamped.
>>>>
>>>> Is it acceptable to just remove properties ?
>>>
>>> What else you suggest I should do? also add document here to explain
>>> why remove them?
>>>
>> I would suggest to either wait for Rob's feedback or check how other bindings
>> handle deprecated properties.
> 
> Rob already reviewed this patch and gave his reviewed-by[1], you can see it in the
> patch tags.
> 
> [1]https://www.spinics.net/lists/devicetree/msg221601.html
> 
Ah, ok. Guess you are ok then. Sorry, should have noticed.

Guenter
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/Documentation/devicetree/bindings/usb/fcs,fusb302.txt b/Documentation/devicetree/bindings/usb/fcs,fusb302.txt
index 472facf..6087dc7 100644
--- a/Documentation/devicetree/bindings/usb/fcs,fusb302.txt
+++ b/Documentation/devicetree/bindings/usb/fcs,fusb302.txt
@@ -6,12 +6,6 @@  Required properties :
 - interrupts             : Interrupt specifier
 
 Optional properties :
-- fcs,max-sink-microvolt : Maximum voltage to negotiate when configured as sink
-- fcs,max-sink-microamp  : Maximum current to negotiate when configured as sink
-- fcs,max-sink-microwatt : Maximum power to negotiate when configured as sink
-			   If this is less then max-sink-microvolt *
-			   max-sink-microamp then the configured current will
-			   be clamped.
 - fcs,operating-sink-microwatt :
 			   Minimum amount of power accepted from a sink
 			   when negotiating