From patchwork Mon May 14 09:15:59 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yoshihiro Shimoda X-Patchwork-Id: 10397641 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 39FA56038F for ; Mon, 14 May 2018 09:17:08 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 299D9290DB for ; Mon, 14 May 2018 09:17:08 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 1DD3B290E1; Mon, 14 May 2018 09:17:08 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 0A217290DD for ; Mon, 14 May 2018 09:17:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752129AbeENJRF (ORCPT ); Mon, 14 May 2018 05:17:05 -0400 Received: from relmlor4.renesas.com ([210.160.252.174]:29388 "EHLO relmlie3.idc.renesas.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752191AbeENJQo (ORCPT ); Mon, 14 May 2018 05:16:44 -0400 Received: from unknown (HELO relmlir3.idc.renesas.com) ([10.200.68.153]) by relmlie3.idc.renesas.com with ESMTP; 14 May 2018 18:16:41 +0900 Received: from relmlii1.idc.renesas.com (relmlii1.idc.renesas.com [10.200.68.65]) by relmlir3.idc.renesas.com (Postfix) with ESMTP id D8C24843FA; Mon, 14 May 2018 18:16:41 +0900 (JST) X-IronPort-AV: E=Sophos;i="5.49,399,1520866800"; d="scan'208";a="279472949" Received: from mail-ty1jpn01lp0179.outbound.protection.outlook.com (HELO JPN01-TY1-obe.outbound.protection.outlook.com) ([23.103.139.179]) by relmlii1.idc.renesas.com with ESMTP/TLS/AES256-SHA256; 14 May 2018 18:16:41 +0900 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=renesasgroup.onmicrosoft.com; s=selector1-renesas-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=kFUMbN0UmDKsMMPcp1V/8imzk+fM6gcG9xFr6h8qSAI=; b=KpzxmzX4qMmgYX3T99tEWnPlcu7bjF+skjyFxxq3PoLUwLGEDlqx91At545eNASmS4APVSRzV3fsvNS7PCSmpDt7gCULovqstaID5SUspHKyzzHRa3153R2N1bnMp75vKMerFcGQQ0BVySywxBtnE5gJ1vvHJlLIExKugEGWeiU= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=<>; Received: from localhost.localdomain (211.11.155.138) by OSBPR01MB2293.jpnprd01.prod.outlook.com (2603:1096:603:26::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.755.16; Mon, 14 May 2018 09:16:39 +0000 From: Yoshihiro Shimoda To: gregkh@linuxfoundation.org, robh+dt@kernel.org, mark.rutland@arm.com Cc: heikki.krogerus@linux.intel.com, hdegoede@redhat.com, andy.shevchenko@gmail.com, linux-usb@vger.kernel.org, linux-renesas-soc@vger.kernel.org, devicetree@vger.kernel.org, Yoshihiro Shimoda Subject: [PATCH/RFC v3 3/4] usb: gadget: udc: renesas_usb3: use usb role switch API Date: Mon, 14 May 2018 18:15:59 +0900 Message-Id: <1526289360-3997-4-git-send-email-yoshihiro.shimoda.uh@renesas.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1526289360-3997-1-git-send-email-yoshihiro.shimoda.uh@renesas.com> References: <1526289360-3997-1-git-send-email-yoshihiro.shimoda.uh@renesas.com> MIME-Version: 1.0 X-Originating-IP: [211.11.155.138] X-ClientProxiedBy: TY1PR01CA0144.jpnprd01.prod.outlook.com (2603:1096:402:1::20) To OSBPR01MB2293.jpnprd01.prod.outlook.com (2603:1096:603:26::14) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(48565401081)(4534165)(4627221)(201703031133081)(5600026)(2017052603328)(7153060)(7193020); SRVR:OSBPR01MB2293; X-Microsoft-Exchange-Diagnostics: 1; OSBPR01MB2293; 3:3dIxGgqTpT2u9SjWbzQUv51s0BMX4u8/QHJBbNWH7TcMcfJ8So9O1fJL9zDxV+cPJXQrwQ8sQg+hSX3sXMXm+ZhkhZ4XE11EQIWNTD1VfjDavBCyhVK1TUBmOrjCwV6J/GhXcZByeGtQ8lYs/XGyp2QkketZYOkaPla2x5siLfAbRU0+1ELHXreDmbqsl3MmSRBgbcLsWQGWW5yE0DYE1HSIUE1IWNksNi1WahO2vXAf1zmXzKf98VjjWF7DLe9u; 25:71pXtAxJP3XROr0wwMBM+RooMl0K9oJyH0d8c64Ki+kVocyR0jOKFtLuAi96Ni5EO9k+vmYxC18g/HKOJzZKJ/JSlY35dFgFdHpM6mVW3Oi4/uYmOVpgCV7ote0lgwppQerAnIJZ+urxuIQ4kN1qbLEW0HLF/xm5QZiQDZR9nti0ZzLsK2arDe+lc/RuiTEEsJcB81OqtfPY+HKs0UjhPF7DM0ouebW8ALaUpMqfQY9FzaoiO6L4pzcMElQNaejJOn2jSgLKbTS70I2Y50K9LazhGMmfKN1wsmFSyhq4bmYgdVEbbfWDrwYVec1ixKPlAzwm5JYt5RpbcrcEo1F7YA==; 31:0cy56cp4zeWJJ9k11KFpMhVCW+f0jatatN38fNE1DqA+ZZuPErJSLSuVyashlgQrxtJoOKtoyNZmNy0vnGS4j4wPAAkzo8IdsxI1NR30J9K8kIvs3+wMSGcOnfIODl6uD4yGIY0shd4NzH6BKs1YoA0uosVby8j4vIxkrJU1XbFpgCd2QNE+wk0sAdDqf0migD1i4Mt6zLy3oGhW9uNlBC2pYCok8zDDu7KZ9hBIgjI= X-MS-TrafficTypeDiagnostic: OSBPR01MB2293: X-Microsoft-Exchange-Diagnostics: 1; OSBPR01MB2293; 20:YR6hzkAX3cE6/z8MfJRou9fQAqzIQTAW+7HPsAiSFwhq5VkZL/N2Oa7nH3ZZQoNCBIlkcdfZAIycHd+YuxIQMsMY6or4s82yb169BLms1QULm96a1+NO9Q97I57ItdoVNoBeiaQ50NVBSiuePeGsYq5jgjvOQPQ2X0ZeGTIQZYifRDhvwfk15U9idBk33AiAf4Jgnrg30rJtgt9ZHfIaNB3v2W2pZybF8CximTrqhNkNnmhp9zZfcEzOEbVZT7Di92v3oHC21fdS1hcwxpe/SBiE2H+73pQru2cGicfw/88O8hHoZ0AAB6ZALP5yU93FxJO0SAjNMyoUfmb0OJj0/81cyJpqYSMds//rDebVBcxWRYeG7F518aK138IbV8ro9DD7vGb2ClxqVhj7G1p4iVaNt9jheszbgoPkOpNI52rE3EfhKiL/uhsctR1CYpo8zZD0v4RFj8jAE6DgWCKJWxKxiyprHo7QCJ78NBY0imGy0NovXsHcPZJCrEx3mIJL; 4:8FbAl4d7Ob70ql4jZCSyDkV9sJ+odFTjebgk9sqAeznN3UggvPTX81rZELMUdSlHFfSHk/cFFkfzpuITqzEt/l+I55gFyxHyLQLwlYNCnCaXa4pXtBMv064GEOP8MEsbYJrLZI45r2en2o20tT7+a+UOUWZUPAIXhfKXS5jlkodX0K+J1PymZm7XXn3bAjQB5xraowoyVDV1uI26bfn3UXKK5p9egFx0zcFwUAmdmMBQi6+kCwtSAkC7CRjV0VEYfJljMRvp3pzqzXvfyBMskg== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(3231254)(944501410)(52105095)(93006095)(3002001)(10201501046)(6055026)(149027)(150027)(6041310)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061750153)(20161123558120)(20161123560045)(20161123562045)(20161123564045)(6072148)(201708071742011); SRVR:OSBPR01MB2293; BCL:0; PCL:0; RULEID:; SRVR:OSBPR01MB2293; X-Forefront-PRVS: 067270ECAF X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10019020)(6069001)(346002)(376002)(39380400002)(39860400002)(396003)(366004)(199004)(189003)(16526019)(107886003)(68736007)(97736004)(53936002)(36756003)(50466002)(4326008)(6512007)(316002)(6116002)(106356001)(6486002)(6506007)(386003)(16586007)(26005)(3846002)(25786009)(59450400001)(5660300001)(78352004)(47776003)(81166006)(7736002)(52116002)(81156014)(305945005)(50226002)(2906002)(51416003)(105586002)(39060400002)(11346002)(486006)(42882007)(2616005)(446003)(48376002)(476003)(6666003)(498600001)(956004)(76176011)(66066001)(8676002)(8936002)(3720700003); DIR:OUT; SFP:1102; SCL:1; SRVR:OSBPR01MB2293; H:localhost.localdomain; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:0; MX:0; Received-SPF: None (protection.outlook.com: localhost.localdomain does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; OSBPR01MB2293; 23:GWuvcOFhVIPe6J7VFqmMJ52DDxmMrfGZDCflggAuG?= =?us-ascii?Q?VI6Mr7ethSfMziTPI/ycub6/aK8250LYy3Ie4+AexvpwX95ITZnQPnu2sMWc?= =?us-ascii?Q?jrJ8r8OXB2MEteBJwCLV2T/oRVlw5l+IK/rgR8BET6mKmMpTRZizLYRa/2lI?= =?us-ascii?Q?vnyIDl8pJSnvl5cJwQPmYAOS3UAgKfWhkT5CYHxU0krj3a0PK2PkAYPFByEK?= =?us-ascii?Q?jT8tAaNLrhyZuxzEvphkPkYZlM47Lq9VP4ufk8qsnldbwtoVJ52YVlhfGKUY?= =?us-ascii?Q?Sr3vuq2ic4RWks7mnZ2fMHn+ezSdYroyaqkBzGG9B2JKjPqPJaUFvQYUiWzs?= =?us-ascii?Q?O0rtMaBqRe6cqFRzsLqdX/kEnYe/f8HP6QM92EUA0VX+OhXyrSCHwLjtlHzJ?= =?us-ascii?Q?u1sPM+vDIjh06SEXjxiiY4r5cVM8x5MA0qbV1feVMJlaPrigP9/oFzfnhQnd?= =?us-ascii?Q?XKOz4K4gF+VBvytWz7uZ4Vm/6KuzTcVUu57iUnjcoZ5YBN8nz84UJ0zvyl5S?= =?us-ascii?Q?SHYBgKWoLyk4khFA5T3tdijmj5Hcyg+oNa6wg3Td5RQOkaLWe09AwaMDm+v9?= =?us-ascii?Q?eQhA0zI6PbGxNUsCqgrtxD4ACHsr239kQNI0AS//dpziEN1YpzEfxBWYSEjG?= =?us-ascii?Q?hctrS5x36MTiEEMC/ZWTEdwu+t2ySQwIZCh0GpSnaiyZVblt0DVw3mRpFtCQ?= =?us-ascii?Q?FZPiSALqmfHyOvUIe0Br0EbuOisoxPwdHo4JLmZVUI7SV2KfMoUEJu9uqQXg?= =?us-ascii?Q?oH+sk9D4+ivDFVtlnvU+AB0j3nfMdo4Y+YO8K9z12uB2raECLmBoLYpvK8pk?= =?us-ascii?Q?EkReUfFc6WVKhpAa7jaMAtgBtwfF/sqRa9WFaMOlLBPn4n0AWLPqespzfHaq?= =?us-ascii?Q?czJqi9Ypicmzn4gHgOTX7+HJnPnFGDveHGH8Tz8caG0HPmSIIJtAjQWtb05W?= =?us-ascii?Q?2zGEAySGElJKVTtPa5suHx2OMjcwBAw1yFl6KEVv0zJQzJImHJrhhslQ8L4r?= =?us-ascii?Q?0yqKH7+VsKGq4RBY1v7UZR0LsFR3R3M6DX0RWhNtSI75C2LzpiverBSYQSHC?= =?us-ascii?Q?lB0R5b6CKctK8SLQhIE1Fiv09BSqGdDAI6NhlJ97x4yC6hmrkdRSLxFH4Rhw?= =?us-ascii?Q?LOHP3m4RRz3URLVVDx2hwwpZsV6TwhZfwjvBZGD7OgkT9G/1FZFcWusu2CHo?= =?us-ascii?Q?K3sBUaXJuhK4u8Am1k6TAzciuSu4J/d6zoNiY0MgPvLO/7r+4S0ZSVI+0Nmx?= =?us-ascii?Q?s8vNKyfT4+2YZPngfN59xZxN9Xmlg26vCJ49nqH8RUq1rdsdYuw3Yo6i7vy6?= =?us-ascii?B?Zz09?= X-Microsoft-Antispam-Message-Info: tRsKQ85ahk49RI7Mc3/b8aj+KOfvXg74RIRE/AKc/p0N19yyxiXPg8wi5B9UBFOaqI8gZzPpUp8Gdjv68+tdWG1bdsgZmH7fVRTP/Umsok24yFQfowRI9aaypAGImnAdw92Dni9STCLl0R0LZAqsdm83So5kKhzvZeu1DCIXYCd0yplMRw9LK5ndh3Rbnbiw X-Microsoft-Exchange-Diagnostics: 1; OSBPR01MB2293; 6:a47oBADtwurI6aEA/o8U0OPDvhKiBleRpKg+HrERJZb4oEbaMMmkNPtGuIpxsggEcLWkB+oF+IrEg+icmJGyGE4+I8oScLQ8EmqfjbXPxrIVCEtQmJD+LpyCmsPkP/2SuJabLWAy4gYw6D+juyoIGrcrje8FOuNo/HUpanA1hAgddif40l4KlD5nfl64oLwrroZan8kMG4a281X8adMEh8yawd8y6B+o+tqo5QKdK97TxNUcxVixKLE11pRBUtmR05gXYpRQvFbOWSCkd7jqsxvJbNmBHlobP1XNIRPZyoyCPLKxuzdfngaTdnG2IDNiCvO8L0WGfvUMDmWge62oE9Ex1Bc+yqRtD6RdOMPtnFyd0CmNwVsYaUBb/d6sWUlpC0ENivmonVQb0rfjI+nAb5qdx1ICjeNAKvvK52VoK76Ltszcht9P5p5eu0F+h53drIhtucLwQ/VtDN+ZxenDcA==; 5:mWgRGLKD3ifvGxpgofgDjEeGj3vCvrbCzUiTQQGjwd9IDrvCB+C+8GZ9iuDIXontlOz/5ayRPCXwx+SV+GhWvPs0a15MoSHk7k8qZEZF+gvp8h/j28ri7JMrrM4XcFbWcLlp5GAj8PNJcQpFXRN0Df9M5MmLpBLq0Mk7m1y1biI=; 24:k0JUO2zgyOnWj2WDTDOeb5hXybRjQDVxsb/J9W98/HfSJ4GR3FG7XoQC2dJXML/a+46+jtYFs54SNfSVZ1LDf4oQoMHKuCyRGUaEEV6WITQ= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; OSBPR01MB2293; 7:TESQhNUvKy82aYMCo/i6bekn4wqPFfWza6sIn5b6bWdtM2FPaQAJBrEPIWA4jXjsZpHLO+b5OasskOxJD9FtQm5g5pEdw4byxzUef3kJ8kdCiHXXbMXVXkBlE84CJxuIPe8dibbJDuVf6iDdMtkfu8zwLOUMmqm0NAlPYmuEKkd641T84scZ1gurHKI8+QCz8AK4OF8O93YUx/Y3qsVFJPz0Nkx0y6Sh1DEw/GThRkmfWp4Y96SVudPKWN1Xib7M; 20:oLdIcAuMCTop/XkBeQwcQ/5bIwDAgTEuFJJfsb9Z/D3qdtR+9fT6Hg9nob+IzrLgd6k5EnAP5LYfz8F3JTIYH4F2X7szSGG/8E6OnmqM4Olj2uy2dwNZIwDKydiC41nhBAApC0ipSSsiF22PDxrJkdclI4ThFxObCFs6jro5pFc= X-MS-Office365-Filtering-Correlation-Id: 5fd0dd66-7610-4cf9-ad9a-08d5b97b6670 X-OriginatorOrg: renesas.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 May 2018 09:16:39.1538 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 5fd0dd66-7610-4cf9-ad9a-08d5b97b6670 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 53d82571-da19-47e4-9cb4-625a166a4a2a X-MS-Exchange-Transport-CrossTenantHeadersStamped: OSBPR01MB2293 Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP This patch uses usb role switch API if the register suceeeded. Signed-off-by: Yoshihiro Shimoda --- drivers/usb/gadget/udc/renesas_usb3.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/usb/gadget/udc/renesas_usb3.c b/drivers/usb/gadget/udc/renesas_usb3.c index c878449..bfb5803 100644 --- a/drivers/usb/gadget/udc/renesas_usb3.c +++ b/drivers/usb/gadget/udc/renesas_usb3.c @@ -657,7 +657,11 @@ static void _usb3_set_mode(struct renesas_usb3 *usb3, bool host) static void usb3_set_mode(struct renesas_usb3 *usb3, bool host) { - _usb3_set_mode(usb3, host); + if (usb3->role_sw) + usb_role_switch_set_role(usb3->role_sw, host ? + USB_ROLE_HOST : USB_ROLE_DEVICE); + else + _usb3_set_mode(usb3, host); } static void usb3_vbus_out(struct renesas_usb3 *usb3, bool enable) @@ -672,8 +676,8 @@ static void usb3_mode_config(struct renesas_usb3 *usb3, bool host, bool a_dev) { unsigned long flags; - spin_lock_irqsave(&usb3->lock, flags); usb3_set_mode(usb3, host); + spin_lock_irqsave(&usb3->lock, flags); usb3_vbus_out(usb3, a_dev); /* for A-Peripheral or forced B-device mode */ if ((!host && a_dev) ||