From patchwork Tue Jun 26 23:45:31 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jun Li X-Patchwork-Id: 10490349 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id A4E6D60325 for ; Wed, 27 Jun 2018 00:03:37 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 97C5F1FF13 for ; Wed, 27 Jun 2018 00:03:37 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 8AF4E26E54; Wed, 27 Jun 2018 00:03:37 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 205C71FF13 for ; Wed, 27 Jun 2018 00:03:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934346AbeF0ADe (ORCPT ); Tue, 26 Jun 2018 20:03:34 -0400 Received: from mail-eopbgr00087.outbound.protection.outlook.com ([40.107.0.87]:56349 "EHLO EUR02-AM5-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S934331AbeF0ADd (ORCPT ); Tue, 26 Jun 2018 20:03:33 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=OwTHPiM6T546g3jxJ3gIf3117HG7dd2IEaRToXadVfQ=; b=Ihustbr3/lusFB6mo48/iRaKlq4zgYV/1xoWzA8xf1nNVfl8EPRUby7xtYz0LTpoborbNize782gWXgJ5Mw/YxghmX1gFZVDmstGV3mlJ4OxPf3LnOSj/wC0oW/J+n0JmHe3zjH6y/dt83oSPMC+MvgUz+ecDJ5t32E8lVzsFjE= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=jun.li@nxp.com; Received: from b47624-OptiPlex-7040.ap.freescale.net (92.121.68.129) by AM0PR0402MB3908.eurprd04.prod.outlook.com (2603:10a6:208:f::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.884.22; Wed, 27 Jun 2018 00:03:27 +0000 From: Li Jun To: robh+dt@kernel.org, gregkh@linuxfoundation.org, heikki.krogerus@linux.intel.com, linux@roeck-us.net Cc: a.hajda@samsung.com, jun.li@nxp.com, cw00.choi@samsung.com, shufan_lee@richtek.com, peter.chen@nxp.com, devicetree@vger.kernel.org, linux-usb@vger.kernel.org, linux-imx@nxp.com Subject: [PATCH v8 13/14] staging: typec: tcpci: Only touch target bit when enable vconn Date: Wed, 27 Jun 2018 07:45:31 +0800 Message-Id: <1530056732-9640-14-git-send-email-jun.li@nxp.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1530056732-9640-1-git-send-email-jun.li@nxp.com> References: <1530056732-9640-1-git-send-email-jun.li@nxp.com> MIME-Version: 1.0 X-Originating-IP: [92.121.68.129] X-ClientProxiedBy: HK0P153CA0011.APCP153.PROD.OUTLOOK.COM (2603:1096:203:18::23) To AM0PR0402MB3908.eurprd04.prod.outlook.com (2603:10a6:208:f::28) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 022c80b7-6415-43a5-55dd-08d5dbc16b1b X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(8989117)(4534165)(4627221)(201703031133081)(201702281549075)(8990107)(5600026)(711020)(48565401081)(2017052603328)(7153060)(7193020); SRVR:AM0PR0402MB3908; X-Microsoft-Exchange-Diagnostics: 1; AM0PR0402MB3908; 3:DmjBX21aOqpr6+qCQfohI/oE1MqS1PJcINbS11kB0ZDccjwH5xy9AgWxZkWcvKfrT/vZxgoI7KpAYJQHyvfNRg7sCR1lkJO07R4M+BpGVo4aE9wLFS5684BKp/twSMhIUuh4nE6LsNydyw1Fc7m4srqiiUo4mHdLEO/ZrH2XnUHLzhd7jegIkkST2xAVWZeLFWC0lO7+6ReG0U5iXlc9W8Fg+KlrcTk1IOBlL9kt4/TEZZqpJvSCBmOFEjsoqOVX; 25:y+eVObRAFNGo0Xfb93zd34fEcrWDq5Mtv3/RhawjqM8yn1tTgZCSWGB0vloWSD71o6BTOupFoSD3osGd5eMez/ryooBjHq7bMv5TMincQ3I4NW8ITXXM/RDP5ZAkyYl5ylAlucqBB0BFMK15u36Rew7W2A4E1JRCvnKu32EXcKK7rgo14hqKdk0qsePndKRlu6jJ/4Z1ZFkp1UnLKqAeJyPKxRYbIXgoSmOz5HNNDGNXi7TcIyqnEde1Pay+6qt4JAmBzLMYCXFsg0IvAtF46SmTco8xNYw1k4iL7hjMOfAlfWa9Bn8pmRQr62aMOWXIEl0LR0SFZdOkNFSEID1e7A==; 31:AqwAesoLzR7/jR0vAuPO+tP6v7QiQVqAug4+8BTBq7LcmKySuKEC0J4FdiW8T/EsYrfsNoaHhcRTWqIayNV8iP8zWYtW1sRVHh3yTR4pZPNyUQXYPC40ZZFNMV8of8jYXi63k/qOGA4nWVa+pWmMr8Vz3IyI4qmQNfCcOo5sSwnGY8LXDx74FRBQN7TT33yD6YUznGD+3rg228jE2y6P/OLBzerOEmklbEZg9wosXgs= X-MS-TrafficTypeDiagnostic: AM0PR0402MB3908: X-Microsoft-Exchange-Diagnostics: 1; AM0PR0402MB3908; 20:123p7YnMlkUXHF+/NBNzWS8y7ElP+o/AXbePgRprGJJDB4GrHBwLP58/zaaNwrcbOImhaVKTU88mJq5/TEsUxSRDuqtnRnquzDz6c8ds7ZfjUgDESuLvXRKz5Co6pAdJyCPE6W0H07xDcSA8Fq6AcvmwFBu0U6OhyD0mJWtNgzbaEDygIgH1VwhjmVWlyhGfioWAm1EjO5HZJSYFw1DBIHkfdaFE4l/Gbr9tUcs04zjNoV0Nuiw2ir2z1kh/K6ZlHF7/fZ18HKE7cokhNGbALM9zdPuO8lMdpKrS+bUVF8iOBk7eEe7OE3wVectDrbhjeEoETdt+zHyuaI3HKrJc0ix7YxGMaiBbbdO0HEG2mah6mMpuL3umEvd9E0pMj8rmmY4ezCPOH9Tml3/GLFTNOQxHxcFzqf73Wk6i841BQN5Jg1X4EOWZeWNDiw2moHXWYornht3jJ2MAmYxN6wSIan/Anub9xLsD0KU5z2GxBJPabzg5XylJ0og3BxS3eJ5p; 4:x1X0wBE2rJK9nAGTRV0RbsF2CK16zmHcw/3y+s7LcbAktsT9N0MedwsCqLiRod6waUf3K7MYZd60/tKXEqS/DVRe2uTnS6n/eWM7VFuElcD0Bq+J3dssGb8e+tUarv/6khFjBkRUqFkR8wOwOpmzLEP0LNaqDBvBV7qcoydq1+HWapKS0nCfM8uY5Kf7Y4CrbDt9I0LZ5z2cu3WuhwxMVQTYxAhdVrzAkmQUxcTAoRIiofSgno+7dKw6fRmi1qAOVfQ4J6MJhche6Gvvkuc1lBUd8P2rMo/24N3JyU7dfPdWUczCt76nXmNP2PddDy04PuaelIxWBjXOyWm3B6hHBYxFuHdyD9eh0pXUz+GHcE4= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(185117386973197)(228905959029699); X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(93006095)(93001095)(10201501046)(3002001)(3231254)(944501410)(52105095)(6055026)(149027)(150027)(6041310)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123562045)(20161123560045)(20161123564045)(20161123558120)(6072148)(201708071742011)(7699016); SRVR:AM0PR0402MB3908; BCL:0; PCL:0; RULEID:; SRVR:AM0PR0402MB3908; X-Forefront-PRVS: 0716E70AB6 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(979002)(1496009)(346002)(136003)(376002)(366004)(39860400002)(396003)(189003)(199004)(2906002)(14444005)(5024004)(7736002)(26005)(6486002)(305945005)(486006)(48376002)(478600001)(86362001)(25786009)(4326008)(16526019)(186003)(36756003)(50466002)(16586007)(68736007)(6512007)(47776003)(51416003)(52116002)(53936002)(3846002)(386003)(6506007)(6116002)(76176011)(316002)(97736004)(50226002)(476003)(2616005)(956004)(6666003)(11346002)(446003)(106356001)(8936002)(81156014)(66066001)(5660300001)(81166006)(8676002)(105586002)(969003)(989001)(999001)(1009001)(1019001); DIR:OUT; SFP:1101; SCL:1; SRVR:AM0PR0402MB3908; H:b47624-OptiPlex-7040.ap.freescale.net; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; Received-SPF: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; AM0PR0402MB3908; 23:NnwvYCHPvsDWlhTuzDa+N/+l+IOMQegNRSWL8MN?= =?us-ascii?Q?UP5QMW2At+E7h2v75wVQ4idw+lqLT1y/oVYcMUJfgB9qACDigtzmH77oIVdu?= =?us-ascii?Q?bC+5ecqgZptk0awM9PSksRJyc7IiuSHluP5DuLsKAE6jF8pDOoA4Qf3xnj0C?= =?us-ascii?Q?goH+d1prtps6ENnL8oEGgmYVsRZMUY02R7bT7czIZ/az21TagM1RLBtxccfl?= =?us-ascii?Q?NX40KzwYO6mWrlpZyDhQVanHY4UIrCVdCahC/XlC9KLqKuSSHxPaQmtoN9MK?= =?us-ascii?Q?sg2UTN7kumHNbjPfWBJw/zM6v86+uMfuNGQmgTKCYF3g8f+sMrzt5oqa8sM0?= =?us-ascii?Q?i3SID0C9iCidwfIRhrXMRHynZQLY7rUikF3z9tnrirl3k4/2TZAa2lv4toNN?= =?us-ascii?Q?+vTiIJPKUudhd+3btFfKHAqZz4PdiMi1yeY6lTZ9skCwDAIKLAuOxYxMia7A?= =?us-ascii?Q?ieQ/tKllHlwLnjkM2h802bWAiRRHQFbgFbzoiwVJy/jEAUktNmipN5THyOHv?= =?us-ascii?Q?4CdZQ3M15mph68c94LnkD9i3QLHQ2++OiwmnXU50yiuwgw4Ey8Z2MzGzLkQt?= =?us-ascii?Q?DLgUEaVfWQNHOPSfdbaLi0B6mFQSYZzXwi1hZZUaPdZNO7qzPzbi/4Z5gnV9?= =?us-ascii?Q?pIq50i7VdD8zz3kGWYdBBn6kkHLAlgtARcYI7LW9krJ2Rheh+glAPcAmrtMM?= =?us-ascii?Q?9HpU+EuN28HXPejPkkHsGeWO1ZI2LeXF8GvyeGJ+K6pmJ0360qt6Nzz8fGzE?= =?us-ascii?Q?MVF71owleQuOI1CpuOmvtjiSAI5IPzhLnEtW9a4/2I/t5e1Q0/kvFu5M5rUO?= =?us-ascii?Q?t+eZuMPf4tZbXrfVXUs6QBrgr8x4RGKLtTa03pKhL0/NnzxmhYZ5jLnmlMt8?= =?us-ascii?Q?foUfpOUK5AcvjltCizXKFMmNXZ2PTNmy72aUvPXgEA3NRoWdlKXN/d1cJNqP?= =?us-ascii?Q?D0I04S6Q+5zvwV5c/RaYAGOia4Q14LHxo0QMx714AZeBaxGz0sfgnFcexQ/o?= =?us-ascii?Q?+MnWzSoV4q/9YSOvDSnq2ZcTVPZbjhzWTrvg1SzCRERX1vXEEIQADobEkda0?= =?us-ascii?Q?50l8vi0ifH14YpjUyPEii/j6qjqeNR+3nO6k72ZkgF9//eRiWsw3Xxh4wKDO?= =?us-ascii?Q?DM2lCPuQwm055jW6FGw2MuvseMfMLRDRttkC/YhR312583r9esFWEiNERwvy?= =?us-ascii?Q?VqglYu9SYKvTIRXRBh6vogGxHGhtHCgXaxnYRE0uyVCoN389WSO3D9QtHX4p?= =?us-ascii?Q?/AxM9ZPC1nzZBWsON9kaIdy/3S2EuzxVZaDuHukXdr1sT54qzwirjVeiGYPi?= =?us-ascii?Q?X+w=3D=3D?= X-Microsoft-Antispam-Message-Info: JEzUfcXKDDzJcj9C2uMm6t8HJ1VN2/oUUXs4e+uwCMhqL99vWOL7d/V2xt4EsfDp18w4G62NJx6eioXu0kn1PQwKHlq14yTaJDL1CbZ4EVQjaQ8l3FRTLLgugY4wxkv5IgZgYHrc2vrZMFeSkhu2ttt0GWbYuUhplyiZiAIllAA84/RfuIybRPyEG6yE0w7lR/+3h1xaz1slV6agODuoSOqKnauNySY1zbEcfLbH0EYGtsdkdcDGDYnGQgPbwQy69PSBAtsM+pi6p/iCn3/6II4yoUkca/ogOBCXwe7mcSK7Hh9bethCCRoKa3LDSNsCFv/M/fnfcPCIyZwLartSkhmMoxrdHp7dqivulTzdG9U= X-Microsoft-Exchange-Diagnostics: 1; AM0PR0402MB3908; 6:j5Ufz5i7sh6tv+Y3GlFQXl/C1fOzvBvlwTNWy0bAwV4MXe7AKq0eJYUryc9k/nlwtplMa/lleYTLHm0xkX5yAjqyGjVzjAhUfJLcdPf/nk/qnsJ/Xi3r+CVMFTEpX93XWFeNUslPYvxVZDB9nlxngNLf2UdVz3y060WXITIiqNL2wiVhpVDYxv3/XKgS4TNyHNgiNMG6l8wTAtZP6VnAqH7VnUP7rX+Uxi8/3+O+b0Ivfw20t7nXx+pyWLZkehIfVgiqWt1vqz9Gh2Bjg7OAcEMxv6GDgId9eDt/p5/XGnrb9DKEdmdjrwHRkaTWeluKefi/Im9SNt38iWfSTsP934G+xOsdorT47x1AW5nrb48t2KxbTTmhDnguxoPElLkwpabVGjyeCAd8SaRSBtczOHnuE8+q/BTaVmZzR+JCHCDUvjFSGjXFnYNdfgbEwMc0KH+Z0hq4HTaWpVt4IxdGFw==; 5:8bC5S8rl6tYUs71yD/6hPJ208dgkBz2ohXy6z/Fu0X/++Ty+/ddbMbrgZrmWlNwBKWDUEnrmYkd+oHdSoeltId7dJvbYDbfNAg9oISdAhsIsIzYbkaSWkKGKXSWzXct5/vO87N8s1wUf1Le+OXO7lGgieAoDBdEk6oBTdb71uKc=; 24:CT/keYCrngc+PktO7ZMATb0lagIysgHZE8ZGFSTExum/AxxyiXPG6sO+mitHbmBbwdPUi1a9NKQ71VtF31OFgPF7cHRMEXbH6caj06VpdyM= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; AM0PR0402MB3908; 7:7aKaqmq6f+xS6nnku20s4tP4tvhPZMQMr7lRAZ22YzJ48lD3+H1cGnUWg3S4K5Uo/ODcnclDbS+cWRntkA5NxhIJBBMY5E+MjpyeGMHVSNou6/QVutDDMK2mDHd03Vgwzq1KLhDJSTC/M2QIdEMM+kY6jikpwh+aIB+nvfDsVBp8jeafEMJT/n8yRy5JfH/9fDqSw6MUeoGH57T5BX+MLTVANovpO1Dk2f1ySHMYZU3b0aVzowNmTajUpolEJf5s X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Jun 2018 00:03:27.0229 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 022c80b7-6415-43a5-55dd-08d5dbc16b1b X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR0402MB3908 Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP We need regmap_update_bits to avoid touch any other bits when enable or disable vconn. Reviewed-by: Guenter Roeck Reviewed-by: Heikki Krogerus Signed-off-by: Li Jun --- drivers/staging/typec/tcpci.c | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/drivers/staging/typec/tcpci.c b/drivers/staging/typec/tcpci.c index 11c2d37..ac6b418 100644 --- a/drivers/staging/typec/tcpci.c +++ b/drivers/staging/typec/tcpci.c @@ -218,12 +218,9 @@ static int tcpci_set_vconn(struct tcpc_dev *tcpc, bool enable) return ret; } - ret = regmap_write(tcpci->regmap, TCPC_POWER_CTRL, - enable ? TCPC_POWER_CTRL_VCONN_ENABLE : 0); - if (ret < 0) - return ret; - - return 0; + return regmap_update_bits(tcpci->regmap, TCPC_POWER_CTRL, + TCPC_POWER_CTRL_VCONN_ENABLE, + enable ? TCPC_POWER_CTRL_VCONN_ENABLE : 0); } static int tcpci_set_roles(struct tcpc_dev *tcpc, bool attached,